David Heinemeier Hansson
1d00a53400
Provide etag for pins too
2025-11-03 16:53:49 +01:00
David Heinemeier Hansson
418548b9ba
More efficient query for watched_by? and use etag for the status
2025-11-03 16:51:21 +01:00
David Heinemeier Hansson
f5977522cb
Use shared callback to set card
2025-11-03 16:51:21 +01:00
Jorge Manrubia
f2d702fb54
Merge pull request #1457 from basecamp/assignee-update
...
A couple of fixes for updating cards:
2025-11-03 16:12:38 +01:00
Jorge Manrubia
24da4066b7
Refresh the full meta area so that the assignee name gets updated too
2025-11-03 16:11:53 +01:00
Jorge Manrubia
00818697ef
Use page refreshes with morphing to avoid flickering
...
Replacing the card container will reload the frame. Also, see
https://github.com/basecamp/fizzy/commit/5b70320a6b64adf2d1e0be4bd7dc221a5ba80c95
2025-11-03 16:11:53 +01:00
David Heinemeier Hansson
fcad4518da
Split callbacks for easier overwriting
2025-11-03 16:00:35 +01:00
David Heinemeier Hansson
6678d0e4fc
No longer used
2025-11-03 15:58:36 +01:00
David Heinemeier Hansson
65d04f681a
DRY up the public controllers by introducing a shared base class
2025-11-03 15:56:25 +01:00
David Heinemeier Hansson
393e5fd3d4
Don't want to ship with this wart
...
cc @monorkin
2025-11-03 15:30:44 +01:00
David Heinemeier Hansson
42ebdf9ac1
More natural conditional
2025-11-03 15:29:20 +01:00
David Heinemeier Hansson
9913853cc6
Remove anemic concern
2025-11-03 15:27:12 +01:00
David Heinemeier Hansson
3116cea6a1
Stick with turbo stream templates for everything
2025-11-03 15:18:04 +01:00
David Heinemeier Hansson
3ed5c53b31
Use existing CollectionScoped
...
It enforces access restrictions on collections too
2025-11-03 15:12:38 +01:00
David Heinemeier Hansson
8d28c25a7b
Unnecessary
2025-11-03 15:06:41 +01:00
David Heinemeier Hansson
ed9259fa1a
Ivar not used
2025-11-03 15:04:03 +01:00
David Heinemeier Hansson
995dcfe8e6
Simplify setup and pull query-prevention into model
2025-11-03 15:00:15 +01:00
David Heinemeier Hansson
2bf95f5b9a
Just stick to default
2025-11-03 14:49:01 +01:00
Jorge Manrubia
7f7ecdaf28
Merge pull request #1456 from basecamp/only-show-draft-banner
...
Only show draft banner when the draft has some previous title/content set
2025-11-03 14:48:51 +01:00
David Heinemeier Hansson
e081ce5e76
Consistently use symbols for module scopes
2025-11-03 14:47:48 +01:00
Jorge Manrubia
42a8b52fa1
Don´t show draft banner if the card is not filled
2025-11-03 14:47:29 +01:00
Jorge Manrubia
ebf8490c2b
Use Turbo.fetch to prevent page refreshes bounces when using rails/requests
2025-11-03 14:46:22 +01:00
David Heinemeier Hansson
ecd0d319cc
Style
2025-11-03 14:44:46 +01:00
David Heinemeier Hansson
ed6745e163
Style
2025-11-03 14:42:21 +01:00
Jorge Manrubia
111d4900ef
Only show draft banner if the card had some data
2025-11-03 14:41:27 +01:00
David Heinemeier Hansson
6336a47732
Style
2025-11-03 14:40:42 +01:00
David Heinemeier Hansson
b2603187a9
Style
2025-11-03 14:40:12 +01:00
David Heinemeier Hansson
113003afa9
Stlye
2025-11-03 14:40:12 +01:00
David Heinemeier Hansson
f8b5a64e9c
Already included in the layout now
2025-11-03 14:40:12 +01:00
David Heinemeier Hansson
1277ec5347
Extract jump_field_tag helper
2025-11-03 14:40:12 +01:00
Jorge Manrubia
2d1619fd34
Merge pull request #1455 from basecamp/fix-broadcasts
...
Don't broadcast card changes when touching activity spikes
2025-11-03 14:36:36 +01:00
Jorge Manrubia
c007176ed0
Don't broadcast card changes when touching activity spikes
...
We do this from jobs, so there is no request id to discard the page refresh in the client. We
don't want page refreshes in these cases, as those are normally handled via the change that
originated this detection, in any case.
2025-11-03 14:35:06 +01:00
David Heinemeier Hansson
61d05ee073
No longer used
2025-11-03 14:31:16 +01:00
David Heinemeier Hansson
992b149395
No longer used
2025-11-03 14:29:01 +01:00
David Heinemeier Hansson
f9ff13cdc4
Add http caching for user events
2025-11-03 14:25:32 +01:00
David Heinemeier Hansson
c25fcc087a
Test avatars controller
2025-11-03 14:21:53 +01:00
David Heinemeier Hansson
b05e7c04e1
Ensure you can only delete your own avatar or else you have to be admin
2025-11-03 14:21:48 +01:00
David Heinemeier Hansson
4c2f3ef0b8
Style
2025-11-03 14:21:25 +01:00
David Heinemeier Hansson
3ec9308345
Always bang for exceptions
2025-11-03 14:21:06 +01:00
David Heinemeier Hansson
2f1ee30a2b
Remove duplicated nesting
2025-11-03 14:20:57 +01:00
David Heinemeier Hansson
aeb23b691c
Always use templates for turbo streaming to stay consistentn
2025-11-03 13:46:34 +01:00
David Heinemeier Hansson
0a9e1620a0
No longer needed
2025-11-03 13:46:22 +01:00
David Heinemeier Hansson
225a70fc52
Remove here too
2025-11-03 13:40:20 +01:00
David Heinemeier Hansson
38a7a14466
Remove vector extension that we are no longer using
2025-11-03 13:40:03 +01:00
Jorge Manrubia
3293300b20
Merge pull request #1454 from basecamp/refresh-perma-activity
...
Better card perma refreshing
2025-11-03 13:23:37 +01:00
Jorge Manrubia
37ce2c98d1
Refresh the cards perma dynamically with page refreshes
2025-11-03 13:04:21 +01:00
Jorge Manrubia
5f7feed6c4
Refresh activity-related bits in the card perma dynamically:
...
- Remove entropy bubble
- Refresh the auto close notice https://app.box-car.com/5986089/cards/2683
2025-11-03 12:48:57 +01:00
Jorge Manrubia
d45f2fc4a9
Merge pull request #1453 from basecamp/steps-flickering
...
Remove flickering when adding steps
2025-11-03 11:01:06 +01:00
Jorge Manrubia
da6d1011fd
Replace card replacement with stream actions to prevent flickering when managing steps
2025-11-03 10:59:24 +01:00
Jorge Manrubia
1d6cc37bb4
Add missing blank content validation
2025-11-03 10:57:35 +01:00