Commit Graph

6168 Commits

Author SHA1 Message Date
Jorge Manrubia 1d12ecc65b Scope collections to column 2025-10-31 10:40:28 +01:00
Jorge Manrubia b0e5a5ccb5 Some fixes for HTTP caching not being invalidated properly 2025-10-31 10:40:26 +01:00
Jorge Manrubia 108d7b2835 Rename collection to cards since this is a regular partial now 2025-10-31 10:39:53 +01:00
Jorge Manrubia 12545dac80 Extract common partials 2025-10-31 10:39:53 +01:00
Jorge Manrubia 7421f18c11 Format 2025-10-31 10:39:53 +01:00
Jorge Manrubia 176b8ad3b5 Move caching to collection rendering 2025-10-31 10:39:51 +01:00
Jorge Manrubia 2a79cb413e Remove cacheable concern, inline cache helper 2025-10-31 10:38:52 +01:00
Jorge Manrubia c1936abed9 Reuse concern 2025-10-31 10:37:36 +01:00
Jorge Manrubia e8630159ab Not need to cache on the associations since we load those via turbo frames in the perma now 2025-10-31 10:37:36 +01:00
Jorge Manrubia bcac3fad10 Move perma collection picker to turbo frame 2025-10-31 10:37:36 +01:00
Jason Zimdars 89ca92fc52 Merge pull request #1431 from basecamp/jz/10-30-25-pm
JZ 10/30/25 pm
2025-10-30 17:22:15 -05:00
Jason Zimdars 07d74d987d Typo 2025-10-30 17:21:06 -05:00
Jason Zimdars 8c4d3fd700 Don't try to orient these
We need to figure out how to handle the assignment popup when it's close
to the bottom of the screen but this isn't doing it
2025-10-30 17:11:22 -05:00
Jason Zimdars e83816d69c Merge pull request #1430 from basecamp/jz/10-30-25
JZ 10/30/25
2025-10-30 14:10:20 -05:00
Jason Zimdars 88867e4345 Merge branch 'main' into jz/10-30-25 2025-10-30 14:03:21 -05:00
Jason Zimdars 4ecf81cd32 Resize dialogs to fit viewport 2025-10-30 14:00:56 -05:00
Jason Zimdars ec620f98a6 Need to opt-out of orient-top if there isn't space above 2025-10-30 13:57:20 -05:00
Jason Zimdars 4c7578c782 Need to reset both inline values or the tooltip gets squished 2025-10-30 13:50:21 -05:00
Jason Zimdars 2c04199277 No longer used
And hilariously was unintentionally renamed when we went from 'pop' to
'closure'
2025-10-30 12:36:15 -05:00
Jason Zimdars 48fd1f3502 Use debounced submit to prevent duplicate submissions 2025-10-30 12:16:35 -05:00
Jason Zimdars 8d0041f6b9 Add a busy state for form buttons 2025-10-30 12:05:27 -05:00
Jason Zimdars cba945104a Make it harder to deselect yourself 2025-10-30 11:49:27 -05:00
David Heinemeier Hansson 5a02410a8c More style 2025-10-30 17:16:52 +01:00
David Heinemeier Hansson a07286dcd1 Style 2025-10-30 17:16:12 +01:00
David Heinemeier Hansson 9f7a97eeea Always use camel case for turbo frames 2025-10-30 17:16:03 +01:00
Jason Zimdars 30d70429e9 Fix wrapping 2025-10-30 11:11:27 -05:00
David Heinemeier Hansson 16755b3283 Make partials live with the root templates including them 2025-10-30 17:10:52 +01:00
David Heinemeier Hansson 2c290193cd Spacing 2025-10-30 17:08:49 +01:00
David Heinemeier Hansson fc409d35c3 Stick with HTML when there's no conditional logic 2025-10-30 17:08:09 +01:00
David Heinemeier Hansson 9bbac44f84 Dont reference ivars in partial 2025-10-30 16:59:57 +01:00
David Heinemeier Hansson 1baf554864 Spacing 2025-10-30 16:59:21 +01:00
David Heinemeier Hansson d3028262af Spacing 2025-10-30 16:47:17 +01:00
David Heinemeier Hansson 99247cb29c Spacing 2025-10-30 16:46:24 +01:00
David Heinemeier Hansson 1572147d5b Spacing 2025-10-30 16:43:27 +01:00
David Heinemeier Hansson 10d7fd3268 Rely on the passed in card object, not ivar 2025-10-30 16:43:24 +01:00
David Heinemeier Hansson 333634a5cc Rely on model to route 2025-10-30 16:41:37 +01:00
David Heinemeier Hansson acb7216b8b Spacing 2025-10-30 16:41:15 +01:00
David Heinemeier Hansson cc0252e39c No longer used 2025-10-30 16:40:04 +01:00
David Heinemeier Hansson b57317ef60 Spacing 2025-10-30 16:38:11 +01:00
David Heinemeier Hansson 6cf6076041 Rely on model to route whenever possible 2025-10-30 16:38:03 +01:00
David Heinemeier Hansson 67f0876ba7 In order of use 2025-10-30 16:36:15 +01:00
Jason Zimdars 5084952e3b Don't animate restored column 2025-10-30 10:29:51 -05:00
David Heinemeier Hansson 70a506c4a3 My menu is on every screen when the user is logged in 2025-10-30 16:28:51 +01:00
Jason Zimdars 17a33a9c81 Avoid setting column on closed cards 2025-10-30 10:10:33 -05:00
Jason Zimdars f82f44e300 We don't want this on the new card form 2025-10-30 10:05:02 -05:00
David Heinemeier Hansson 3062890c27 Not used for unfurling or for public consumption 2025-10-30 16:03:31 +01:00
David Heinemeier Hansson dfc50faee9 Extract helper instead of using anemic partial 2025-10-30 16:03:10 +01:00
David Heinemeier Hansson 397b7e176f No longer used 2025-10-30 15:56:42 +01:00
David Heinemeier Hansson 6c15610fb3 Fix test 2025-10-30 15:56:12 +01:00
David Heinemeier Hansson 3e118e9ad7 We are not using internal collection pages for unfurling or publicly readable consumption 2025-10-30 15:51:34 +01:00