Commit Graph

4903 Commits

Author SHA1 Message Date
Mike Dalessio 1ffc2ee9b7 Merge pull request #1103 from basecamp/flavorjones/fix-vcr-user-highlights
Fix VCR cassettes for user highlights
2025-09-13 10:57:42 -04:00
Mike Dalessio 5c44a93172 Fix VCR cassettes for user highlights 2025-09-13 10:54:38 -04:00
Jason Zimdars 154c1a8a15 This was a debug value 2025-09-12 18:09:52 -05:00
Jason Zimdars b98734e275 Merge pull request #1102 from basecamp/jz/polish-9-12-25
JZ/polish 9 12 25
2025-09-12 17:30:16 -05:00
Jason Zimdars 25a6a63952 Give it a little more width 2025-09-12 17:28:08 -05:00
Jason Zimdars 36c3571848 Fix spacing, simplify layout 2025-09-12 16:08:24 -05:00
Jason Zimdars f0a2d50195 Move to constant, whitespace 2025-09-12 15:33:09 -05:00
Jason Zimdars 4579f759c9 Merge pull request #1099 from basecamp/watching-polish
Watching polish
2025-09-12 14:33:37 -05:00
Jason Zimdars 24d4bd2551 Limit to one row 2025-09-12 14:32:42 -05:00
Jason Zimdars e717875dfc Fix button style regression 2025-09-12 13:57:33 -05:00
Jason Zimdars 244fed1436 Merge pull request #1088 from basecamp/watchers
Watchers
2025-09-12 12:05:26 -05:00
Jorge Manrubia c386b42e07 Fix VCR fixtures 2025-09-12 19:01:10 +02:00
Jorge Manrubia 2654cfe27d Format 2025-09-12 18:59:41 +02:00
Jorge Manrubia 9e5108bcae Touch user on modification to invalidate cache
For the new "add card" in the cards screen
2025-09-12 18:59:18 +02:00
Jorge Manrubia ba3b782d21 Merge branch 'main' into watchers
* main:
  Fix add card not working in the cards screen
  Submit and refresh results as you type terms
  Fix: When expanding filters, submitting filters should keep the filters expanded
  Invalidate cache when filter changes
  Switch to gpt-5-chat
  Handle filter toggles with JS
  Prevent glitch where you see the filter bar expanded when you clear it
  Remove unused templates
  Fix: all collections link not working after moving to turbo frame
  Restore cache I deleted by mistake
  Speed up filter expansion with turbo stream
  Fix: filtering collections not working after moving menu to turbo frame
  Respect params when loading the menu or they won't be reflected!
  Add HTTP cache for the menu
  Load main menu lazily with a turbo frame
  Inline :has(&) as it's REALLY slow in Safari
  Extract helper method
  Remove transition that is making Safari choke when navigating to Fizzy menus
  Reduce page size to reduce load for processing local times on initial page load
  Avoid having to parse strings

# Conflicts:
#	app/views/cards/index/_add_card_button.html.erb
#	test/vcr_cassettes/period_highlight_test-test_don_t_generate_highlights_for_existing_periods.yml
#	test/vcr_cassettes/period_highlight_test-test_generate_period_highlights.yml
#	test/vcr_cassettes/user/highlights_test-test_don_t_generate_highlights_for_existing_periods.yml
#	test/vcr_cassettes/user/highlights_test-test_generate_weekly_highlights.yml
2025-09-12 18:52:17 +02:00
Jorge Manrubia b79e754443 Merge branch 'faster-filters'
* faster-filters:
  Fix add card not working in the cards screen
2025-09-12 18:42:34 +02:00
Jorge Manrubia 877400afbf Fix add card not working in the cards screen 2025-09-12 18:42:17 +02:00
Jorge Manrubia 58cf8b3428 Merge pull request #1097 from basecamp/faster-filters
Submit and refresh results as you type terms
2025-09-12 18:28:41 +02:00
Jorge Manrubia 55a22f98e3 Submit and refresh results as you type terms 2025-09-12 18:25:27 +02:00
Jorge Manrubia faaeb68890 Merge pull request #1096 from basecamp/filters-collaps
Fix: When expanding filters, submitting filters should keep the filters expanded
2025-09-12 18:06:04 +02:00
Jorge Manrubia b7b705ba19 Fix: When expanding filters, submitting filters should keep the filters expanded 2025-09-12 18:01:25 +02:00
Jorge Manrubia 774ff99f29 Merge pull request #1095 from basecamp/fix-caching-issue-2
Invalidate cache when filter changes
2025-09-12 17:15:21 +02:00
Jorge Manrubia 4580ed5e0d Invalidate cache when filter changes
https://fizzy.37signals.com/5986089/cards?collection_ids%5B%5D=2
2025-09-12 17:10:58 +02:00
Jorge Manrubia 99f86b7f0d Merge pull request #1094 from basecamp/update-to-gpt-5-chat-latest
Switch to gpt-5-chat
2025-09-12 16:18:05 +02:00
Jorge Manrubia eabce24415 Switch to gpt-5-chat
Cheaper and good enough

https://3.basecamp.com/2914079/buckets/37331921/todos/9041305517
2025-09-12 16:16:54 +02:00
Jorge Manrubia bf6f4cf2ba Reorded method and remove unnecessary param 2025-09-12 14:46:05 +02:00
Jorge Manrubia 57225e7c9a Add migration to convert accesses 2025-09-12 14:38:20 +02:00
Jorge Manrubia 30cdb658b6 Merge pull request #1093 from basecamp/refine-filter-expansion
Refine filter expansion (handle in the client)
2025-09-12 14:15:12 +02:00
Jorge Manrubia 5e0918d373 Handle filter toggles with JS
To make them feel faster
2025-09-12 14:12:16 +02:00
Jorge Manrubia ae4fbc6443 Prevent glitch where you see the filter bar expanded when you clear it 2025-09-12 14:08:36 +02:00
Jorge Manrubia 6eb1e47d1c Merge pull request #1092 from basecamp/all-collections-bug
All collections bug
2025-09-12 13:53:25 +02:00
Jorge Manrubia 3f9f5e5025 Remove unused templates 2025-09-12 13:52:40 +02:00
Jorge Manrubia 249addc8dd Fix: all collections link not working after moving to turbo frame
This is turbo handling the GET form under the hood ignoring the script name
2025-09-12 13:52:35 +02:00
Jorge Manrubia a6c2bac780 Restore cache I deleted by mistake 2025-09-12 13:17:49 +02:00
Jorge Manrubia baa99aa6a8 Merge pull request #1091 from basecamp/fast-filter-expansion
Speed up filter expansion with turbo stream
2025-09-12 13:12:18 +02:00
Jorge Manrubia af6cb37db1 Speed up filter expansion with turbo stream 2025-09-12 13:06:00 +02:00
Jorge Manrubia d4921c82da Merge pull request #1090 from basecamp/filtering-issue
Fix filter menu issues after moving it to turbo frame
2025-09-12 12:11:39 +02:00
Jorge Manrubia 87ed533b2e Fix: filtering collections not working after moving menu to turbo frame 2025-09-12 12:10:56 +02:00
Jorge Manrubia 13cc12514a Respect params when loading the menu or they won't be reflected! 2025-09-12 12:10:46 +02:00
Jorge Manrubia d7252ce0b0 Merge pull request #1089 from basecamp/safari-optimization-time
Several performance optimizations
2025-09-12 11:10:51 +02:00
Jorge Manrubia fe9f59a2bd Add HTTP cache for the menu 2025-09-12 11:08:20 +02:00
Jorge Manrubia 0a98cbb6b3 Load main menu lazily with a turbo frame 2025-09-12 11:01:56 +02:00
Jorge Manrubia 1554c6b29f Inline :has(&) as it's REALLY slow in Safari
This makes Safari sluggish in general. A particular scenario where it chokes is when
rendering lots of local times with JS (such as in the cards screen when there are many cards).
2025-09-12 11:01:56 +02:00
Jorge Manrubia c67d1e8c2f Extract helper method 2025-09-12 11:01:56 +02:00
Jorge Manrubia e9b7ed63f7 Remove transition that is making Safari choke when navigating to Fizzy menus 2025-09-12 11:01:56 +02:00
Jorge Manrubia 39e9b54d9d Reduce page size to reduce load for processing local times on initial page load 2025-09-12 11:01:56 +02:00
Jason Zimdars d9d3e9f1a2 Update VCR for highlights tests
I don't see how this is related to my changes but it keeps failing
2025-09-11 22:32:04 -05:00
Jason Zimdars 76e2ae47f7 Tighten this up 2025-09-11 21:59:28 -05:00
Jason Zimdars 9ad813e5d0 Fix misleading test
The access involvement changes exposed that this test wasn't doing what it said it was. For this to be a self-assignment the event creator and assignee need to be the same
2025-09-11 21:33:21 -05:00
Jason Zimdars c4dec29b49 Assignment notifications should always be delivered
- They're effectively @mentions
- This means watching really reflects the UI state: Watching for new cards
2025-09-11 21:21:11 -05:00