Commit Graph

7188 Commits

Author SHA1 Message Date
Jason Zimdars 2c4d2df469 Merge pull request #1679 from basecamp/notifications
Cap the max number of unread notifications to 500
2025-11-21 09:34:26 -06:00
Jorge Manrubia 95b555869b not used 2025-11-21 16:31:06 +01:00
Jason Zimdars c0920f046f Move to bottom, use utility classes 2025-11-21 09:29:21 -06:00
Jason Zimdars 2382326a13 Merge pull request #1638 from basecamp/expand-activity-columns
Expand activity columns
2025-11-21 09:11:22 -06:00
Stanko Krtalić b5a28388e6 Merge pull request #1681 from basecamp/blur-comment-field-on-submit
Blur comment field after submission
2025-11-21 16:03:59 +01:00
Stanko K.R. ac2ed4851e Blur comment field after submission 2025-11-21 15:59:22 +01:00
Kevin McConnell 1f7495a5fe Merge pull request #1680 from basecamp/restore-automatic-migrations
Restore automatic migrations
2025-11-21 14:56:40 +00:00
Jorge Manrubia 42a39b224c Cap the max number of unread notifications to 500
Simpler than adding 2 levels of pagination here
2025-11-21 15:55:24 +01:00
Kevin McConnell 621c3ec993 Restore automatic migrations 2025-11-21 14:53:29 +00:00
Jorge Manrubia d14ffc1b79 Merge pull request #1678 from basecamp/notification-bundles
Fix: overlapping notification bundles
2025-11-21 14:46:24 +01:00
Jorge Manrubia c1f5699443 Switch READ-COMMITED so that queries see the last committed data
This should help solving the problem with overlapping bundles

It is what we use in HEY and Basecamp
2025-11-21 14:35:29 +01:00
Jorge Manrubia 41905068c0 Bundle after notification is committed to mitigate reading stale data when bundling
Attempt to deal with overlapping bundles being created by notifications created immediately
one after the other.
2025-11-21 14:34:05 +01:00
Stanko Krtalić 90113206e3 Merge pull request #1676 from basecamp/fix-filters-obscuring-jump-menu
Fix pickers obscuring jump menu
2025-11-21 12:45:54 +01:00
Stanko K.R. dd5cf6f628 Fix pickers obscuring jump menu 2025-11-21 12:41:45 +01:00
Donal McBreen 50b3ae1d79 Merge pull request #1675 from basecamp/tenant-key-remove-indexes
Remove the old fulltext indexes
2025-11-21 11:34:54 +00:00
Donal McBreen cb71af8231 Remove the old fulltext indexes
We only search by account_key, content, and title now.
2025-11-21 11:25:16 +00:00
Donal McBreen d3ea2ebd7b Merge pull request #1674 from basecamp/search-with-tenant-key
Search with the tenant key
2025-11-21 11:20:56 +00:00
Donal McBreen adff4591fe Search with the tenant key
The key has been added and populated so use it for searching.
2025-11-21 11:09:06 +00:00
Kevin McConnell d6eeea6727 Merge pull request #1673 from basecamp/skip-migrations
Don't run migrations on deploy
2025-11-21 10:55:57 +00:00
Stanko Krtalić 342ebc4975 Merge pull request #1672 from basecamp/fix-back-navigation-not-opening-new-tabs
Fix inability to open "Back to" inks in a new tab
2025-11-21 11:53:10 +01:00
Kevin McConnell 3c4c2b5eaa Don't run migrations on deploy 2025-11-21 10:48:53 +00:00
Stanko K.R. 7c15be02f8 Skip navigation when opening a new tab 2025-11-21 11:48:29 +01:00
Donal McBreen a4ce9fc5c0 Merge pull request #1671 from basecamp/search-tenant-key
Search tenant key
2025-11-21 10:42:47 +00:00
Stanko Krtalić ff1d33b075 Merge pull request #1670 from basecamp/fix-rtl-language-support-for-card-titles
Fix RTL language support in card titles
2025-11-21 11:31:43 +01:00
Donal McBreen 74d1cf735b Only add and fill account_key 2025-11-21 10:20:27 +00:00
Stanko K.R. 2b23d85653 Add dir=auto to title inputs
See: https://github.com/basecamp/once-campfire/pull/97
2025-11-21 11:13:44 +01:00
Jorge Manrubia 6e20c8c68f Add brakeman rule 2025-11-21 10:42:08 +01:00
Jorge Manrubia 49e801fdb1 Just the date makes for better-looking URLs 2025-11-21 10:40:37 +01:00
Donal McBreen 70dd754cf7 Account key for search records
Add an account key field to improve search performance. This field
allows us to filter the records by account directly in the fulltext
index, so we only need to examine rows belonging to the relevant account.
2025-11-21 09:38:35 +00:00
Jorge Manrubia 93ee8899a0 More robust implementation to prevent method injection attacks 2025-11-21 10:38:16 +01:00
Jorge Manrubia b0d732675c Extract partial 2025-11-21 10:32:32 +01:00
Jorge Manrubia e4558f00ab Merge branch 'main' into expand-activity-columns 2025-11-21 10:25:39 +01:00
Jorge Manrubia 7f76835150 Merge pull request #1668 from basecamp/pinned-stale
Several fixes for pinned cards
2025-11-21 10:03:32 +01:00
Jorge Manrubia 9d08f26c59 Disable turbo when navigating to another account
So that the turbo-permanent trays get properly replaced

https://app.fizzy.do/5986089/cards/3094
2025-11-21 09:54:16 +01:00
Jorge Manrubia 021831f810 Extract partials for the different sections 2025-11-21 09:48:00 +01:00
Jorge Manrubia 85b9e3dfd4 Make the notifications tray reload on broadcasted refreshes
We can't use the normal refresh: :morph because everything is contained in a turbo permanent section
so that the trays persist across regular navigation.
2025-11-21 09:41:03 +01:00
David Heinemeier Hansson ae640198ae Stick with the same general retention policy we use for everything 2025-11-21 09:40:50 +01:00
David Heinemeier Hansson 0a88565bd7 Slim down 2025-11-21 09:39:59 +01:00
David Heinemeier Hansson f66da318aa No longer needed now that we are back to a single DB 2025-11-21 09:39:33 +01:00
David Heinemeier Hansson 62d4998f27 We stopped using load_async in the code base 2025-11-21 09:35:25 +01:00
Jorge Manrubia e813b7eaf0 Invalidate HTTP caching when the cards change
https://app.fizzy.do/5986089/cards/3067
2025-11-21 09:32:02 +01:00
Jorge Manrubia 1211e180c2 Merge pull request #1667 from basecamp/prevent-lexxy-dup
Fix: duplicated lexxy when toggling done while in edit mode
2025-11-21 09:03:09 +01:00
Jorge Manrubia 649888dbd4 Making the frame permanent with an id would reconnect the editor causing the dup
This is something we need to fix in Lexxy for good, but for now this patch will do it.

https://github.com/basecamp/lexxy/issues/263
2025-11-21 08:52:10 +01:00
Jason Zimdars c9e2927179 Merge pull request #1666 from basecamp/identify-account-in-notificaton-bundle
Show account if you have multiple
2025-11-20 22:05:33 -06:00
Jason Zimdars 9bae30f771 Show account if you have multiple
It's hard to know which account email notifications are coming from
2025-11-20 22:03:54 -06:00
Jason Zimdars 93375f59cd Merge pull request #1665 from basecamp/magic-link-in-subject
Display code right in the subject line
2025-11-20 21:52:12 -06:00
Jason Zimdars dca002bd64 Update test 2025-11-20 21:51:07 -06:00
Jason Zimdars b1762ea6b6 Display code right in the subject line 2025-11-20 21:45:26 -06:00
Jason Zimdars 5e18d79999 Merge pull request #1661 from basecamp/revert-1660-revert-1659-notifications-copy
Add more detail to events summaries
2025-11-20 21:41:09 -06:00
Jason Zimdars ad7eb594d3 Match copy coming in #1663 2025-11-20 21:31:40 -06:00