Commit Graph

6388 Commits

Author SHA1 Message Date
Jason Zimdars 38ead57f4e Just put the hotkey on the button
No need to over explain the keyboard navigation, anyone who cares about
this will figure it out
2025-11-03 16:55:24 -06:00
Mike Dalessio 58468932b3 Merge pull request #1473 from basecamp/flavorjones/retcon-embed-migration
Make old migration that depends on the sqlite vec0 module a no-op
2025-11-03 17:43:48 -05:00
Jason Zimdars bef9d62cd4 Merge pull request #1474 from basecamp/boxcar-fizzy
Rename 'BOXCAR' to 'Fizzy'
2025-11-03 16:34:30 -06:00
Jason Zimdars 7d154b682e Rename 'BOXCAR' to 'Fizzy'
Missed files
2025-11-03 16:30:44 -06:00
Mike Dalessio 605955fdaf Make old migration that depends on the sqlite vec0 module a no-op
Once the sqlite 'vec0' module was removed from the codebase in
38a7a144 (following the table removal in 875a298f), this migration
became unrunnable. So to make sure we can reconstruct the schema if
necessary by running all the migrations, I'm replacing it with the
creation of an empty table.
2025-11-03 17:29:25 -05:00
Mike Dalessio 326dfe524b Merge pull request #1465 from basecamp/flavorjones/fix-smoke-test
test: Fix the flaky smoke test on attachments
2025-11-03 15:13:54 -05:00
Mike Dalessio e682f2742d test: Fix the flaky smoke test on attachments 2025-11-03 15:12:39 -05:00
Mike Dalessio b87e37e4da Merge pull request #1464 from basecamp/flavorjones/fixup-client-ip-main
Copy Cloudflare's True-Client-IP header to X-Forwarded-For
2025-11-03 14:23:55 -05:00
Mike Dalessio 8538c21d4e Copy Cloudflare's True-Client-IP header to X-Forwarded-For
ref: https://3.basecamp.com/2914079/buckets/37331921/todos/9243121525
2025-11-03 14:22:33 -05:00
Jason Zimdars b677273ef7 Merge pull request #1462 from basecamp/hide-closure-not-now
This shouldn't be visible when the card is already postponed
2025-11-03 11:51:59 -06:00
Jason Zimdars 886e38547e This shouldn't be visible when the card is already postponed
Fixes: https://app.box-car.com/5986089/cards/128
2025-11-03 11:50:36 -06:00
Jason Zimdars e0c6e4537f Merge pull request #1460 from basecamp/events-limit-notice
Move notice to bottom of column, tweak copy
2025-11-03 11:14:28 -06:00
Jason Zimdars 434d819585 Move notice to bottom of column, tweak copy 2025-11-03 11:07:12 -06:00
David Heinemeier Hansson f3c602da21 Use etag for collections/edit 2025-11-03 17:28:16 +01:00
David Heinemeier Hansson 56e4cdabd6 Use etag for taggings/new 2025-11-03 17:24:59 +01:00
David Heinemeier Hansson 3bc35ac559 Style 2025-11-03 17:24:04 +01:00
David Heinemeier Hansson 887559d1a3 Be consistent about using turbo stream templates 2025-11-03 17:23:37 +01:00
David Heinemeier Hansson 6570f5fc04 Use etag for assignments/new 2025-11-03 17:22:38 +01:00
David Heinemeier Hansson d3cb3a3a2d Use etags for my pins 2025-11-03 17:17:45 +01:00
Jorge Manrubia ea7f5d0130 Merge pull request #1459 from basecamp/remove-user-check
This is not cache-friendly
2025-11-03 17:07:40 +01:00
Jorge Manrubia 65c98a5d65 This is not cache-friendly
https://chat.37signals.com/rooms/440/@45201
2025-11-03 17:06:59 +01:00
David Heinemeier Hansson 1d00a53400 Provide etag for pins too 2025-11-03 16:53:49 +01:00
David Heinemeier Hansson 418548b9ba More efficient query for watched_by? and use etag for the status 2025-11-03 16:51:21 +01:00
David Heinemeier Hansson f5977522cb Use shared callback to set card 2025-11-03 16:51:21 +01:00
Jorge Manrubia f2d702fb54 Merge pull request #1457 from basecamp/assignee-update
A couple of fixes for updating cards:
2025-11-03 16:12:38 +01:00
Jorge Manrubia 24da4066b7 Refresh the full meta area so that the assignee name gets updated too 2025-11-03 16:11:53 +01:00
Jorge Manrubia 00818697ef Use page refreshes with morphing to avoid flickering
Replacing the card container will reload the frame. Also, see
https://github.com/basecamp/fizzy/commit/5b70320a6b64adf2d1e0be4bd7dc221a5ba80c95
2025-11-03 16:11:53 +01:00
David Heinemeier Hansson fcad4518da Split callbacks for easier overwriting 2025-11-03 16:00:35 +01:00
David Heinemeier Hansson 6678d0e4fc No longer used 2025-11-03 15:58:36 +01:00
David Heinemeier Hansson 65d04f681a DRY up the public controllers by introducing a shared base class 2025-11-03 15:56:25 +01:00
David Heinemeier Hansson 393e5fd3d4 Don't want to ship with this wart
cc @monorkin
2025-11-03 15:30:44 +01:00
David Heinemeier Hansson 42ebdf9ac1 More natural conditional 2025-11-03 15:29:20 +01:00
David Heinemeier Hansson 9913853cc6 Remove anemic concern 2025-11-03 15:27:12 +01:00
David Heinemeier Hansson 3116cea6a1 Stick with turbo stream templates for everything 2025-11-03 15:18:04 +01:00
David Heinemeier Hansson 3ed5c53b31 Use existing CollectionScoped
It enforces access restrictions on collections too
2025-11-03 15:12:38 +01:00
David Heinemeier Hansson 8d28c25a7b Unnecessary 2025-11-03 15:06:41 +01:00
David Heinemeier Hansson ed9259fa1a Ivar not used 2025-11-03 15:04:03 +01:00
David Heinemeier Hansson 995dcfe8e6 Simplify setup and pull query-prevention into model 2025-11-03 15:00:15 +01:00
David Heinemeier Hansson 2bf95f5b9a Just stick to default 2025-11-03 14:49:01 +01:00
Jorge Manrubia 7f7ecdaf28 Merge pull request #1456 from basecamp/only-show-draft-banner
Only show draft banner when the draft has some previous title/content set
2025-11-03 14:48:51 +01:00
David Heinemeier Hansson e081ce5e76 Consistently use symbols for module scopes 2025-11-03 14:47:48 +01:00
Jorge Manrubia 42a8b52fa1 Don´t show draft banner if the card is not filled 2025-11-03 14:47:29 +01:00
Jorge Manrubia ebf8490c2b Use Turbo.fetch to prevent page refreshes bounces when using rails/requests 2025-11-03 14:46:22 +01:00
David Heinemeier Hansson ecd0d319cc Style 2025-11-03 14:44:46 +01:00
David Heinemeier Hansson ed6745e163 Style 2025-11-03 14:42:21 +01:00
Jorge Manrubia 111d4900ef Only show draft banner if the card had some data 2025-11-03 14:41:27 +01:00
David Heinemeier Hansson 6336a47732 Style 2025-11-03 14:40:42 +01:00
David Heinemeier Hansson b2603187a9 Style 2025-11-03 14:40:12 +01:00
David Heinemeier Hansson 113003afa9 Stlye 2025-11-03 14:40:12 +01:00
David Heinemeier Hansson f8b5a64e9c Already included in the layout now 2025-11-03 14:40:12 +01:00