Jorge Manrubia
3e5c811bea
Format and rename method
2025-05-07 11:37:47 +02:00
Jorge Manrubia
561e9fad0c
Support selecting multiple cards by using a list of numbers (separated by comma, or space)
...
https://3.basecamp.com/2914079/buckets/37331921/todos/8620236700#__recording_8620273944
2025-05-07 11:30:58 +02:00
Jorge Manrubia
dc28f4c9c5
Add command to close cards
...
https://3.basecamp.com/2914079/buckets/37331921/todos/8620236700
2025-05-07 11:00:22 +02:00
Jorge Manrubia
8697cabbe2
Show confirmation when submitting certain commands
...
https://3.basecamp.com/2914079/buckets/37331921/todos/8617430347
2025-05-07 10:20:32 +02:00
Jorge Manrubia
22c3c33c0b
Merge pull request #460 from basecamp/fizzy-do-initial
...
Fizzy Do (initial)
2025-05-07 08:57:37 +02:00
Jorge Manrubia
26614c5f02
Fix test
2025-05-07 08:56:32 +02:00
Jorge Manrubia
6f382b68e0
Rename command controller => terminal controller and name the error class after terminal
2025-05-07 08:53:25 +02:00
Jorge Manrubia
55ea460d3e
Handle form errors with a stimulus class
...
We need to keep the focus in place when submitting the form. We are using a data-turbo-permanent for that. We were rendering the error form with a turbo stream. The problem was that turbo streams ignore permanent elements as per this https://github.com/hotwired/turbo/pull/688 , so the system wasn't updating the input field as expected.
Handling this as the stimulus level will also help with managing additional error states (such as the one we need for confirmations).
2025-05-07 08:46:47 +02:00
Jason Zimdars
34319ef053
Style
2025-05-06 18:07:00 -05:00
Jason Zimdars
6cb1762588
Update colors and adjust outline
2025-05-06 18:01:06 -05:00
Jason Zimdars
6695eac38e
Unused
2025-05-06 17:53:20 -05:00
Jason Zimdars
94e2ab25f9
Make command a button
2025-05-06 17:45:05 -05:00
Jason Zimdars
10890df97f
Style undo button
2025-05-06 17:32:45 -05:00
Jason Zimdars
521351da16
Add a keyboard shortcut
2025-05-06 16:15:19 -05:00
Jorge Manrubia
cc039e0831
Add missing index to commands
2025-05-06 22:51:38 +02:00
Jason Zimdars
eb986f2a5a
Merge branch 'main' into default-collection
...
* main:
Need a user for this
We can't rely on count now so test that the specific collection no longer exists
Accounts always start with a "Cards" collection
Need to name the assignee(s)
Adjust for svg icons
Display obvious chip when filtering by stage
Need to name the assignee(s)
Adjust for svg icons
Display obvious chip when filtering by stage
Use black for completed card color
2025-05-06 15:48:35 -05:00
Jason Zimdars
6f70b8f3b1
Merge branch 'jz-5-6'
...
* jz-5-6:
Need to name the assignee(s)
Adjust for svg icons
Display obvious chip when filtering by stage
2025-05-06 15:46:31 -05:00
Jason Zimdars
5b929619b4
Need a user for this
2025-05-06 15:45:28 -05:00
Jason Zimdars
40dbd51ab1
We can't rely on count now so test that the specific collection no longer exists
2025-05-06 15:45:28 -05:00
Jason Zimdars
16a174d87f
Accounts always start with a "Cards" collection
...
- Deleting the last collection, immediately creates a new "Cards" collection
2025-05-06 15:45:28 -05:00
Jason Zimdars
c2a563c699
Need to name the assignee(s)
2025-05-06 15:45:28 -05:00
Jason Zimdars
d8c2591296
Adjust for svg icons
2025-05-06 15:45:28 -05:00
Jason Zimdars
36fb154ee1
Display obvious chip when filtering by stage
2025-05-06 15:45:28 -05:00
Jason Zimdars
7e8c45a0a5
Need to name the assignee(s)
2025-05-06 15:39:55 -05:00
Jason Zimdars
b80969151e
Adjust for svg icons
2025-05-06 15:33:17 -05:00
Jason Zimdars
018f22a037
Display obvious chip when filtering by stage
2025-05-06 13:58:28 -05:00
Andy Smith
54fff3bd2d
Merge pull request #461 from basecamp/color-completed-cards
...
Use black for completed card color
2025-05-06 13:37:43 -05:00
Andy Smith
d0c2212734
Use black for completed card color
2025-05-06 13:36:40 -05:00
Jason Zimdars
ec4be7353b
Need a user for this
2025-05-06 12:28:33 -05:00
Jason Zimdars
2d22bef203
We can't rely on count now so test that the specific collection no longer exists
2025-05-06 12:27:02 -05:00
Jason Zimdars
28e7b9f59b
Merge branch 'main' into default-collection
...
* main:
Separate default from selectable workflow colors
Brighter card colors
Add transition
Larger click area for the clear notification button
Remove empty line
Use variables for card colors
Subtle fading and overlapping grid lines
Toggle should more closely resemble columns
Add `No.` and tighten-up line
Display card id
Don't count the system user
Handle the case where you can only see one collection
2025-05-06 12:18:24 -05:00
Andy Smith
ca2669c56f
Merge pull request #455 from basecamp/card-colors
...
Use variables for card colors
2025-05-06 11:59:41 -05:00
Andy Smith
f1daa647fe
Separate default from selectable workflow colors
2025-05-06 11:54:40 -05:00
Andy Smith
9328cc89e8
Brighter card colors
2025-05-06 11:36:12 -05:00
Andy Smith
4d1557496b
Merge pull request #456 from basecamp/notification-close-button
...
Larger click area for the clear notification button
2025-05-06 10:44:46 -05:00
Jorge Manrubia
1faaed4a16
Prefer ul
2025-05-06 16:06:47 +02:00
Jorge Manrubia
c1dfdfaed4
Fix test
2025-05-06 15:23:31 +02:00
Jorge Manrubia
804a80dde6
Format
2025-05-06 15:18:41 +02:00
Jorge Manrubia
37bf992d67
Add controller tests for undo
2025-05-06 15:17:57 +02:00
Jorge Manrubia
e8adf15ba7
Add controller tests
2025-05-06 15:07:02 +02:00
Jorge Manrubia
6961f36a45
Add tests for assignment
2025-05-06 14:57:51 +02:00
Jorge Manrubia
863ced55c4
Add tests
2025-05-06 14:17:28 +02:00
Jorge Manrubia
279a5be717
Rename single-letter param
2025-05-06 12:28:18 +02:00
Jorge Manrubia
01802964c5
Fix: consider "id" param too
2025-05-06 12:17:06 +02:00
Jorge Manrubia
a8d4cbcff0
Keep focus in place when navigating and morphing
2025-05-06 12:14:04 +02:00
Jorge Manrubia
af3ecb3772
Add missing validation
2025-05-06 11:50:18 +02:00
Jorge Manrubia
ef80c33be2
Move attribute declaration up
2025-05-06 11:47:30 +02:00
Jorge Manrubia
ee917f99d6
Override search params instead of accumulating them
2025-05-06 11:45:12 +02:00
Jorge Manrubia
ca3a8a444f
Fix: filtering combined with search
2025-05-06 11:40:57 +02:00
Jorge Manrubia
d7164356f1
Format
2025-05-06 11:20:04 +02:00