Commit Graph

892 Commits

Author SHA1 Message Date
Jason Zimdars 3e7fbbd401 Tighten labels 2025-01-24 14:26:24 -06:00
Jason Zimdars 62ef5d90a6 Match notification dot 2025-01-24 14:18:38 -06:00
Jason Zimdars 3c66f1ade7 Spacing 2025-01-24 14:15:54 -06:00
Jason Zimdars 40f3925712 Add more context 2025-01-24 14:09:59 -06:00
Jason Zimdars 823602bcee Avoid leaving the tray open 2025-01-24 13:56:03 -06:00
Jason Zimdars c068fac93f Merge branch 'notification-index'
* notification-index:
  This shouldn't be here
  Paginate the read notifications
  Send beacon request on disconnect as well
  Wire up notifications "Mark all as read" button
  Add unread dot
  Set state for when there are no new notifications
  Move to right side, smooth transition
  Open tray on click, stub mark-as-read button
  Refactor
  `New for you` empty state
  Add a notifications button to the tray for reaching the index when you have no unreads
  Needed when truncating so the avatar isn't squished
  Style notifications index; add truncation for long notifications
  Add an index view for all notifications
  Move notifications to tray controller
2025-01-24 13:41:59 -06:00
Jason Zimdars 57a1e4d621 This shouldn't be here 2025-01-24 13:29:48 -06:00
Kevin McConnell 1f3bc1134f Paginate the read notifications 2025-01-24 17:42:36 +00:00
Kevin McConnell 5895d55394 Merge pull request #218 from basecamp/stage-filter
Filtering by workflow stage
2025-01-24 11:11:21 +00:00
Kevin McConnell 2370bd0053 Add a test case 2025-01-24 10:43:46 +00:00
Kevin McConnell bd6e0b62b1 Split up a big view 2025-01-24 10:36:33 +00:00
Kevin McConnell 85d5f7d7d7 Allow filtering by stage 2025-01-24 10:28:12 +00:00
Kevin McConnell 42fa37d347 Send beacon request on disconnect as well
This is so we can dismiss any notifications that arrived for a bubble
while we were viewing that bubble. Otherwise, they'll stick around until
we leave the page and come back.
2025-01-21 14:47:56 +00:00
Kevin McConnell 5d5dc8fb73 Wire up notifications "Mark all as read" button 2025-01-21 14:37:41 +00:00
Jason Zimdars 404c420a58 Add unread dot 2025-01-20 18:20:58 -06:00
Jason Zimdars 02573b6dc8 Set state for when there are no new notifications 2025-01-20 17:58:56 -06:00
Jason Zimdars 69e235b082 Move to right side, smooth transition 2025-01-20 15:32:34 -06:00
Jason Zimdars 56c4bfc04c Merge branch 'main' into notification-index
* main:
  Don't round up in time distance expression
  Tidy Gemfile
  Banner for draft state
  Drafts should always use the dashed outline wherever they're displayed
  Unnecessary parens
  Use distance to nearest edge
  Simplify overlap logic
  Fix divider drag jankiness
2025-01-20 13:01:41 -06:00
Jason Zimdars 536dfa65d7 Open tray on click, stub mark-as-read button 2025-01-20 13:00:56 -06:00
Jason Zimdars cd22046efe Refactor 2025-01-19 22:27:02 -06:00
Jason Zimdars 00e905dd28 New for you empty state 2025-01-17 15:37:43 -06:00
Jason Zimdars 6b832876a2 Add a notifications button to the tray for reaching the index when you have no unreads 2025-01-17 15:30:33 -06:00
Jason Zimdars be14a910ba Needed when truncating so the avatar isn't squished 2025-01-17 13:06:41 -06:00
Jason Zimdars cb6651e2a7 Style notifications index; add truncation for long notifications 2025-01-17 12:42:46 -06:00
Kevin McConnell 181b7f3b64 Don't round up in time distance expression
e.g. 1.5 days ago is still "1 day ago", not "2 days ago".
2025-01-17 13:33:26 +00:00
Kevin McConnell 24f60aa71b Tidy Gemfile 2025-01-17 12:22:24 +00:00
Jason Zimdars 29b221f65c Banner for draft state 2025-01-16 19:21:27 -06:00
Jason Zimdars 340ff19a8c Drafts should always use the dashed outline wherever they're displayed 2025-01-16 19:14:58 -06:00
Jose Farias d65d8a899b Merge pull request #209 from basecamp/drag-jankiness
Fix divider drag jankiness
2025-01-16 15:13:05 -06:00
Jose Farias fb27cee9b0 Unnecessary parens 2025-01-16 15:11:44 -06:00
Jose Farias 8877d2e66d Use distance to nearest edge
This feels the smoothest
2025-01-16 15:09:46 -06:00
Jose Farias dc6da76b38 Simplify overlap logic 2025-01-16 14:01:25 -06:00
Jose Farias af0783d8ff Fix divider drag jankiness 2025-01-16 13:54:42 -06:00
Kevin McConnell 6706802b89 Add an index view for all notifications 2025-01-16 17:48:38 +00:00
Kevin McConnell c4f50fa634 Move notifications to tray controller 2025-01-16 17:48:38 +00:00
Kevin McConnell 6f8c929898 Use cache-friendly "time ago"
Also introduces a local time helper that we can use to format dates and
times.
2025-01-16 17:47:25 +00:00
Jose Farias 26f714189b Merge pull request #207 from basecamp/drag-divider
Drag bubble divider
2025-01-15 20:59:43 -06:00
Jose Farias 622e340e83 positionedClass -> installedClass 2025-01-15 20:31:09 -06:00
Jose Farias 775e29fb8e Pull out moveDividerTo 2025-01-15 20:26:56 -06:00
Jose Farias 40085b16d6 Before comes before After 2025-01-15 20:14:30 -06:00
Jose Farias 3ab6ee84d0 DividerElement -> Divider 2025-01-15 20:13:18 -06:00
Jose Farias 9b1c140eef Clean up divider-controller 2025-01-15 20:10:54 -06:00
Jose Farias dac9aa9d26 Drag bubble divider 2025-01-15 17:22:25 -06:00
Jose Farias e6e7cb2f72 Merge pull request #188 from basecamp/dependabot/bundler/hotwire_combobox-c280da0
Bump hotwire_combobox from `57ee6c9` to `c280da0`
2025-01-15 17:03:36 -06:00
Jose Farias 07ee06ddbd Merge pull request #205 from basecamp/simplify-filters
Simplify filters
2025-01-15 17:03:17 -06:00
Jose Farias 5ac9063a84 default_fields -> default_values 2025-01-15 16:57:02 -06:00
Jose Farias 4441dc7cd8 Test passing params in different order 2025-01-15 16:55:57 -06:00
Jose Farias 8d75429431 Remove old digest_params method 2025-01-15 16:45:15 -06:00
Jose Farias 19874dcc2a Test creating an equivalent filter with a different user 2025-01-15 16:41:25 -06:00
Jose Farias e9a085f848 Simplify filters 2025-01-15 16:27:33 -06:00