Jason Zimdars
3e7fbbd401
Tighten labels
2025-01-24 14:26:24 -06:00
Jason Zimdars
62ef5d90a6
Match notification dot
2025-01-24 14:18:38 -06:00
Jason Zimdars
3c66f1ade7
Spacing
2025-01-24 14:15:54 -06:00
Jason Zimdars
40f3925712
Add more context
2025-01-24 14:09:59 -06:00
Jason Zimdars
823602bcee
Avoid leaving the tray open
2025-01-24 13:56:03 -06:00
Jason Zimdars
c068fac93f
Merge branch 'notification-index'
...
* notification-index:
This shouldn't be here
Paginate the read notifications
Send beacon request on disconnect as well
Wire up notifications "Mark all as read" button
Add unread dot
Set state for when there are no new notifications
Move to right side, smooth transition
Open tray on click, stub mark-as-read button
Refactor
`New for you` empty state
Add a notifications button to the tray for reaching the index when you have no unreads
Needed when truncating so the avatar isn't squished
Style notifications index; add truncation for long notifications
Add an index view for all notifications
Move notifications to tray controller
2025-01-24 13:41:59 -06:00
Jason Zimdars
57a1e4d621
This shouldn't be here
2025-01-24 13:29:48 -06:00
Kevin McConnell
1f3bc1134f
Paginate the read notifications
2025-01-24 17:42:36 +00:00
Kevin McConnell
bd6e0b62b1
Split up a big view
2025-01-24 10:36:33 +00:00
Kevin McConnell
85d5f7d7d7
Allow filtering by stage
2025-01-24 10:28:12 +00:00
Kevin McConnell
5d5dc8fb73
Wire up notifications "Mark all as read" button
2025-01-21 14:37:41 +00:00
Jason Zimdars
404c420a58
Add unread dot
2025-01-20 18:20:58 -06:00
Jason Zimdars
02573b6dc8
Set state for when there are no new notifications
2025-01-20 17:58:56 -06:00
Jason Zimdars
69e235b082
Move to right side, smooth transition
2025-01-20 15:32:34 -06:00
Jason Zimdars
56c4bfc04c
Merge branch 'main' into notification-index
...
* main:
Don't round up in time distance expression
Tidy Gemfile
Banner for draft state
Drafts should always use the dashed outline wherever they're displayed
Unnecessary parens
Use distance to nearest edge
Simplify overlap logic
Fix divider drag jankiness
2025-01-20 13:01:41 -06:00
Jason Zimdars
536dfa65d7
Open tray on click, stub mark-as-read button
2025-01-20 13:00:56 -06:00
Jason Zimdars
00e905dd28
New for you empty state
2025-01-17 15:37:43 -06:00
Jason Zimdars
6b832876a2
Add a notifications button to the tray for reaching the index when you have no unreads
2025-01-17 15:30:33 -06:00
Jason Zimdars
be14a910ba
Needed when truncating so the avatar isn't squished
2025-01-17 13:06:41 -06:00
Jason Zimdars
cb6651e2a7
Style notifications index; add truncation for long notifications
2025-01-17 12:42:46 -06:00
Jason Zimdars
29b221f65c
Banner for draft state
2025-01-16 19:21:27 -06:00
Jason Zimdars
340ff19a8c
Drafts should always use the dashed outline wherever they're displayed
2025-01-16 19:14:58 -06:00
Jose Farias
d65d8a899b
Merge pull request #209 from basecamp/drag-jankiness
...
Fix divider drag jankiness
2025-01-16 15:13:05 -06:00
Jose Farias
af0783d8ff
Fix divider drag jankiness
2025-01-16 13:54:42 -06:00
Kevin McConnell
6706802b89
Add an index view for all notifications
2025-01-16 17:48:38 +00:00
Kevin McConnell
c4f50fa634
Move notifications to tray controller
2025-01-16 17:48:38 +00:00
Kevin McConnell
6f8c929898
Use cache-friendly "time ago"
...
Also introduces a local time helper that we can use to format dates and
times.
2025-01-16 17:47:25 +00:00
Jose Farias
622e340e83
positionedClass -> installedClass
2025-01-15 20:31:09 -06:00
Jose Farias
775e29fb8e
Pull out moveDividerTo
2025-01-15 20:26:56 -06:00
Jose Farias
9b1c140eef
Clean up divider-controller
2025-01-15 20:10:54 -06:00
Jose Farias
dac9aa9d26
Drag bubble divider
2025-01-15 17:22:25 -06:00
Jose Farias
e9a085f848
Simplify filters
2025-01-15 16:27:33 -06:00
Kevin McConnell
cd1e6378d0
Add drafted and published states
2025-01-15 10:58:00 +00:00
Kevin McConnell
f209c23e45
Cache notification partial
2025-01-15 10:57:27 +00:00
Jason Zimdars
e7819328e8
A little janky but we probably don't want to navigate when you're typing a comment
2025-01-14 17:00:32 -06:00
Jason Zimdars
6a40256969
Prevent back navigation when cancelling comment edits
2025-01-14 16:57:29 -06:00
Jason Zimdars
d20288f929
Don't trigger esc to go back when closing dialog
2025-01-14 16:53:38 -06:00
Jason Zimdars
1f911b234b
Avoid navigating back when closing the filter dialog
2025-01-14 16:49:21 -06:00
Jason Zimdars
a596d7cea7
Cancel and go back for forms with autofocused inputs
2025-01-14 16:45:29 -06:00
Jason Zimdars
39ff31b14b
esc to cancel here, too
2025-01-14 16:04:41 -06:00
Jason Zimdars
95f077672b
esc to navigate back to buckets index
2025-01-14 15:57:55 -06:00
Jason Zimdars
f7f063ae0c
Can just use @bucket
2025-01-14 15:49:25 -06:00
Jason Zimdars
32532c53cb
Add bucket link/title so you know where you are
2025-01-14 15:48:49 -06:00
Kevin McConnell
b8ecfa0125
Replace notifications on read, instead of removing
...
Previously when a notification was read, we'd remove it from the list.
This will often be fine, but if there were more unread notifications
that hadn't been loaded yet (because there were too many for the initial
page) then the list could become empty when really there are still more
items to show.
So instead of removing the items when they're read, we can reload the
list with the new page of items. This should allow the older
notifications to come into view when necessary.
2025-01-14 14:23:46 +00:00
Kevin McConnell
c11b5af5e0
Make Stimulus controller more generic
2025-01-14 13:37:54 +00:00
Kevin McConnell
ab154f2f35
Generate notification content in a helper
2025-01-14 13:08:12 +00:00
Kevin McConnell
30b58f716b
Make title a notifier attribute
2025-01-14 10:21:47 +00:00
Jason Zimdars
5f88cd3900
Design for notifications
2025-01-13 20:46:51 -06:00
Kevin McConnell
46989f6ebe
Mark notification read when viewing the Bubble
2025-01-13 14:21:47 +00:00
Kevin McConnell
febcb6c344
A partial is clearer than a helper here
2025-01-13 14:21:47 +00:00