Commit Graph

3592 Commits

Author SHA1 Message Date
Jason Zimdars 462878630e Use automatic sizing where supported 2025-07-02 16:42:27 -05:00
Jason Zimdars 16535db20e Add card_id to index 2025-07-02 16:23:37 -05:00
Jason Zimdars aff0a38b37 Move to scope and inline method 2025-07-02 16:14:25 -05:00
Jason Zimdars 27aaa815c7 Prefer modern syntax 2025-07-02 16:12:37 -05:00
Jason Zimdars 25a33fb9c8 Merge branch 'main' into card-steps
* main: (22 commits)
  Fix that stage should be visible above card background
  Indicate opens menu
  Hide dialog targets from screen readers when closed
  Mark up as heading for screen reader navigation
  Copy for screen readers
  Don't hide the input so it's accessible to screen readers
  Point skip links to correct anchor, don't navigate with turbo
  There aren't any `li` children so just use `div`
  Use headings for screen reader navigation
  Use `h3` for individual cards in collection view
  Make collection title `h1` for screen reader navigation
  Esc should not propagate when closing dialogs
  squash! Remove session controller actions other than delete
  Screen reader: Use heading for comments navigation
  Remove the invitation codes for now
  Remove session controller actions other than delete
  Correct label for field
  Style
  Screen reader: De-duplicate links for each person in account settings
  Account.signal_account is no longer optional
  ...
2025-07-02 16:09:49 -05:00
Jason Zimdars a31637bac7 Merge branch 'main' into accessibility-improvments
* main:
  squash! Remove session controller actions other than delete
  Remove the invitation codes for now
  Remove session controller actions other than delete
  Account.signal_account is no longer optional
  Remove local authentication code
  Drop the password column from the users table.
2025-07-02 16:07:29 -05:00
Jason Zimdars f623f6fea8 Fix that stage should be visible above card background 2025-07-02 16:06:22 -05:00
Jason Zimdars 41e40b5444 Indicate opens menu 2025-07-02 15:57:39 -05:00
Jason Zimdars 86e6309735 Hide dialog targets from screen readers when closed 2025-07-02 15:57:30 -05:00
Jason Zimdars b8f58dc70b Mark up as heading for screen reader navigation 2025-07-02 15:34:32 -05:00
Jason Zimdars 6b4c32ef9f Copy for screen readers 2025-07-02 15:34:17 -05:00
Jason Zimdars 10893b8fa2 Don't hide the input so it's accessible to screen readers 2025-07-02 15:02:37 -05:00
Jason Zimdars 6504813b4a Point skip links to correct anchor, don't navigate with turbo 2025-07-02 14:53:47 -05:00
Jason Zimdars 46093caeb8 There aren't any li children so just use div 2025-07-02 14:52:10 -05:00
Jason Zimdars c19e5a6253 Use headings for screen reader navigation 2025-07-02 14:46:43 -05:00
Jason Zimdars 70d6a7190f Use h3 for individual cards in collection view 2025-07-02 14:42:53 -05:00
Jason Zimdars db99e5928c Make collection title h1 for screen reader navigation 2025-07-02 14:38:29 -05:00
Jason Zimdars 985337a91c Esc should not propagate when closing dialogs 2025-07-02 14:29:15 -05:00
Mike Dalessio b99b80bc3d Merge pull request #690 from basecamp/flavorjones/cleanup-20250702
Cleanup after moving beta into a datacenter
2025-07-02 15:27:01 -04:00
Mike Dalessio 4537037a4c squash! Remove session controller actions other than delete 2025-07-02 15:23:59 -04:00
Jason Zimdars 91aa8be4fc Screen reader: Use heading for comments navigation 2025-07-02 14:22:16 -05:00
Mike Dalessio 7f1b384425 Remove the invitation codes for now
until I circle back for https://3.basecamp.com/2914079/buckets/37331921/todos/8746162337
2025-07-02 15:15:05 -04:00
Mike Dalessio fa1c5f7279 Remove session controller actions other than delete
and do some general cleanup around sessions controllers and the
sign_in_as test helper
2025-07-02 15:03:28 -04:00
Jason Zimdars 08043a7c5e Correct label for field 2025-07-02 14:01:10 -05:00
Jason Zimdars 5262e2812f Style 2025-07-02 13:58:50 -05:00
Jason Zimdars 79eada3e8d Screen reader: De-duplicate links for each person in account settings 2025-07-02 13:56:50 -05:00
Jason Zimdars f4218d9403 Merge branch 'main' into card-steps
* main:
  Script to create Users for existing 37id accounts
  Configure Mission Control to skip tenanted authentication
  Script to update URLs and attachments in cards and comments
  Make sure seeds are creating sluggable tenants
  Script to rename tenants after the QB account id
  Update the signups tests to work with untenanted paths
  Update the Command classes to handle paths with account slugs
  Update bin/dev to point at the new tenant URLs
  Patch Active Storage controllers to generate slugged URLs
  Point Action Cable at the slugged cable endpoint
  Extract pieces from the tenanting initializer
  Patch Turbo to use the request script name
  Use the new AR::Tenanted convention for action cable connections
  Use a tenant resolver that recognizes the account slug
  dep: Use the patched AR::Tenanted branch
2025-07-02 11:59:40 -05:00
Mike Dalessio c8be7418c1 Account.signal_account is no longer optional 2025-07-02 12:04:26 -04:00
Mike Dalessio da69bd1689 Remove local authentication code 2025-07-02 11:59:21 -04:00
Mike Dalessio 4fafeee4a9 Drop the password column from the users table. 2025-07-02 11:59:14 -04:00
Mike Dalessio 08db57644a Merge pull request #665 from basecamp/flavorjones/path-based-tenanting
Account slug tenanting
2025-07-02 10:52:18 -04:00
Jason Zimdars f02215c5b7 Add steps to cards 2025-07-01 20:05:20 -05:00
Mike Dalessio 84ed83a2c6 Script to create Users for existing 37id accounts
intended for staging
2025-07-01 17:41:54 -04:00
Mike Dalessio 7089fbe0d4 Configure Mission Control to skip tenanted authentication
In 29644ba1 we configured HTTP basic auth to secure it for now.
2025-07-01 15:56:14 -04:00
Mike Dalessio 8e666a5247 Script to update URLs and attachments in cards and comments 2025-07-01 15:56:14 -04:00
Mike Dalessio 9c59a85abd Make sure seeds are creating sluggable tenants 2025-07-01 15:56:14 -04:00
Mike Dalessio 444b7aa69f Script to rename tenants after the QB account id 2025-07-01 15:56:14 -04:00
Mike Dalessio f8cbf51f71 Update the signups tests to work with untenanted paths 2025-07-01 15:56:14 -04:00
Mike Dalessio b8368de002 Update the Command classes to handle paths with account slugs 2025-07-01 15:56:14 -04:00
Mike Dalessio 3d39bdc9f3 Update bin/dev to point at the new tenant URLs 2025-07-01 15:56:14 -04:00
Mike Dalessio 3844dc9ff3 Patch Active Storage controllers to generate slugged URLs
This really only impacts the Disk service in development.

I proposed this upstream in https://github.com/rails/rails/pull/55248,
but it's not clear if the presence of script_name should _always_
prefix generated URLs, so for now it's local to Fizzy.
2025-07-01 15:56:14 -04:00
Mike Dalessio 98e6bd8cd7 Point Action Cable at the slugged cable endpoint
I proposed this upstream in https://github.com/rails/rails/pull/55250,
but it's not clear if the presence of script_name should _always_
prefix generated URLs, so for now it's local to Fizzy.
2025-07-01 15:56:14 -04:00
Mike Dalessio e378c5a45e Extract pieces from the tenanting initializer
into:

- tenanting/account_slug
- tenanting/logging
- tenanting/turbo
2025-07-01 15:56:14 -04:00
Mike Dalessio e68e2eb971 Patch Turbo to use the request script name
so that the URLs generated during view rendering are correct
2025-07-01 15:56:14 -04:00
Mike Dalessio 33d5eccb70 Use the new AR::Tenanted convention for action cable connections 2025-07-01 15:56:14 -04:00
Mike Dalessio f43a5ff22c Use a tenant resolver that recognizes the account slug
and sets the script name accordingly
2025-07-01 15:56:14 -04:00
Mike Dalessio 6905198b66 dep: Use the patched AR::Tenanted branch 2025-07-01 15:56:14 -04:00
Mike Dalessio 5f31e6612b Merge pull request #685 from basecamp/flavorjones/fix-sqlite-backups
SQLiteBackupsJob explicitly uses db_config.database_path
2025-07-01 15:39:45 -04:00
Mike Dalessio fe8b71c2c9 SQLiteBackupsJob explicitly uses db_config.database_path
because using db_config.database will give us the sqlite file URL with
query params, and that's not what we mean.

This should restore nightly backups.
2025-07-01 15:32:13 -04:00
Jorge Manrubia 43ec523eaa Update action text lexical! 2025-07-01 09:58:33 +02:00