David Heinemeier Hansson
3003105ac9
Flesh out the rest of the controller tests
2025-04-18 16:16:04 +02:00
David Heinemeier Hansson
f6cd21f7cb
Extract default stages into something that will be created together with a new Workflow in the model
2025-04-18 16:07:01 +02:00
David Heinemeier Hansson
fd21838f88
Add assert_in_body helper
...
Coming upstream
2025-04-18 16:06:30 +02:00
Jason Zimdars
c61fa77d6b
Fix failing test (we're no longer redirecting here
...
See: #411
2025-04-17 17:03:18 -05:00
David Heinemeier Hansson
7adbd8d634
Use card rerendering instead of redirects
2025-04-17 15:20:27 +02:00
David Heinemeier Hansson
06da295f44
Fix tests
2025-04-17 14:56:53 +02:00
David Heinemeier Hansson
7b5a1c0232
Fix test
2025-04-17 14:32:26 +02:00
David Heinemeier Hansson
fc0cf3917f
Pin without redirect
...
Use turbo stream response to save on the redirect latency
2025-04-17 14:05:26 +02:00
David Heinemeier Hansson
a5de4863fa
Allow for multiple notifications to be read
...
cc @kevinmcconnell
2025-04-17 11:39:37 +02:00
David Heinemeier Hansson
91194d1b66
Fixed up controller test
2025-04-16 16:37:06 +02:00
David Heinemeier Hansson
50e4587dd9
Fix trailing spaces
2025-04-16 11:56:21 +02:00
David Heinemeier Hansson
375afeac7b
Fix test
2025-04-16 11:55:35 +02:00
David Heinemeier Hansson
73f272f132
Use one controller for all notification readings
2025-04-15 19:14:50 +02:00
David Heinemeier Hansson
93178636cd
Flesh out all the tests
2025-04-15 15:41:01 +02:00
David Heinemeier Hansson
2e8df45680
Flesh out tests for users controller
2025-04-15 15:36:11 +02:00
David Heinemeier Hansson
dbf61f4fc3
Use _path in all cases where we are not potentially changing the domain
2025-04-13 08:17:36 +02:00
David Heinemeier Hansson
a106b1b6a7
Join the two users controllers but split out role setting
2025-04-12 20:30:47 +02:00
David Heinemeier Hansson
6bbf68a4f9
The tenanted db is the account scope
2025-04-12 20:06:34 +02:00
David Heinemeier Hansson
760cbb6c99
Drop boosts
...
Killed by design.
2025-04-12 18:52:54 +02:00
David Heinemeier Hansson
7861b7c087
Just open one turbo stream per card
...
Per comment is excessive and needless
2025-04-11 17:58:11 +02:00
David Heinemeier Hansson
79700162fc
Use correct stream name
...
comment, :comments makes no sense for a stream for the reactions
2025-04-11 17:47:35 +02:00
David Heinemeier Hansson
f4ce57e308
Move comments under cards
2025-04-11 16:21:44 +02:00
Jorge Manrubia
4f3f322528
Rename inconsistency: go with goldness
2025-04-11 10:22:18 +02:00
Jorge Manrubia
1bac0b84b3
Add tests
2025-04-11 09:36:24 +02:00
Jorge Manrubia
c7b3b45977
Merge pull request #391 from basecamp/cards-pagination-2
...
Paginate collection cards
2025-04-10 15:10:54 +02:00
Jorge Manrubia
695247ae9b
Paginate collection cards
2025-04-10 15:09:56 +02:00
Jason Zimdars
aa7694ce7b
Update fixtures and test
2025-04-09 17:28:24 -05:00
Jorge Manrubia
723e6d94f5
Rename bubbles => cards
2025-04-09 14:50:58 +02:00
Kevin McConnell
9bbb59a166
Test for Bubbles::RecoversController
2025-04-07 14:30:05 +01:00
David Heinemeier Hansson
23892296da
Move readings under bubbles and out of double nesting
2025-04-07 14:06:56 +02:00
David Heinemeier Hansson
481be72162
Move bubbles publish out from the double nesting
2025-04-07 13:55:12 +02:00
David Heinemeier Hansson
ce0c6146be
Move bubble pops out from double nesting
2025-04-07 13:45:51 +02:00
Jorge Manrubia
e4f7837ebe
Remove double nesting under bubbles for engagement
2025-04-07 13:30:31 +02:00
David Heinemeier Hansson
c06802856e
Move boosts under bubbles
...
But also remove the need for a bucket nesting
2025-04-06 21:04:28 +02:00
David Heinemeier Hansson
4fd1472fae
Move bubble watch out from the needless bucket nesting
2025-04-06 19:22:40 +02:00
David Heinemeier Hansson
eb0614c44f
Use a more ergonomic API for watching
...
Passing a boolean vs using explicit on/off methods feel too low level
and doesnt read right in most of these cases.
2025-04-06 19:17:26 +02:00
David Heinemeier Hansson
a58fcd3123
Nicer API
2025-04-06 13:26:10 +02:00
David Heinemeier Hansson
cdd78b41ee
Tag exclusively by title
2025-04-06 13:19:22 +02:00
David Heinemeier Hansson
540316e639
Move taggings under bubbles
2025-04-05 21:54:48 +02:00
David Heinemeier Hansson
25b89ce8a9
Trailing CR
2025-04-05 17:18:18 +02:00
David Heinemeier Hansson
5134985418
Simplify the assignments flow
...
We now submit on every selection, so we dont need a whole form and
checkboxes to do it.
This needs some design tune-up after the change, though. cc @jzimdars
2025-04-05 17:14:57 +02:00
David Heinemeier Hansson
d0953d6f87
Pull assignments out of the double nesting
2025-04-05 15:59:51 +02:00
David Heinemeier Hansson
b4c0fec7a6
Move Assignments under Bubble
...
Since that what we are assigning
2025-04-05 15:51:53 +02:00
David Heinemeier Hansson
e69c1bd0a1
Break pins out of the double nesting
...
Its cumbersome and needless
2025-04-05 15:45:16 +02:00
David Heinemeier Hansson
866a80e133
Fix up the tests
2025-04-05 15:26:49 +02:00
David Heinemeier Hansson
bfb7ed1216
Move pins to my space
...
We used the my/ space in HEY to reflect anything that was primarily
hinged off Current.user. Good to use here too.
2025-04-05 14:57:24 +02:00
David Heinemeier Hansson
7494dad91e
Drop the toggles scope for taggings as well
2025-04-05 14:20:06 +02:00
David Heinemeier Hansson
384de24132
Get rid of odd toggles concept
...
This is just assignments.
2025-04-05 14:16:04 +02:00
Jorge Manrubia
f960b3fc83
Add tests
2025-04-04 13:35:54 +02:00
Jorge Manrubia
dbae700554
Merge pull request #346 from basecamp/two-columns-refactor
...
Refactor collections perma + support for doing/considering
2025-04-04 08:29:17 +02:00