Commit Graph

167 Commits

Author SHA1 Message Date
Andy Smith 20e27541be Truncate tags on cards 2025-08-14 13:55:20 -05:00
Andy Smith 8f86b25a54 Ensure card__link is visible on cards with backgrounds 2025-08-12 15:20:21 -05:00
Andy Smith 54ecd47c77 Use stage preview when previewing 2025-08-12 15:15:11 -05:00
Andy Smith 327f48bd4f Ensure avatars aren't tab-focusable when previewing 2025-08-12 15:12:48 -05:00
Andy Smith 19364af144 Merge pull request #870 from basecamp/tooltips
Tooltips
2025-08-12 11:49:08 -05:00
Andy Smith 267a5f11fa Stack meta info on mobile 2025-08-11 15:54:59 -05:00
Andy Smith 9224b76104 Workflow stages look better on mobile 2025-08-11 11:43:03 -05:00
Andy Smith a83b0a5e15 Assign tooltip 2025-08-07 15:38:47 -05:00
Andy Smith ffe88b824e Tooltip for Add a tag 2025-08-07 15:36:50 -05:00
Andy Smith 24617a8861 Add a couple more tooltips 2025-08-07 15:31:48 -05:00
Andy Smith d5a1c9824c Merge pull request #836 from basecamp/lightbox-improvements
Lightbox improvements
2025-08-05 09:59:37 -05:00
Andy Smith 38be44dd11 Move lightbox to cards/show so we can use it for description and Lexical images 2025-08-04 16:11:43 -05:00
Andy Smith 7d35ab11ec Add a remove image button inside the lightbox 2025-08-04 13:36:56 -05:00
Andy Smith 34f926ffca Support optional captions 2025-08-04 13:05:39 -05:00
Jason Zimdars 6227cf9a8b Keyboard arrow through pins and notifications 2025-07-30 16:07:55 -05:00
Jason Zimdars d3a01cf9bb Dialog target needs to be in the DOM on connect
Moves it out of the turbo frame so it's available even when empty
2025-07-24 14:58:52 -05:00
Andy Smith 67df61b57d Dry up utility classes for popup__group 2025-07-21 13:59:33 -05:00
Andy Smith 7e0df47c8f Same padding for all popup__items 2025-07-21 13:38:08 -05:00
Andy Smith 37cc6a6955 popup__items full-width by default 2025-07-21 13:37:33 -05:00
Andy Smith d3db752f39 Remove redundant flex-grow class from popup__items 2025-07-21 13:35:24 -05:00
Andy Smith 1e62ae8c94 Set min-width on popup__items 2025-07-21 13:32:56 -05:00
Jason Zimdars 70c2cc62a1 Merge branch 'main' into public-collection-cards
* main:
  Revert "Adjust borders"
  Don't allow wrapping initially
  Adjust borders
  Truncate long commands
  Try using env safe insets to avoid overlapping elements on mobile
  Correct asset width and remove caption input focus ring
  Revert "Make a focus-ring global variable"
  Make a focus-ring global variable
  Set `id` explicitly so the `label for` reference works
  Higher resolution image
  When adding a card out of context, default to most recently accessed collection
  Fine tuning to handle different attachment types
  Replace helper with view lookup
  Make nil safe
  Extract attachments to a partial
  Remove `card_published` check and render its own template
  Extract common concern to examine attachments
  This is a hack but we should be showing the card description and attachments for new cards
  Display attachments in events for comments
  Indicate cards with attachments in the description
2025-07-10 16:33:51 -05:00
Jorge Manrubia 81560c73dd Use existing direct route 2025-07-10 14:57:20 +02:00
Jason Zimdars 55f92e73f7 Not needed here 2025-07-09 11:08:09 -05:00
Jason Zimdars 4433e80691 Make steps non-interactive 2025-07-09 10:56:32 -05:00
Jason Zimdars 9ac5f46875 This shouldn't ever appear on the index, we have a preview partial 2025-07-09 10:44:53 -05:00
Jason Zimdars f1337048bd This shouldn't need to be here, it would never be displayed and does nothing 2025-07-09 10:42:03 -05:00
Jason Zimdars 8f7a373aad Public card templates 2025-07-09 10:16:39 -05:00
Jason Zimdars 485e575c40 Merge branch 'main' into card-attachments
* main: (45 commits)
  Display tag counts in the filter menu
  Move Add Card button to header
  Re-write help content, try a modal-like display
  Move to internal registry
  Show date instead of time for notifications older than 1 day
  Ensure checks are visible for tags and assignments
  Adjust padding so card number isn't cut off
  Don't color the collection header in considering
  Golden cards bubble to the top of Considering, too
  Adjust card collection header when colored golden
  Allow cards in Considering to gilded
  Hide focus ring on new card titles and step inputs
  Add hover effect for comment edit button
  Add hover effect to overflow button
  Improve multi-account behavior of the PWA
  Remove unneeded *
  Rename test
  Review the code to move cards
  Update editor
  Generalize and delete mentions too
  ...
2025-07-08 16:04:14 -05:00
Andy Smith 6e2eacd3d8 Hide focus ring on new card titles and step inputs 2025-07-07 13:23:19 -05:00
Andy Smith f9c7862fc1 Add hover effect for comment edit button 2025-07-07 10:12:32 -05:00
Jason Zimdars cf4c6dba9c Indicate cards with attachments in the description 2025-07-03 15:56:25 -05:00
Andy Smith 757ff4ff2b Merge branch 'main' into focus-hover-styles 2025-07-03 15:14:14 -05:00
Andy Smith 5c2997422f Address PR feedback 2025-07-03 15:00:12 -05:00
Jason Zimdars aff0a38b37 Move to scope and inline method 2025-07-02 16:14:25 -05:00
Jason Zimdars 25a33fb9c8 Merge branch 'main' into card-steps
* main: (22 commits)
  Fix that stage should be visible above card background
  Indicate opens menu
  Hide dialog targets from screen readers when closed
  Mark up as heading for screen reader navigation
  Copy for screen readers
  Don't hide the input so it's accessible to screen readers
  Point skip links to correct anchor, don't navigate with turbo
  There aren't any `li` children so just use `div`
  Use headings for screen reader navigation
  Use `h3` for individual cards in collection view
  Make collection title `h1` for screen reader navigation
  Esc should not propagate when closing dialogs
  squash! Remove session controller actions other than delete
  Screen reader: Use heading for comments navigation
  Remove the invitation codes for now
  Remove session controller actions other than delete
  Correct label for field
  Style
  Screen reader: De-duplicate links for each person in account settings
  Account.signal_account is no longer optional
  ...
2025-07-02 16:09:49 -05:00
Jason Zimdars 70d6a7190f Use h3 for individual cards in collection view 2025-07-02 14:42:53 -05:00
Jason Zimdars f02215c5b7 Add steps to cards 2025-07-01 20:05:20 -05:00
Jason Zimdars ffb422ac61 This attribute is no longer needed 2025-06-30 17:31:07 -05:00
Jason Zimdars 3af949edca Merge branch 'main' into filter-ignore-diacritics
* main:
  Clear the comments cache
  Add context for search screens
  Needs changed for both states
  Use lighter icon and update asset
  Add btn--circle class to user edit form
  Organize button variants
  Untangle `avatar btn` crossover styles
  Remove redundant classes and styles for avatars
  Adjust footer line height
  Tweak padding
2025-06-30 17:01:43 -05:00
Andy Smith be003cd3f7 Remove redundant classes and styles for avatars 2025-06-30 14:00:59 -05:00
Jason Zimdars 2678f8c099 Convert diacritics to approximations before filtering
- Introduces a helper method for setting the filterable value
- Updates `filter_controller.js` to use `data-filter-text-value` attribute populated with converted content. This was previous `data-value` in the earlier implementation but ignored in the current on.
- Also uses the same helper to make @mentions diacritic insensitive
2025-06-30 13:53:50 -05:00
Andy Smith c087ceee52 Properly close the span 2025-06-24 15:29:41 -05:00
Jason Zimdars c2b92fd4f5 DRY this up 2025-06-19 20:42:11 -05:00
Jason Zimdars c59a99fa68 Only display workflows when the card is in Doing 2025-06-19 13:35:20 -05:00
Jorge Manrubia 6907d07d07 Don't choke when a card is missing its stage
This can happen if the stage was destroyed
2025-06-19 08:25:48 +02:00
Jason Zimdars cc407f6198 Rework truncation so tag and collection menus display correctly 2025-06-17 16:26:54 -05:00
Jason Zimdars 975bbe2385 Render stage inline so it doesn't overlap collection name
Allows truncation of collection name to fit stage name
2025-06-17 15:11:21 -05:00
Jason Zimdars ba7cef801a Band aid for dialog inside overflow elements 2025-06-16 20:44:25 -05:00
Jason Zimdars 73b3442e96 Make cards resilient to long collection names 2025-06-16 19:53:55 -05:00