Commit Graph

7097 Commits

Author SHA1 Message Date
Kevin McConnell 4fc85883ee Don't open account links in new window
This allows switching account in-place inside the same PWA or browser
tab.
2025-11-20 09:36:18 +00:00
Kevin McConnell e37038c0a6 Merge pull request #1647 from basecamp/avoid-notification-deadlocks
Process notification recipients in consistent order
2025-11-20 09:27:57 +00:00
Kevin McConnell bc73cf692d Process notification recipients in consistent order
We've seen some cases of deadlock when processing notifications, because
locks are gathered on the users in different orders. Let's try sticking
to a consistent order instead, which should cause the jobs to serialize
rather than deadlock.
2025-11-20 09:20:48 +00:00
Mike Dalessio 19d8e41b38 Merge pull request #1646 from basecamp/flavorjones/improve-search-results
Improve search results
2025-11-19 18:09:18 -05:00
Mike Dalessio 99fe5ff934 Make sure that comments show up in search properly
when the search term appears in both the comment and the card description
2025-11-19 18:02:36 -05:00
Mike Dalessio 378705a30d Deduplicate filter results
when both a card and that card's comments match the search term, we
don't want to show it multiple times.

ref: https://app.fizzy.do/5986089/cards/3030
2025-11-19 17:51:38 -05:00
Jason Zimdars a500cbf43a Merge pull request #1645 from basecamp/jz-11-19-25
JZ 11-19-25
2025-11-19 16:47:59 -06:00
Jason Zimdars f35623b75f Capitalize 2025-11-19 16:47:02 -06:00
Jason Zimdars 67da7cba75 Update test 2025-11-19 16:46:09 -06:00
Mike Dalessio a5f5b592c2 test: remove redundant session setup 2025-11-19 17:43:40 -05:00
Jason Zimdars 25e2d98c35 Don't label these, they're expected and obvious (I think) 2025-11-19 16:26:55 -06:00
Jason Zimdars a15043a336 The symbol is hard to read, go back to text labels 2025-11-19 16:23:21 -06:00
Jason Zimdars 0259cb860d Fix awkward wrapping on mobile 2025-11-19 16:16:16 -06:00
Jason Zimdars 7e008864f2 Ensure back buttons collapse to icons on small screens 2025-11-19 16:04:21 -06:00
Mike Dalessio 6592a0e89a Merge pull request #1642 from basecamp/flavorjones/join-code-exhaustion
Display a helpful error message when join code is exhausted
2025-11-19 15:54:30 -05:00
Mike Dalessio c53b56c1db Display a helpful error message when join code is exhausted
ref: https://app.fizzy.do/5986089/cards/3015
2025-11-19 15:53:25 -05:00
Andy Smith 30a201f1ed Merge pull request #1636 from basecamp/mini-bubble-reposition
Don't show mini bubbles in Maybe column
2025-11-19 14:12:31 -06:00
Mike Dalessio 1382920e9b Merge pull request #1641 from basecamp/flavorjones/stats-dashboard-3
Small tweaks to dashboard
2025-11-19 14:37:11 -05:00
Mike Dalessio 775a339e3a Small tweaks to dashboard 2025-11-19 14:36:46 -05:00
Mike Dalessio 49ac5defed Merge pull request #1640 from basecamp/flavorjones/stats-dashboard-2
Small improvements to the stats dashboard
2025-11-19 14:31:44 -05:00
Mike Dalessio 2fe578c5e5 Small improvements to the stats dashboard 2025-11-19 14:31:13 -05:00
Mike Dalessio 1dd7672a8d Merge pull request #1637 from basecamp/flavorjones/admin-dashboard
Basic admin dashboard
2025-11-19 14:24:50 -05:00
Mike Dalessio 362be963c0 Add a very rudimentary admin dashboard. 2025-11-19 14:23:47 -05:00
Mike Dalessio 4636b31f06 Authorization ensure_staff uses identity.staff
for use on untenanted routes
2025-11-19 14:23:47 -05:00
Mike Dalessio 6de979daaa Merge pull request #1639 from basecamp/flavorjones/http-basic-auth
Restore http basic auth in prod
2025-11-19 14:16:56 -05:00
Mike Dalessio 47c05e6d6a Restore basic auth on signup
broken in 6e304958
2025-11-19 14:12:59 -05:00
Fernando Álvarez 672816dec5 Move production jobs to specific hosts 2025-11-19 19:12:02 +01:00
Andy Smith e0625070ed Don't show mini bubbles in Maybe column 2025-11-19 11:48:58 -06:00
Fernando Álvarez a6a4bb236b Split jobs hosts for Staging
Related to https://3.basecamp.com/2914079/buckets/37331921/todos/9266308208
2025-11-19 18:31:29 +01:00
Mike Dalessio 945505e147 Merge pull request #1635 from basecamp/flavorjones/fix-active-storage-account-slugs
Fix account slugs in Active Storage URLs
2025-11-19 09:01:52 -05:00
Mike Dalessio 711cc8568e Fix account slugs in Active Storage URLs 2025-11-19 08:51:12 -05:00
Mike Dalessio 977169c688 Merge pull request #1634 from basecamp/flavorjones/unscoped-pwa
Remove the account slug from the PWA manifest
2025-11-19 08:30:48 -05:00
Mike Dalessio 5a85466732 Remove the account slug from the PWA manifest
- linked in the `head` on all requests (previously just tenanted requests)
- `start_url` and `scope` are "/" (previously account slug)
2025-11-19 08:27:41 -05:00
Jorge Manrubia f6d1dee9b4 Merge pull request #1633 from basecamp/overlapping-records
Prevent creating overlapping records
2025-11-19 11:14:14 +01:00
Jorge Manrubia 63d08c5b13 Prevent creating overlapping records
https://3.basecamp.com/2914079/buckets/27/card_tables/cards/9275047474
2025-11-19 11:02:00 +01:00
David Heinemeier Hansson 66d397fa80 Eager load lazy frames inside dialogs on hover 2025-11-19 08:28:18 +01:00
Jason Zimdars 3faef80cae Merge pull request #1632 from basecamp/fix-navigable-jump-menu
Need to trigger navigable list after the menu contents load
2025-11-18 17:55:49 -06:00
Jason Zimdars 3d1b3e22a7 Need to trigger navigable list after the menu contents load
Fixed arrow navigation
2025-11-18 17:54:34 -06:00
Jason Zimdars 0bdc1f2b62 Merge pull request #1631 from basecamp/bring-back-current-account
Bring back current account
2025-11-18 17:30:22 -06:00
Jason Zimdars e9819000b6 We can simplify this now 2025-11-18 17:26:40 -06:00
Jason Zimdars 7d0bc3ddf6 Show the currently selected account in the menu
This is a regression. Showing the current account means you always see
the same items in this menu section as you move back and forth
2025-11-18 17:25:32 -06:00
Mike Dalessio e0a67be3fd Merge pull request #1625 from basecamp/flavorjones/clear-stall-status-more-easily
Stalled cards are unstalled by anything that touches updated_at
2025-11-18 17:48:38 -05:00
Mike Dalessio dbbee2c661 Stalled cards are unstalled by anything that touches updated_at
ref: https://app.fizzy.do/5986089/cards/2492
2025-11-18 17:46:56 -05:00
Mike Dalessio 9249199241 Merge pull request #1630 from basecamp/flavorjones/fix-postponed
Fix: Older cards do not have a postponed_by user
2025-11-18 16:56:01 -05:00
Mike Dalessio c2a5c81e21 Older cards do not have a postponed_by user 2025-11-18 15:46:29 -05:00
Kevin McConnell ed9be0674b Merge pull request #1558 from basecamp/plan-b
Fizzy on MySQL
2025-11-18 18:53:19 +00:00
Kevin McConnell b63ec319a2 Remove trailing newline (appease Rubocop) 2025-11-18 18:44:45 +00:00
Stanko K.R. 245c328570 Decode the filename form the URL 2025-11-18 19:39:32 +01:00
Stanko K.R. d574748432 Add script to fix active storage links 2025-11-18 19:24:04 +01:00
David Heinemeier Hansson 43d384961a Add users to the populater too 2025-11-18 17:59:15 +01:00