51341c36d1
New partial isnt cached
2025-04-11 18:45:44 +02:00
c8fe83e8f3
Indention
2025-04-11 18:43:52 +02:00
6effc1568f
No need for a separate body partial
2025-04-11 18:41:26 +02:00
6f1c802292
Content being required via UI and db constraint is enough
...
We are not using/displaying model validations anywhere
2025-04-11 18:28:23 +02:00
9ecb85013b
Spacing
2025-04-11 18:25:49 +02:00
442fe6087c
Use form object so we dont have to manually set the text_field name
2025-04-11 18:25:24 +02:00
aefae634c3
Anemic params method
...
Wont ever get reused here since there is no update
2025-04-11 18:21:44 +02:00
8d36f13fab
No longer needing that extra local
2025-04-11 18:20:28 +02:00
06a636bd8d
Did need to separate them out for the broadcast
2025-04-11 18:19:33 +02:00
5fa8007397
Loaded directly in the partial
2025-04-11 18:19:10 +02:00
f0aa48b75d
Indention
2025-04-11 18:13:29 +02:00
fadf167630
Avoid needing to pass an extra variable to the reactions partial
...
Thanks to inverse_of, there's no extra query getting the comment from
the reaction.
2025-04-11 18:12:52 +02:00
227d5a8757
It is both reacting and reactions
...
So stick with the simpler dom id scope
2025-04-11 18:10:26 +02:00
73f1989861
Fix indention
2025-04-11 18:05:50 +02:00
3b711161d7
No need for a manual dom_id
...
turbo_frame_tag can do this directly
2025-04-11 18:04:21 +02:00
1145260890
No idea why this was here
2025-04-11 18:01:21 +02:00
5aa2b7da84
No need to cache individual reactions
...
Both because the reactions partial actually depends on multiple
variables but also because its just not worth it when we are caching the
comment.
2025-04-11 17:58:48 +02:00
7861b7c087
Just open one turbo stream per card
...
Per comment is excessive and needless
2025-04-11 17:58:11 +02:00
263b3336db
Add missing CR
2025-04-11 17:50:53 +02:00
0954cfe008
Add CR
2025-04-11 17:48:01 +02:00
79700162fc
Use correct stream name
...
comment, :comments makes no sense for a stream for the reactions
2025-04-11 17:47:35 +02:00
eec76d0d4f
Use modern params#expect
2025-04-11 17:43:31 +02:00
f9bb779b61
Use local vars so ivar dependency is only from before actions
2025-04-11 17:42:30 +02:00
3ecf150636
Use proper access control
...
Otherwise you could react to any comment on the entire account. And then
you might as well just do Comment.find.
2025-04-11 17:41:28 +02:00
dc4e50fba5
Move messages partial under cards
2025-04-11 17:34:49 +02:00
5084bbf3b7
Use modern params#expect syntax
2025-04-11 17:01:19 +02:00
8a4a087a00
Fine to let destroying something destroyed be a no-op
...
Would be an edge-casey race condition, but its possible
2025-04-11 17:00:08 +02:00
256d536009
Always use _path unless we are changing domains
2025-04-11 16:58:56 +02:00
16c1583133
Usually the order comes last
2025-04-11 16:58:47 +02:00
5ecf0ce3f6
Stick with one term
2025-04-11 16:57:03 +02:00
a8aa2c4f80
Clean up the controller
2025-04-11 16:49:55 +02:00
f4ce57e308
Move comments under cards
2025-04-11 16:21:44 +02:00
64b529ce94
Fix indention
2025-04-11 16:12:18 +02:00
ba6eab509c
Refresh timers when morphing happens
2025-04-11 13:26:01 +02:00
825bbf808e
Extract helper for card articles, use classes to determine when to show golden status
2025-04-11 12:01:52 +02:00
aef75feead
Only consider golden those cards in "doing"
2025-04-11 11:49:52 +02:00
1275abd99e
Fix recently completed order for good!
2025-04-11 11:37:02 +02:00
66b5732264
Place recently closed cards first
2025-04-11 11:27:38 +02:00
17aa9b97e9
Monkey patch a prepend_order method
2025-04-11 10:28:12 +02:00
4f3f322528
Rename inconsistency: go with goldness
2025-04-11 10:22:18 +02:00
eae1669ac3
Touch
2025-04-11 10:20:30 +02:00
806609e77b
Use gild/ungild
2025-04-11 10:20:06 +02:00
b4297ab852
Format
2025-04-11 09:57:45 +02:00
492a42ba92
Not needed anymore
2025-04-11 09:57:45 +02:00
5360b4ccb4
Add comment
2025-04-11 09:57:45 +02:00
da7a30203c
Style golden cards
2025-04-10 17:14:04 -05:00
5560976091
Merge branch 'main' into gold-cards
...
* main:
Try a segmented toggle for engagement
Fix tests
Rework min card design and meta section for all cards
Move `title` to the `img` element so we get hover in both cases
Remove sorting filter UI
Sort Considering and Doing by `updated_at`
Restore comment action icon
Fix dot escaping container
Seen cards should be flat
Ensure overflow cards are hidden
Arrow needs to match derived color
Dialog target needs to be present
This isn't necessary in the mini card template
Revert "The button and dialog need not render in previews"
2025-04-10 16:42:45 -05:00
0c107c5894
Fix that cards which were Drafted or in Considering were also being displayed in Doing
...
CC: @jorgemanrubia
2025-04-10 16:42:40 -05:00
81ee2ab64d
Try a segmented toggle for engagement
2025-04-10 16:06:35 -05:00
e4110734eb
Rework min card design and meta section for all cards
2025-04-10 14:39:50 -05:00
David Heinemeier Hansson