Commit Graph

1328 Commits

Author SHA1 Message Date
Andy Smith 649b4801bb Use preview instead of mini cards 2025-04-10 11:45:50 -05:00
Andy Smith 5cb7643274 Merge branch 'main' into btn-dropdown
* main: (21 commits)
  Migration to migrate URLs after renaming bubbles => cards
  Remove migration
  Restore bubbles.css since some styles are used
  Fix issues with styling card__ components
  Remove bubbles.css
  Fix renames that the scripts missed
  Reorganize templates to remove cards/cards redundancy
  Rename bubbles => cards
  Safari sure loves outlines
  Use a number field, and improve focus styles
  Fix boosting via number input
  Embed additional video formats
  Fix that notifications weren't marked as read
  Fix tray item position
  Update House to bring patch for history restoration error
  Tighten up
  Restore additional missing routes removed in c0f3ff46d7
  Retore route removed in c0f3ff46d7
  Fix visual regression in popup menus
  Perma cards should not always be 100% width
  ...
2025-04-09 14:17:39 -05:00
Andy Smith 7b8ed815cd Address PR feedback 2025-04-09 14:09:08 -05:00
Jorge Manrubia aa14cd41ec Restore bubbles.css since some styles are used 2025-04-09 15:15:17 +02:00
Jorge Manrubia b035c8506e Fix issues with styling card__ components 2025-04-09 15:10:48 +02:00
Jorge Manrubia 61a476eaca Remove bubbles.css 2025-04-09 15:02:38 +02:00
Jorge Manrubia 221bbb3247 Fix renames that the scripts missed 2025-04-09 14:56:59 +02:00
Jorge Manrubia 6f00e1a79a Reorganize templates to remove cards/cards redundancy 2025-04-09 14:53:46 +02:00
Jorge Manrubia 723e6d94f5 Rename bubbles => cards 2025-04-09 14:50:58 +02:00
Jason Zimdars d100d93b2a Safari sure loves outlines 2025-04-08 16:22:38 -05:00
Jason Zimdars df408bfd03 Use a number field, and improve focus styles 2025-04-08 16:20:02 -05:00
Jason Zimdars f6288ca026 Fix boosting via number input
- Regression in c06802856e which moved text field outside of form element
2025-04-08 16:19:40 -05:00
Andy Smith 22ff4ee18c Cleanup, phew! 2025-04-08 16:17:05 -05:00
Andy Smith ab88f5549e Working with longer text 2025-04-08 16:09:53 -05:00
Andy Smith 9975ed96f4 WIP: Partially working 2025-04-08 16:01:45 -05:00
Jason Zimdars f58c6792e0 Fix that notifications weren't marked as read
- Move create template into `/bubbles`
- Looks like this file was missed when refactoring `readings` under `bubbles` in 23892296da
2025-04-08 15:50:01 -05:00
Andy Smith d6b985b8ef Basic, non-animated version 2025-04-08 14:23:45 -05:00
Andy Smith 1214527cf2 Fix tray item position 2025-04-08 10:59:51 -05:00
Andy Smith 1715e9a9ee WIP 2025-04-08 10:52:20 -05:00
Jason Zimdars 7a545f5afd Tighten up 2025-04-07 21:48:17 -05:00
Andy Smith 8bcd5394a3 Remove unused class and markup 2025-04-07 15:53:53 -05:00
Andy Smith 620c0b885a Position "close as" dialog 2025-04-07 15:49:36 -05:00
Jason Zimdars c3c4823c95 Fix visual regression in popup menus 2025-04-07 15:44:38 -05:00
Andy Smith d992ba7ede Perma cards should not always be 100% width 2025-04-07 15:01:06 -05:00
Andy Smith e9726c481a WIP 2025-04-07 14:50:24 -05:00
Andy Smith 922d80a7fa Correct merge goof 2025-04-07 14:20:11 -05:00
Andy Smith e8f85df720 Merge branch 'main' into cascade-layers-2
* main: (104 commits)
  Default collection permissions to "all access"
  dep: update active_record-tenanted to 8758240b
  dep: bump Rails to 32d96235
  Test for `Bubbles::RecoversController`
  Move readings under bubbles and out of double nesting
  Move bubble stagings out from double nesting
  Correct alpha ordering
  Fix indention
  Move bubble recovery out from double nesting
  Move bubbles publish out from the double nesting
  Move bubble pops out from double nesting
  Move controller to delete bubble image out from double nesting under bucket
  Revert "Scope searches by user"
  Scope searches by user
  Few more lazy loading avatars!
  Another lazy loading point
  Remove double nesting under bubbles for engagement
  Lets just preload all avatars for now
  No need for an array when there is only one dependency
  Scope data by account
  ...
2025-04-07 14:15:55 -05:00
Mike Dalessio d111fb50c3 Default collection permissions to "all access"
ref: https://37s.fizzy.37signals.com/buckets/693169853/bubbles/999008744
2025-04-07 12:48:43 -04:00
David Heinemeier Hansson 23892296da Move readings under bubbles and out of double nesting 2025-04-07 14:06:56 +02:00
David Heinemeier Hansson bcd6c6dd66 Move bubble stagings out from double nesting 2025-04-07 14:00:30 +02:00
David Heinemeier Hansson 28c106fd83 Fix indention 2025-04-07 13:58:41 +02:00
David Heinemeier Hansson 3b32b40264 Move bubble recovery out from double nesting 2025-04-07 13:57:00 +02:00
David Heinemeier Hansson 481be72162 Move bubbles publish out from the double nesting 2025-04-07 13:55:12 +02:00
David Heinemeier Hansson ce0c6146be Move bubble pops out from double nesting 2025-04-07 13:45:51 +02:00
David Heinemeier Hansson c60b86cbaa Move controller to delete bubble image out from double nesting under bucket 2025-04-07 13:43:51 +02:00
Jorge Manrubia 2106fb464a Revert "Scope searches by user"
This reverts commit 47552dd8d7.
2025-04-07 13:42:57 +02:00
Jorge Manrubia 47552dd8d7 Scope searches by user 2025-04-07 13:42:27 +02:00
Jorge Manrubia fea5463642 Merge pull request #372 from basecamp/scope-accesses
Scope data by account
2025-04-07 13:35:44 +02:00
Jorge Manrubia 93b9f08d58 Merge pull request #373 from basecamp/engagement-nesting
Remove nesting under "bucket" for engagements
2025-04-07 13:35:18 +02:00
David Heinemeier Hansson 86a360f6a0 Few more lazy loading avatars! 2025-04-07 13:32:10 +02:00
David Heinemeier Hansson 7e9b851f64 Another lazy loading point 2025-04-07 13:31:14 +02:00
Jorge Manrubia e4f7837ebe Remove double nesting under bubbles for engagement 2025-04-07 13:30:31 +02:00
David Heinemeier Hansson 8e0394a090 Lets just preload all avatars for now
They are small, they cache well, scrolling will be less jittery. Small
cost in bandwidth for that.
2025-04-07 13:29:59 +02:00
David Heinemeier Hansson 84c0ec8a35 No need for an array when there is only one dependency 2025-04-07 13:23:16 +02:00
Jorge Manrubia ca0526f9ac Merge pull request #370 from basecamp/back-fallback
Extract helper with fallback for the "go to back" and use consistently
2025-04-07 13:10:54 +02:00
Jorge Manrubia cb2b2f409a Merge pull request #368 from basecamp/avatar-cache
Remove max_age for your own avatar
2025-04-07 13:10:45 +02:00
Jorge Manrubia 9b4169c7ca Scope data by account
With a single database this problem is not as bad, but it feels
safer to do things right. Also, not everyone in an account has access
to all the bubbles.
2025-04-07 13:09:49 +02:00
Jorge Manrubia 67398926df Prefer aria-label 2025-04-07 12:54:37 +02:00
Jorge Manrubia 8d7d8e76f2 Avoid # since it confuses screen readers 2025-04-07 12:45:53 +02:00
Jorge Manrubia a7aae833d1 Extract helper with fallback for the "go to back" and use consistently 2025-04-07 11:28:03 +02:00