Commit Graph

2273 Commits

Author SHA1 Message Date
Jorge Manrubia 74a8a6431e Extract more templates 2025-04-25 10:21:38 +02:00
Jorge Manrubia 32c9cdbba8 Extract filter partials and rely on filter as the source of truth for the selected collections 2025-04-25 10:00:21 +02:00
Jorge Manrubia 6da814520d Remove todo I already tackled 2025-04-25 09:48:33 +02:00
Jorge Manrubia a445b5c068 Extract partial 2025-04-25 09:48:15 +02:00
Jorge Manrubia 54d7327ccd Merge branch 'main' into events-revamp
* main:
  Account for stages where the color isn't set
  Choose workflows from a small preview
  Add missing filter display classes, style input
  Scroll users list, adjust layout
  Workflows and card perma polish
  Type polish and sizing constraints
  dep: AR::Tenanted: no implicit db migrations
  New layout for collections settings, stub entropy setting
  Adjust collection line to contrast with comment excerpts
  Adjust perma layout for larger cards
  Give the timeline a little space on each side
2025-04-25 09:41:29 +02:00
Jorge Manrubia 6a1dcef6ef Add script to migrate existing events to the new format 2025-04-25 09:26:47 +02:00
Jorge Manrubia 4657663e35 Create local time formatter to match the previous format we were generating server-side 2025-04-25 08:55:36 +02:00
Jorge Manrubia 6fb0d88079 Tidy up 2025-04-25 08:22:21 +02:00
Jorge Manrubia 501a3b2b44 Add test to make sure you can't access innaccessible collections via filtering either 2025-04-25 07:23:11 +02:00
Jorge Manrubia 55059e968b Fix collection filtering persistence via cookies 2025-04-25 07:22:54 +02:00
Jason Zimdars ae90ddac07 Account for stages where the color isn't set 2025-04-24 17:46:56 -05:00
Jason Zimdars b44116f12f Merge branch 'morning-apr-24'
* morning-apr-24:
  Choose workflows from a small preview
  Add missing filter display classes, style input
  Scroll users list, adjust layout
  Workflows and card perma polish
  Type polish and sizing constraints
  New layout for collections settings, stub entropy setting
  Adjust collection line to contrast with comment excerpts
  Adjust perma layout for larger cards
  Give the timeline a little space on each side
2025-04-24 17:37:18 -05:00
Jason Zimdars 2cecbcd77c Choose workflows from a small preview 2025-04-24 17:36:48 -05:00
Jason Zimdars 77b79de02f Add missing filter display classes, style input 2025-04-24 17:03:50 -05:00
Jason Zimdars 783e7d12a1 Scroll users list, adjust layout 2025-04-24 16:59:48 -05:00
Jason Zimdars ed8cc29e59 Workflows and card perma polish 2025-04-24 16:36:26 -05:00
Jason Zimdars 5c2d12177a Type polish and sizing constraints 2025-04-24 16:00:12 -05:00
Mike Dalessio 6aef89a08a Merge pull request #433 from basecamp/flavorjones/dep-artenanted-no-implicit-migrations
dep: AR::Tenanted: no implicit db migrations
2025-04-24 15:16:37 -04:00
Mike Dalessio 579c76f58a dep: AR::Tenanted: no implicit db migrations
ref: https://github.com/basecamp/active_record-tenanted/pull/86
ref: https://37s.fizzy.37signals.com/collections/693169862/cards/999008694
2025-04-24 15:07:08 -04:00
Jason Zimdars dca5e3b942 New layout for collections settings, stub entropy setting 2025-04-24 12:56:14 -05:00
Jason Zimdars adf3d52095 Adjust collection line to contrast with comment excerpts 2025-04-24 12:02:46 -05:00
Jorge Manrubia 0be58f50a5 Add comment about something that is pending 2025-04-24 18:53:45 +02:00
Jason Zimdars a4ce130c1c Adjust perma layout for larger cards 2025-04-24 11:51:27 -05:00
Jason Zimdars 3f9198d543 Give the timeline a little space on each side 2025-04-24 11:31:51 -05:00
Jason Zimdars 00bcc2183e Should be full opacity 2025-04-24 11:14:31 -05:00
Jorge Manrubia 25dbd77acd Tidy up things a bit removing dups and splitting methods 2025-04-24 18:01:49 +02:00
Jason Zimdars a898e93c25 Update icon classes to match output from event_action_icon(event) 2025-04-24 11:00:12 -05:00
Jason Zimdars 5239a2c628 Remove extra close bracket 2025-04-24 10:47:59 -05:00
Jorge Manrubia 79df3bcb2a Compact things a bit 2025-04-24 17:15:41 +02:00
Jorge Manrubia 8e136875ad Inline method 2025-04-24 16:53:00 +02:00
Jorge Manrubia 2652e21055 Remove noisy filter actions 2025-04-24 16:41:40 +02:00
Jorge Manrubia 5277086611 Use plural for consistency 2025-04-24 16:27:41 +02:00
Jorge Manrubia 4aedb70e70 Move to method 2025-04-24 16:27:19 +02:00
Jorge Manrubia b5737ee9ed Rename 2025-04-24 16:06:28 +02:00
Jorge Manrubia a9ad52e390 Rename for consistency 2025-04-24 16:02:32 +02:00
Jorge Manrubia 331fdc05f6 Format 2025-04-24 15:20:08 +02:00
Jorge Manrubia 40368032f2 Split notifiers for comments and cards
This lets us remove the annoying if to check the card
2025-04-24 15:19:42 +02:00
Jorge Manrubia ccb72ad229 Rename for consistency with what we had for comments 2025-04-24 14:51:25 +02:00
Jorge Manrubia 4183a5a32c Remove unneeded transaction 2025-04-24 14:49:48 +02:00
Jorge Manrubia b29d66296a Rename 2025-04-24 14:46:59 +02:00
Jorge Manrubia 92e913d0d5 Rename 2025-04-24 14:30:16 +02:00
Jorge Manrubia 1196266deb Split event rendering in two templates to remove conditional 2025-04-24 14:08:20 +02:00
Jorge Manrubia 27f6006b58 Does not belong here anymore 2025-04-24 13:48:53 +02:00
Jorge Manrubia 905ccb9b4b Make comments the event's host 2025-04-24 13:45:48 +02:00
Jorge Manrubia 18cc24e1d3 Add an event prefix named after the model now that events are generic 2025-04-24 13:20:09 +02:00
Jorge Manrubia b746987712 Make eventable a generic concern and create a card's especialization for it 2025-04-24 13:07:12 +02:00
Jorge Manrubia e8cffd0717 Add missing test 2025-04-24 12:37:25 +02:00
Jorge Manrubia aee7f4f886 Not used 2025-04-24 12:34:33 +02:00
Jorge Manrubia 13b0c0fc41 First pass to tidy up activity time rendering 2025-04-24 12:28:16 +02:00
Jorge Manrubia 965100df51 Access events through collections 2025-04-24 12:28:16 +02:00