Commit Graph

691 Commits

Author SHA1 Message Date
Jorge Manrubia 2b98db9e66 Flatten out comments and messages
https://37s.fizzy.37signals.com/collections/693169850/cards/999008989#comment_994777841
2025-04-29 19:21:18 +02:00
Jason Zimdars b6658d3081 Bring back custom collections
WIP, still needs UI for creating new custom collections but there are two hard-coded collections and any previously created ones on production should now be available again
2025-04-26 20:49:35 -05:00
Jorge Manrubia 76fc4aeb0e Order method 2025-04-26 09:10:58 +02:00
Jorge Manrubia e90b062440 Configure the autoclose period at the collection level 2025-04-25 13:29:16 +02:00
Jorge Manrubia 6fb0d88079 Tidy up 2025-04-25 08:22:21 +02:00
Jorge Manrubia 55059e968b Fix collection filtering persistence via cookies 2025-04-25 07:22:54 +02:00
Jorge Manrubia 0be58f50a5 Add comment about something that is pending 2025-04-24 18:53:45 +02:00
Jorge Manrubia 79df3bcb2a Compact things a bit 2025-04-24 17:15:41 +02:00
Jorge Manrubia 8e136875ad Inline method 2025-04-24 16:53:00 +02:00
Jorge Manrubia 2652e21055 Remove noisy filter actions 2025-04-24 16:41:40 +02:00
Jorge Manrubia 5277086611 Use plural for consistency 2025-04-24 16:27:41 +02:00
Jorge Manrubia 4aedb70e70 Move to method 2025-04-24 16:27:19 +02:00
Jorge Manrubia b5737ee9ed Rename 2025-04-24 16:06:28 +02:00
Jorge Manrubia a9ad52e390 Rename for consistency 2025-04-24 16:02:32 +02:00
Jorge Manrubia b29d66296a Rename 2025-04-24 14:46:59 +02:00
Jorge Manrubia 92e913d0d5 Rename 2025-04-24 14:30:16 +02:00
Jorge Manrubia 13b0c0fc41 First pass to tidy up activity time rendering 2025-04-24 12:28:16 +02:00
Jorge Manrubia 965100df51 Access events through collections 2025-04-24 12:28:16 +02:00
Jorge Manrubia 54f4bd5144 Generalize event's cards as eventable,add collection
Lots to tidy up but this is working
2025-04-24 12:28:16 +02:00
Jorge Manrubia f166b30f2f Fix: dismiss mention notifications in cards and comments when reading a card 2025-04-24 12:19:20 +02:00
Jorge Manrubia b08326ccbe Merge branch 'main' into plain-text-mentions
* main: (48 commits)
  Improve layout and truncation
  This is annoying
  Fix summary
  Remove index columns
  Same treatment for the events index
  New menu filters and navigates
  Don't test for _Added by_ events
  Indention
  @collection is always available when card scoped
  Style
  Remove check for _Added by..._ line
  The placeholder attribute is on the `house-md` element
  Duh, no before destroy commit, but this is still not right!
  No long transactions!
  Don't display published event in threads
  But feels more essentially part of the User, so list first
  Not related to the other two
  Missing controller
  Style
  Errant `bubbles` => `cards` replacement
  ...

# Conflicts:
#	app/models/card.rb
#	app/models/user.rb
#	db/schema.rb
#	db/schema_cache.yml
2025-04-23 17:24:01 +02:00
David Heinemeier Hansson 3d28203224 Use singular staging resource and beef up testing 2025-04-22 14:44:55 +02:00
David Heinemeier Hansson 2d5901fe1e Fix pin turbo stream response rendering 2025-04-22 11:48:19 +02:00
Jorge Manrubia aa3acfeaa8 Add plain text mentions 2025-04-22 11:26:56 +02:00
Jorge Manrubia b0aae3ad9e Reapply "Add a description field for cards"
This reverts commit a4cc143b09.
2025-04-21 16:45:24 +02:00
Jorge Manrubia a4cc143b09 Revert "Add a description field for cards" 2025-04-21 16:41:33 +02:00
Jorge Manrubia fb83b5e70e Merge branch 'main' into add-card-description
* main:
  Fix trailing empty line
  --skip-server in ci setup
  Enumerate all the options for logging in
  Have an empty first-run tenant too
  Convert to conventional Rails style
  Seed multiple seed accounts with basic DSL
  Stlye
  No need to run Solid Cache in development
  Use morphing to replace the card and exclude turbo frames from being replaced
  Name is already schema and UI required
  Cards have a not-null schema and collections destroy all cards on deletion
  No longer used
  Inline touch check thats only used once

# Conflicts:
#	app/views/cards/_container.html.erb
2025-04-21 16:04:06 +02:00
Jorge Manrubia 3e1a2bcc7e Use morphing to replace the card and exclude turbo frames from being replaced
Reconnecting the frames result in a visible flickering.

This also prevents flickering in the avatars when replacing the card container.
2025-04-21 09:24:57 +02:00
David Heinemeier Hansson 9e921b85c0 Merge branch 'main' into add-card-description 2025-04-19 20:00:43 +02:00
David Heinemeier Hansson 9cea403acd Make sure that any card getting read does not empty out the notifications tray
Since we wont rehydrate it
2025-04-18 16:32:27 +02:00
David Heinemeier Hansson f594bc09a0 Simplify
This is coming straight from the form, unlikely to blow up
2025-04-18 16:24:54 +02:00
David Heinemeier Hansson f6cd21f7cb Extract default stages into something that will be created together with a new Workflow in the model 2025-04-18 16:07:01 +02:00
David Heinemeier Hansson 1026408736 Need this for the draft header to be visible 2025-04-18 15:22:59 +02:00
David Heinemeier Hansson f3000a02c5 Follow render_card_replacement pattern
And clean up the rest of the implementation a tad.
2025-04-18 15:20:38 +02:00
David Heinemeier Hansson 7395d4e034 Removing the image can also just be done as a card replacement 2025-04-18 15:14:36 +02:00
Jason Zimdars 04f9a0f83a Merge branch 'main' into add-card-description
* main: (33 commits)
  Run beamer accessories in production only
  Less noisy logging in production
  Inline perma to container partial
  Use card replacement for card updates too
  Extract helper method to keep partial at a uniform level of abstraction
  Remove duplicated conditional
  Style
  Note that we dont want to keep reloading these frames
  I like this even better
  Suffix qualifier is unnnecessary
  Group partials for container
  Match domain language
  Fix trailing space
  Use card rerendering instead of redirects
  Better name
  Stick with domain language
  Fix tests
  Rerender instead of redirect
  Style
  Extract partials that can be rerendered
  ...
2025-04-17 16:40:23 -05:00
David Heinemeier Hansson 0e442ac0d0 Use card replacement for card updates too 2025-04-17 15:56:56 +02:00
David Heinemeier Hansson ac9cbad4f9 I like this even better 2025-04-17 15:32:09 +02:00
David Heinemeier Hansson 62088b66d1 Suffix qualifier is unnnecessary 2025-04-17 15:30:55 +02:00
David Heinemeier Hansson 4dbd8205ce Fix trailing space 2025-04-17 15:21:14 +02:00
David Heinemeier Hansson 7adbd8d634 Use card rerendering instead of redirects 2025-04-17 15:20:27 +02:00
David Heinemeier Hansson 547e5ea24f Rerender instead of redirect 2025-04-17 14:54:29 +02:00
David Heinemeier Hansson 4d0dddec46 No need to loop through a job when this is the sole point of the action 2025-04-17 14:31:28 +02:00
David Heinemeier Hansson 87ce4a623b Even clearer about where these pins are going 2025-04-17 14:31:02 +02:00
David Heinemeier Hansson 1437bcb3b7 Clearer about where these are being sent 2025-04-17 14:29:12 +02:00
David Heinemeier Hansson fc0cf3917f Pin without redirect
Use turbo stream response to save on the redirect latency
2025-04-17 14:05:26 +02:00
David Heinemeier Hansson 07e801b74c Fix pinning to tray
They need to have a complete dom element that is unique
2025-04-17 13:52:55 +02:00
David Heinemeier Hansson a5de4863fa Allow for multiple notifications to be read
cc @kevinmcconnell
2025-04-17 11:39:37 +02:00
Kevin McConnell 6c8fe164b3 Read a card should dismiss all notifications
Previous code assumed that there was a single notification to dismiss
for that card, but in practice there can be zero or many. If it's zero,
we need to avoid the crash. If it's many, we should dismiss them all.

Also re-rendering the notification stack after dismissing enables us to
remove all the removed cards, as well as reveal any older ones that were
previously outside the visible page size.

This reverts commit 6135909b7e.
2025-04-17 09:40:59 +01:00
Jason Zimdars d257cb5fb6 No longer used 2025-04-16 18:57:47 -05:00