Jason Zimdars
7b3b5c471b
Add a description filed for cards
2025-04-16 18:53:26 -05:00
David Heinemeier Hansson
5dc6e0394f
Style
2025-04-16 17:12:20 +02:00
David Heinemeier Hansson
d8ec2c3364
More natural to fetch that which will be shown first
2025-04-16 16:58:03 +02:00
David Heinemeier Hansson
6135909b7e
Card readings just need to remove the notification
...
No need to broadcast everything again
2025-04-16 16:51:18 +02:00
David Heinemeier Hansson
98401b9536
Explain this
2025-04-16 16:44:04 +02:00
David Heinemeier Hansson
4bb9085737
Hide implementation detail of reading
2025-04-16 16:41:22 +02:00
David Heinemeier Hansson
8ff71b2650
Dont turbo stream when coming from a read_all redirect
2025-04-16 16:21:31 +02:00
David Heinemeier Hansson
5932bf9316
This is rare enough that a redirect is fine
2025-04-16 16:21:16 +02:00
David Heinemeier Hansson
d00a0433e9
Inline anemic method
2025-04-16 15:34:28 +02:00
David Heinemeier Hansson
73f272f132
Use one controller for all notification readings
2025-04-15 19:14:50 +02:00
David Heinemeier Hansson
2ea898324f
We can just set the namespace directly in the class name
2025-04-15 16:36:40 +02:00
David Heinemeier Hansson
680611503d
Distinguish between administering and just changing
2025-04-15 16:00:29 +02:00
David Heinemeier Hansson
2ace519d91
There is only one account, so just check join code directly
2025-04-15 15:35:10 +02:00
Andy Smith
a88264ed0a
Merge branch 'main' into consolidate-cards
...
* main: (94 commits)
Source order seems to be significant
Use `card.title`
Nicer flow
Fix string interpolation
Fix constant
Use record lookup
Always use sole
Explained less and extracted nothing of value
Weird double negative
Remove anemic and indirect method that explained nothing
Can use record lookup for workflows
Access control has already been done through the card
Style
Use _path in all cases where we are not potentially changing the domain
Clearer
Spacing
Get rid of card_title
Join the two users controllers but split out role setting
Ensure user is returned
We are not using the parameter
...
2025-04-14 09:40:22 -05:00
Jason Zimdars
289487a383
Source order seems to be significant
...
Regressed in d3c5c86b21
2025-04-14 09:23:57 -05:00
David Heinemeier Hansson
cfb345bc32
Nicer flow
2025-04-13 20:39:09 +02:00
David Heinemeier Hansson
e8a730c239
Fix constant
2025-04-13 20:36:07 +02:00
David Heinemeier Hansson
34232c0e31
Use record lookup
2025-04-13 20:30:03 +02:00
David Heinemeier Hansson
d9a9690137
Always use sole
2025-04-13 20:29:10 +02:00
David Heinemeier Hansson
9e0b9c08c2
Explained less and extracted nothing of value
2025-04-13 20:28:35 +02:00
David Heinemeier Hansson
33278469ef
Weird double negative
2025-04-13 20:26:58 +02:00
David Heinemeier Hansson
a5df54015e
Remove anemic and indirect method that explained nothing
2025-04-13 20:25:59 +02:00
David Heinemeier Hansson
e2a931b657
Can use record lookup for workflows
2025-04-13 20:24:16 +02:00
David Heinemeier Hansson
366fe06113
Access control has already been done through the card
2025-04-13 20:22:53 +02:00
David Heinemeier Hansson
e12ef119da
Style
2025-04-13 20:17:24 +02:00
David Heinemeier Hansson
dbf61f4fc3
Use _path in all cases where we are not potentially changing the domain
2025-04-13 08:17:36 +02:00
David Heinemeier Hansson
7b60748796
Clearer
2025-04-13 08:11:25 +02:00
David Heinemeier Hansson
4ef46ccd19
Spacing
2025-04-13 08:10:47 +02:00
David Heinemeier Hansson
a106b1b6a7
Join the two users controllers but split out role setting
2025-04-12 20:30:47 +02:00
David Heinemeier Hansson
6bbf68a4f9
The tenanted db is the account scope
2025-04-12 20:06:34 +02:00
David Heinemeier Hansson
760cbb6c99
Drop boosts
...
Killed by design.
2025-04-12 18:52:54 +02:00
David Heinemeier Hansson
1b732c41c7
Use render svg
2025-04-12 18:15:05 +02:00
David Heinemeier Hansson
d3c5c86b21
Style
2025-04-12 14:06:11 +02:00
David Heinemeier Hansson
a9c6f8bceb
No reuse likely
2025-04-12 13:51:47 +02:00
David Heinemeier Hansson
b36b2f04a9
Too clever to have the redirect_to directly on the factory method return
2025-04-12 13:49:23 +02:00
David Heinemeier Hansson
19c537af64
Inline anemic method
2025-04-12 13:48:03 +02:00
David Heinemeier Hansson
e8a839d5f6
We have a callback dependency to do this actually
2025-04-12 11:47:08 +02:00
David Heinemeier Hansson
63c05220ce
Clearer naming
2025-04-12 11:09:55 +02:00
David Heinemeier Hansson
27d90abbd6
Reduce the direct knowledge of comments inside the card
2025-04-12 11:04:16 +02:00
David Heinemeier Hansson
24b02c42fd
Comments are dependents of messages, so need to destroy the latter to get the former
2025-04-12 10:59:59 +02:00
Andy Smith
47974b5e3b
Fix failing pin test
2025-04-11 16:14:56 -05:00
David Heinemeier Hansson
aefae634c3
Anemic params method
...
Wont ever get reused here since there is no update
2025-04-11 18:21:44 +02:00
David Heinemeier Hansson
8d36f13fab
No longer needing that extra local
2025-04-11 18:20:28 +02:00
David Heinemeier Hansson
06a636bd8d
Did need to separate them out for the broadcast
2025-04-11 18:19:33 +02:00
David Heinemeier Hansson
5fa8007397
Loaded directly in the partial
2025-04-11 18:19:10 +02:00
David Heinemeier Hansson
7861b7c087
Just open one turbo stream per card
...
Per comment is excessive and needless
2025-04-11 17:58:11 +02:00
David Heinemeier Hansson
79700162fc
Use correct stream name
...
comment, :comments makes no sense for a stream for the reactions
2025-04-11 17:47:35 +02:00
David Heinemeier Hansson
eec76d0d4f
Use modern params#expect
2025-04-11 17:43:31 +02:00
David Heinemeier Hansson
f9bb779b61
Use local vars so ivar dependency is only from before actions
2025-04-11 17:42:30 +02:00
David Heinemeier Hansson
3ecf150636
Use proper access control
...
Otherwise you could react to any comment on the entire account. And then
you might as well just do Comment.find.
2025-04-11 17:41:28 +02:00