Commit Graph

1191 Commits

Author SHA1 Message Date
Jason Zimdars c55501a6c8 Remove unused display count feature 2025-04-09 14:54:53 -05:00
Jorge Manrubia 473fa1dafd Rename constant 2025-04-09 21:28:29 +02:00
Jorge Manrubia 221bbb3247 Fix renames that the scripts missed 2025-04-09 14:56:59 +02:00
Jorge Manrubia 723e6d94f5 Rename bubbles => cards 2025-04-09 14:50:58 +02:00
Jorge Manrubia 2106fb464a Revert "Scope searches by user"
This reverts commit 47552dd8d7.
2025-04-07 13:42:57 +02:00
Jorge Manrubia 47552dd8d7 Scope searches by user 2025-04-07 13:42:27 +02:00
Jorge Manrubia 9b4169c7ca Scope data by account
With a single database this problem is not as bad, but it feels
safer to do things right. Also, not everyone in an account has access
to all the bubbles.
2025-04-07 13:09:49 +02:00
Jorge Manrubia f403ed070c Downcase tag titles 2025-04-07 10:43:23 +02:00
Jorge Manrubia 99584a17f4 Ignore case when trying to match tags 2025-04-07 06:01:43 +02:00
David Heinemeier Hansson eb0614c44f Use a more ergonomic API for watching
Passing a boolean vs using explicit on/off methods feel too low level
and doesnt read right in most of these cases.
2025-04-06 19:17:26 +02:00
David Heinemeier Hansson 78c82584cf Reads nicer now that we are using long form operations 2025-04-06 18:45:58 +02:00
David Heinemeier Hansson 21211cedca These really are anemic too 2025-04-06 18:16:47 +02:00
David Heinemeier Hansson cc0c88d999 Remove anemic finder 2025-04-06 18:15:13 +02:00
David Heinemeier Hansson eb047aec4d Neater 2025-04-06 13:30:20 +02:00
David Heinemeier Hansson 5e78a1dab1 Make it clearer that this takes a title string not a tag object 2025-04-06 13:28:52 +02:00
David Heinemeier Hansson a58fcd3123 Nicer API 2025-04-06 13:26:10 +02:00
David Heinemeier Hansson cdd78b41ee Tag exclusively by title 2025-04-06 13:19:22 +02:00
David Heinemeier Hansson ee22e69e6e Move taggings to bubbles 2025-04-05 22:19:12 +02:00
David Heinemeier Hansson 6990f1eb05 Alpha sort regardless of capitalization 2025-04-05 16:27:22 +02:00
David Heinemeier Hansson e4c6fe4b55 Shape up pinning API and broadcast in the controller 2025-04-05 15:15:48 +02:00
David Heinemeier Hansson f063116df4 Group related associations together 2025-04-05 13:19:30 +02:00
David Heinemeier Hansson aefbac9c14 Get rid of single-use and slight awkward model scope
Really dont like that raw Arel.sql wrapping that is required.
2025-04-05 13:17:42 +02:00
David Heinemeier Hansson 821f4c43d8 Excess CR 2025-04-05 12:49:19 +02:00
David Heinemeier Hansson 1463fa68f4 Sessions only depend on user and have no callback, so use the faster delete_all 2025-04-05 12:48:52 +02:00
David Heinemeier Hansson 8ff017fc5b Only one invocation of this, not carrying the worth of its indirection
Generally I am wary of including global state checks in the belly of
models. It is one thing to do it as a default parameter, but I think it
is too far to do it inside an actual method.
2025-04-05 12:40:08 +02:00
David Heinemeier Hansson d237885bd4 Extract User::Assignee role
Keep slimming down that User
2025-04-05 12:37:18 +02:00
David Heinemeier Hansson 17bdfb5df5 Already included in the Avatar concern 2025-04-05 12:35:41 +02:00
David Heinemeier Hansson 92ce80cc32 Extract User::Accessor concern
Our User model is getting overloaded
2025-04-05 12:34:39 +02:00
Jorge Manrubia 6512b8c726 Only consider in doing/considering published cards 2025-04-04 17:58:27 +02:00
Jorge Manrubia f437aecf00 Sort completed bubbles by most recently completed first 2025-04-04 15:39:00 +02:00
Jorge Manrubia 0e3f756a27 Merge pull request #351 from basecamp/close-with-label
Close as...
2025-04-04 15:09:47 +02:00
Jorge Manrubia 5337f019de Merge pull request #350 from basecamp/auto-close
Move stagnated cards to "reconsidering" automatically
2025-04-04 15:08:19 +02:00
Jorge Manrubia be4a738f1d Make reason not null 2025-04-04 15:06:43 +02:00
Jorge Manrubia de8a1120eb Move constant to new concern to group labels together 2025-04-04 12:24:11 +02:00
Jorge Manrubia afcc65d6fb Create default pop reasons when creating accounts 2025-04-04 12:10:28 +02:00
Jorge Manrubia 1f4be8ed67 Only pop bubbles in a considering state 2025-04-04 12:04:54 +02:00
Jorge Manrubia 77d0cd5e7f Close as working with default fallback label 2025-04-04 10:59:53 +02:00
Jorge Manrubia 6f93d4b72a Add system to auto reconsider inactive bubbles after 30 days 2025-04-04 10:04:39 +02:00
Jorge Manrubia 08cb69aca5 Replace auto_pop_at with generic last_activity column
so that we can use it in other scenarios
2025-04-04 09:45:56 +02:00
Jorge Manrubia 7dd711bcf6 Invalidate cache when changing the engagement 2025-04-04 08:45:00 +02:00
Jorge Manrubia dbae700554 Merge pull request #346 from basecamp/two-columns-refactor
Refactor collections perma + support for doing/considering
2025-04-04 08:29:17 +02:00
Jorge Manrubia 05fc73e2ae Merge pull request #334 from basecamp/user-admins
Add admin role and animate admin toggle
2025-04-04 08:29:03 +02:00
Jason Zimdars 1ea70d7d3b Merge branch 'main' into two-columns-refactor
* main:
  Fix image icons
  Revert "Merge pull request #345 from basecamp/cascade-layers"
  Fine tune notifications states
  Remove empty helper
  Use an icon for the button
  Show button on collection page and notif settings
  Add involvement types to accesses
  Extract a couple components
  Add cascade layers to all CSS files
2025-04-03 19:30:37 -05:00
Jorge Manrubia c29768e988 Add missing transaction 2025-04-03 18:04:23 +02:00
Jorge Manrubia cfe91c25c9 Add admin role, make sure only admins can remove and promote other users 2025-04-03 17:43:29 +02:00
Kevin McConnell 0820badcc3 Add involvement types to accesses
This provides a way to set the level of involvement that a user has with
a collection, and from which we determine the level of notifications to
send. Users can be access-only, watching, or being notified about
everything.

If you're access-only, you won't get an notifications. If you're
watching, you'll only get notifications for the items you're watching
(which includes the items you've been assigned, have commented on, etc).
If you're set to everything you'll get notifications about all activity
in that collection.

This change replaces our previous concept of subscriptions. Where
previously you'd subscribe to a collection to get notifications in it,
now you'll simply set the notification level on your access.
2025-04-03 16:35:13 +01:00
Jorge Manrubia 8c1efa9e89 Only active cards can be in doing/considered 2025-04-03 17:20:43 +02:00
Jorge Manrubia 834b7095d3 Don't dup to avoid the memoized bubbles cache 2025-04-03 14:34:02 +02:00
Jorge Manrubia cf8331dad7 No need to modify this filter, it was already working well 2025-04-03 14:25:48 +02:00
Jorge Manrubia 91ddb1d093 Oversight 2025-04-03 14:21:21 +02:00