Commit Graph

1191 Commits

Author SHA1 Message Date
Jorge Manrubia 053ae76312 Tweak prompt 2025-07-22 12:06:56 +02:00
Jorge Manrubia 7cd459f2b8 AI Summaries: basic abstractions, functional version 2025-07-22 11:57:39 +02:00
Jason Zimdars 0afc738d19 Whitespace 2025-07-21 20:11:03 -05:00
Jason Zimdars 2593fe2221 DRY 2025-07-21 19:58:11 -05:00
Jason Zimdars 97022be929 Clean up 2025-07-21 19:01:48 -05:00
Jason Zimdars c3b946c961 Design flow for enabling push and the various status that go with it 2025-07-21 18:27:31 -05:00
Jason Zimdars a6e9e51071 Merge branch 'main' into web-push
* main: (28 commits)
  Clean up the /scripts directory
  Prevent recursion when invoking AI
  Bump sqlite3 from 2.7.2 to 2.7.3
  Port over Jeremy's fix for slow uploads
  .gitignore log files and portfolio's local storage
  Drop Current.account and just use Account.sole
  Use the utf8-patched mysql driver
  Call blob.preview for previewable attachments
  Make sure the image variants we use are preprocessed
  Add /user command
  Make sure it doesn't infer custom abbreviations when matching user names
  Script to load prod db in development
  Update Signup to use the queenbee_id for the tenant name
  Bump cache version
  Make sure it uses latest bundler to prevent error due to mismatch
  Invalidate cache
  Update ruby
  Update bundler to prevent error on lower version
  Update bundler to prevent error on lower version
  Resolve stages
  ...
2025-07-21 11:03:56 -05:00
Jorge Manrubia 2cd4dd8709 Prevent recursion when invoking AI
This can result in stack overflow errors for missing commands.

https://fizzy.37signals.com/5986089/collections/7/cards/1135

Follow up to https://github.com/basecamp/fizzy/pull/766
2025-07-21 10:25:26 +02:00
Mike Dalessio 8e13ce5b78 Drop Current.account and just use Account.sole
I had reintroduced this in dacb53b8 after David removed it in
6bbf68a4, but now I agree we don't need it.

Also, fix a CORS error when trying to redirect a user to an untenanted
path after login (see
https://fizzy.37signals.com/5986089/collections/2/cards/1032).
2025-07-20 13:00:09 -04:00
Mike Dalessio ef6198d394 Make sure the image variants we use are preprocessed
to avoid implicitly creating a variant during a GET to a read replica,
which will raise an exception and cause the image to fail to load.

This feels pretty brittle, to be honest, and we'll need to be careful
in the future about creating and using new variants; we will probably
need to backfill the new variant for existing images because we can't
guarantee that they will be created implicitly/lazily if the GET lands
on the replica.

ref: https://fizzy.37signals.com/5986089/collections/7/cards/942
2025-07-18 15:43:31 -04:00
Jorge Manrubia 39c7a54ad6 Add /user command
The LLM was relying on it. Having it missing resulted in a stack overflow error!

https://fizzy.37signals.com/5986089/collections/7/cards/1135
2025-07-18 17:59:02 +02:00
Jorge Manrubia 921db25646 Make sure it doesn't infer custom abbreviations when matching user names 2025-07-18 17:31:19 +02:00
Mike Dalessio 15876b8762 Update Signup to use the queenbee_id for the tenant name
and not the subdomain. This change should have been in #665
2025-07-18 10:11:10 -04:00
Jorge Manrubia 16abcf2049 Bump cache version 2025-07-18 14:32:04 +02:00
Jorge Manrubia c144ef68cb Invalidate cache 2025-07-18 14:14:40 +02:00
Jorge Manrubia d9b2a49892 Resolve stages 2025-07-18 12:47:03 +02:00
Jorge Manrubia a1e3835eb8 Prevent 500 when running /search with empty string 2025-07-18 10:55:36 +02:00
Jorge Manrubia 44873e8ac4 More refinements 2025-07-18 06:50:13 +02:00
Jorge Manrubia d81568ff57 Filter by stage id, much better collection filtering 2025-07-18 05:50:22 +02:00
Jason Zimdars 4330cb4071 Ensure notifications link to the correct account 2025-07-17 22:20:16 -05:00
Jorge Manrubia b30bc85f4e Rework prompt to make it less ambiguous and better overall 2025-07-18 05:11:08 +02:00
Jason Zimdars 045460cd60 Revert "Use urls"
This reverts commit 74b5ac4244.
2025-07-17 20:12:06 -05:00
Jason Zimdars 74b5ac4244 Use urls 2025-07-17 19:54:29 -05:00
Jason Zimdars 6524363aec Merge branch 'main' into web-push
* main:
  Update dependencies
  dep: bump to ruby 3.4.5
  Switch to docker-dev
  Cache needs to include publication key
  First iteration on adding new users, from the console.
  Fix clear button position in Safari
  Give them screen reader labels
  Not needed
  Add missing `lang` attribute
  Restore missing aspect ratio on the perma
  Give the field more space when typing on mobile
  We're only concerned with truncating the placeholder, scope to that
  Make sure users can't login from launchpad if they're deactivated
  Destroy the SignalId::User when a user is deactivated
2025-07-17 14:31:05 -05:00
Jorge Manrubia 1486392b6b WIP 2025-07-17 13:32:37 +02:00
Jorge Manrubia 5f04696fe8 Rewrite prompt to be more accurate and example-driven 2025-07-17 13:32:36 +02:00
Mike Dalessio a099b4101a dep: bump to ruby 3.4.5
Also:

- bump bundler to 2.7.0
- work around the fix for https://bugs.ruby-lang.org/issues/21196 that appeared in 3.4.5
2025-07-16 19:13:39 -04:00
Jason Zimdars c8eb1c616d Need url helpers 2025-07-15 18:48:49 -05:00
Mike Dalessio e69023993c Make sure users can't login from launchpad if they're deactivated
Just in case the SignalId::User deletion failed.
2025-07-15 18:47:38 -04:00
Mike Dalessio 9f887e17f5 Destroy the SignalId::User when a user is deactivated 2025-07-15 18:30:23 -04:00
Jason Zimdars 38d13f78a3 Add pusher models and job 2025-07-15 13:16:18 -05:00
Jason Zimdars e59a994a0c Add db table and models 2025-07-14 19:57:30 -05:00
Jason Zimdars 97e20c5cd7 Make nil safe 2025-07-08 16:57:48 -05:00
Jason Zimdars 485e575c40 Merge branch 'main' into card-attachments
* main: (45 commits)
  Display tag counts in the filter menu
  Move Add Card button to header
  Re-write help content, try a modal-like display
  Move to internal registry
  Show date instead of time for notifications older than 1 day
  Ensure checks are visible for tags and assignments
  Adjust padding so card number isn't cut off
  Don't color the collection header in considering
  Golden cards bubble to the top of Considering, too
  Adjust card collection header when colored golden
  Allow cards in Considering to gilded
  Hide focus ring on new card titles and step inputs
  Add hover effect for comment edit button
  Add hover effect to overflow button
  Improve multi-account behavior of the PWA
  Remove unneeded *
  Rename test
  Review the code to move cards
  Update editor
  Generalize and delete mentions too
  ...
2025-07-08 16:04:14 -05:00
Jason Zimdars 27285a3dcb Display tag counts in the filter menu
- Provides a little information scent
- Prevents being surprised by "no results"
2025-07-08 15:57:29 -05:00
Jason Zimdars c66261d30f Golden cards bubble to the top of Considering, too 2025-07-07 15:35:05 -05:00
Jorge Manrubia 88074cc7ed Remove unneeded * 2025-07-04 21:57:18 +02:00
Jorge Manrubia 919211244b Review the code to move cards
- Scope accessed records
- Keep consistency by moving events too
2025-07-04 19:56:48 +02:00
Jorge Manrubia 3fb3e5b48e Generalize and delete mentions too 2025-07-04 19:08:29 +02:00
Jorge Manrubia cbeefc5b74 Remove unused code 2025-07-04 19:00:22 +02:00
Jorge Manrubia 9e0d668348 Make sure we don't remove accesses if collection is accessible 2025-07-04 18:56:30 +02:00
Jorge Manrubia c621cc6cc9 Destroy notifications when losing access to collection 2025-07-04 18:52:29 +02:00
Jorge Manrubia b8b4ef5463 Extract common concern to examine attachments 2025-07-04 17:53:37 +02:00
Jorge Manrubia 0191eb85dc Merge branch 'main' into card-attachments
* main:
  Don't create mentions from drafts until those are published
  Change Active Storage account slug extension to a to_prepare block
  dep: bump actiontext-lexical for previewable attachment fix
  Add assertion for composite command line
  Remove trace
  restore the right command
  Update action text
  The prompt confirmation system wasn't really working after moving to lexical
  Parse commands where it's just a gid properly
  Move inside concerns or the override won't work
  Truncation for comment author line
  Avoid duplicated queries and, instead, bump the last ones
  Adjust screen for screen readers
  Adjust icon sizing and uploading styles
2025-07-04 17:38:27 +02:00
Jorge Manrubia ec0c019967 Merge pull request #711 from basecamp/mentionable-published
Don't create mentions from drafts until those are published
2025-07-04 17:28:19 +02:00
Jorge Manrubia b9f7634457 Merge pull request #706 from basecamp/duplicated-seraches
Avoid duplicated queries and, instead, bump the last ones
2025-07-04 17:28:15 +02:00
Jorge Manrubia 17f9df8df3 Don't create mentions from drafts until those are published
https://fizzy.37signals.com/5986089/collections/2/cards/982
2025-07-04 17:25:39 +02:00
Jorge Manrubia 3ed7c940d9 Remove trace 2025-07-04 00:07:03 +02:00
Jorge Manrubia 2cd8df4975 restore the right command 2025-07-04 00:05:52 +02:00
Jason Zimdars 0539d366d7 Display attachments in events for comments 2025-07-03 16:48:43 -05:00