I don't remember why I added this but we don't really need it. Also, this result
in potential ambiguity even when you use prompts for standalone tags and mentions
* main: (57 commits)
Untenanted access in authenticated controllers should request auth
dep: bundle update
dep: update Rails
dep: bump AR::Tenanted
Clean up the cable meta tag
Fix activity feed pagination to fetch on demand
Create a "published" event if a card is created published
Scatter Honcho seeds over a 30 day period
Fix the PWA manifest to use slugged URLs
Collection publication edits render a turbo frame
Collection workflow edits render a turbo frame
Collection entropy config edits render a turbo frame
Use automatic sizing where supported
Introduce a separate controller for collection entropy config
Add `card_id` to index
Move to scope and inline method
Prefer modern syntax
Fix that stage should be visible above card background
Indicate opens menu
Hide dialog targets from screen readers when closed
...
# Conflicts:
# db/schema.rb
# db/schema_cache.yml
* main: (22 commits)
Fix that stage should be visible above card background
Indicate opens menu
Hide dialog targets from screen readers when closed
Mark up as heading for screen reader navigation
Copy for screen readers
Don't hide the input so it's accessible to screen readers
Point skip links to correct anchor, don't navigate with turbo
There aren't any `li` children so just use `div`
Use headings for screen reader navigation
Use `h3` for individual cards in collection view
Make collection title `h1` for screen reader navigation
Esc should not propagate when closing dialogs
squash! Remove session controller actions other than delete
Screen reader: Use heading for comments navigation
Remove the invitation codes for now
Remove session controller actions other than delete
Correct label for field
Style
Screen reader: De-duplicate links for each person in account settings
Account.signal_account is no longer optional
...
* main:
Script to create Users for existing 37id accounts
Configure Mission Control to skip tenanted authentication
Script to update URLs and attachments in cards and comments
Make sure seeds are creating sluggable tenants
Script to rename tenants after the QB account id
Update the signups tests to work with untenanted paths
Update the Command classes to handle paths with account slugs
Update bin/dev to point at the new tenant URLs
Patch Active Storage controllers to generate slugged URLs
Point Action Cable at the slugged cable endpoint
Extract pieces from the tenanting initializer
Patch Turbo to use the request script name
Use the new AR::Tenanted convention for action cable connections
Use a tenant resolver that recognizes the account slug
dep: Use the patched AR::Tenanted branch
I went with placing htis logic at the command level since it plays well with the composite structure, where you don't know whether you are handling one command or many commands, and you want to aggregate all the errors. I didn't leverage the existing support with rails' model errors because that customizing those message is cumbersome (either i18n or using custom validation logic for everything).
Jorge Manrubia