Commit Graph

2171 Commits

Author SHA1 Message Date
Andy Smith d3db752f39 Remove redundant flex-grow class from popup__items 2025-07-21 13:35:24 -05:00
Andy Smith 1e62ae8c94 Set min-width on popup__items 2025-07-21 13:32:56 -05:00
Jason Zimdars a6e9e51071 Merge branch 'main' into web-push
* main: (28 commits)
  Clean up the /scripts directory
  Prevent recursion when invoking AI
  Bump sqlite3 from 2.7.2 to 2.7.3
  Port over Jeremy's fix for slow uploads
  .gitignore log files and portfolio's local storage
  Drop Current.account and just use Account.sole
  Use the utf8-patched mysql driver
  Call blob.preview for previewable attachments
  Make sure the image variants we use are preprocessed
  Add /user command
  Make sure it doesn't infer custom abbreviations when matching user names
  Script to load prod db in development
  Update Signup to use the queenbee_id for the tenant name
  Bump cache version
  Make sure it uses latest bundler to prevent error due to mismatch
  Invalidate cache
  Update ruby
  Update bundler to prevent error on lower version
  Update bundler to prevent error on lower version
  Resolve stages
  ...
2025-07-21 11:03:56 -05:00
Mike Dalessio 8e13ce5b78 Drop Current.account and just use Account.sole
I had reintroduced this in dacb53b8 after David removed it in
6bbf68a4, but now I agree we don't need it.

Also, fix a CORS error when trying to redirect a user to an untenanted
path after login (see
https://fizzy.37signals.com/5986089/collections/2/cards/1032).
2025-07-20 13:00:09 -04:00
Mike Dalessio 692e563d3f Call blob.preview for previewable attachments
undoing a mistake introduced in ef6198d3
2025-07-19 09:08:59 -04:00
Mike Dalessio ef6198d394 Make sure the image variants we use are preprocessed
to avoid implicitly creating a variant during a GET to a read replica,
which will raise an exception and cause the image to fail to load.

This feels pretty brittle, to be honest, and we'll need to be careful
in the future about creating and using new variants; we will probably
need to backfill the new variant for existing images because we can't
guarantee that they will be created implicitly/lazily if the GET lands
on the replica.

ref: https://fizzy.37signals.com/5986089/collections/7/cards/942
2025-07-18 15:43:31 -04:00
Jason Zimdars 04df81bc75 Move to settings screen 2025-07-17 17:49:07 -05:00
Jason Zimdars 6524363aec Merge branch 'main' into web-push
* main:
  Update dependencies
  dep: bump to ruby 3.4.5
  Switch to docker-dev
  Cache needs to include publication key
  First iteration on adding new users, from the console.
  Fix clear button position in Safari
  Give them screen reader labels
  Not needed
  Add missing `lang` attribute
  Restore missing aspect ratio on the perma
  Give the field more space when typing on mobile
  We're only concerned with truncating the placeholder, scope to that
  Make sure users can't login from launchpad if they're deactivated
  Destroy the SignalId::User when a user is deactivated
2025-07-17 14:31:05 -05:00
Jason Zimdars 468a29c9ad Give them screen reader labels
See: https://fizzy.37signals.com/5986089/collections/2/cards/1106
2025-07-16 11:33:33 -05:00
Jason Zimdars f0235e7e07 Not needed
See: https://fizzy.37signals.com/5986089/collections/2/cards/1108
2025-07-16 11:08:06 -05:00
Jason Zimdars ec8084074f Add missing lang attribute
See: https://fizzy.37signals.com/5986089/collections/2/cards/1110
2025-07-16 11:05:23 -05:00
Jason Zimdars 15a809855d We're only concerned with truncating the placeholder, scope to that 2025-07-16 08:30:03 -05:00
Jason Zimdars 8f47db3ced Add service worker and subscriptions controllers 2025-07-15 15:22:32 -05:00
Jason Zimdars e59a994a0c Add db table and models 2025-07-14 19:57:30 -05:00
Andy Smith 8d60592ccd Merge pull request #720 from basecamp/notification-links
Notification links
2025-07-10 17:04:31 -05:00
Jason Zimdars 70c2cc62a1 Merge branch 'main' into public-collection-cards
* main:
  Revert "Adjust borders"
  Don't allow wrapping initially
  Adjust borders
  Truncate long commands
  Try using env safe insets to avoid overlapping elements on mobile
  Correct asset width and remove caption input focus ring
  Revert "Make a focus-ring global variable"
  Make a focus-ring global variable
  Set `id` explicitly so the `label for` reference works
  Higher resolution image
  When adding a card out of context, default to most recently accessed collection
  Fine tuning to handle different attachment types
  Replace helper with view lookup
  Make nil safe
  Extract attachments to a partial
  Remove `card_published` check and render its own template
  Extract common concern to examine attachments
  This is a hack but we should be showing the card description and attachments for new cards
  Display attachments in events for comments
  Indicate cards with attachments in the description
2025-07-10 16:33:51 -05:00
Jason Zimdars 74ac6fae9e Merge branch 'mobile-insets'
* mobile-insets:
  Revert "Adjust borders"
  Don't allow wrapping initially
  Adjust borders
  Try using env safe insets to avoid overlapping elements on mobile
2025-07-10 16:31:34 -05:00
Jason Zimdars 74e0cd3af8 Don't allow wrapping initially 2025-07-10 14:50:36 -05:00
Andy Smith 0585c5f1e1 Truncate long commands 2025-07-10 14:44:22 -05:00
Jason Zimdars 0d1c0f4e75 Try using env safe insets to avoid overlapping elements on mobile 2025-07-10 14:26:58 -05:00
Jason Zimdars 4d65d2be85 Set id explicitly so the label for reference works 2025-07-10 12:56:59 -05:00
Andy Smith 5162677c44 Align dialog, shrink hat, canvas background 2025-07-10 11:20:37 -05:00
Jorge Manrubia 81560c73dd Use existing direct route 2025-07-10 14:57:20 +02:00
Jason Zimdars ed37bf0ff8 When adding a card out of context, default to most recently accessed collection 2025-07-09 15:37:39 -05:00
Jason Zimdars 32e967c1f9 Fine tuning to handle different attachment types 2025-07-09 14:46:33 -05:00
Jason Zimdars 7a058a18d9 Merge branch 'main' into card-attachments
* main:
  Add circle-on-mobile button class
2025-07-09 11:22:41 -05:00
Jason Zimdars a60eedf186 Merge branch 'main' into public-collection-cards
* main:
  Add circle-on-mobile button class
2025-07-09 11:20:41 -05:00
Jason Zimdars cd022fcc1c Not fit for public 2025-07-09 11:10:41 -05:00
Jason Zimdars 55f92e73f7 Not needed here 2025-07-09 11:08:09 -05:00
Jason Zimdars b309f85d13 Match text style 2025-07-09 11:03:43 -05:00
Jason Zimdars 90419084c3 Ensure step checkboxes reflect status and can't be toggled 2025-07-09 11:01:54 -05:00
Jason Zimdars b142b08c05 Include lightbox viewer for background images 2025-07-09 10:58:23 -05:00
Jason Zimdars 4433e80691 Make steps non-interactive 2025-07-09 10:56:32 -05:00
Jason Zimdars 4cbe635faf No title links 2025-07-09 10:48:06 -05:00
Jason Zimdars bfa61705b6 Use existing preview templates 2025-07-09 10:47:39 -05:00
Jason Zimdars 9ac5f46875 This shouldn't ever appear on the index, we have a preview partial 2025-07-09 10:44:53 -05:00
Jason Zimdars f1337048bd This shouldn't need to be here, it would never be displayed and does nothing 2025-07-09 10:42:03 -05:00
Jason Zimdars 8f7a373aad Public card templates 2025-07-09 10:16:39 -05:00
Jorge Manrubia 78d446369c Replace helper with view lookup 2025-07-09 17:11:27 +02:00
Andy Smith 6627482f04 Add circle-on-mobile button class 2025-07-09 10:11:12 -05:00
Jason Zimdars badff5526d Move to layout so all public views display footer 2025-07-09 10:09:54 -05:00
Jason Zimdars 642c03b51f Extract attachments to a partial 2025-07-08 16:34:10 -05:00
Jason Zimdars 8d162be5e3 Remove card_published check and render its own template 2025-07-08 16:16:33 -05:00
Jason Zimdars 485e575c40 Merge branch 'main' into card-attachments
* main: (45 commits)
  Display tag counts in the filter menu
  Move Add Card button to header
  Re-write help content, try a modal-like display
  Move to internal registry
  Show date instead of time for notifications older than 1 day
  Ensure checks are visible for tags and assignments
  Adjust padding so card number isn't cut off
  Don't color the collection header in considering
  Golden cards bubble to the top of Considering, too
  Adjust card collection header when colored golden
  Allow cards in Considering to gilded
  Hide focus ring on new card titles and step inputs
  Add hover effect for comment edit button
  Add hover effect to overflow button
  Improve multi-account behavior of the PWA
  Remove unneeded *
  Rename test
  Review the code to move cards
  Update editor
  Generalize and delete mentions too
  ...
2025-07-08 16:04:14 -05:00
Jason Zimdars 27285a3dcb Display tag counts in the filter menu
- Provides a little information scent
- Prevents being surprised by "no results"
2025-07-08 15:57:29 -05:00
Andy Smith fdbb9c185e Merge branch 'main' into collection-nav
* main: (203 commits)
  Re-write help content, try a modal-like display
  Move to internal registry
  Show date instead of time for notifications older than 1 day
  Ensure checks are visible for tags and assignments
  Adjust padding so card number isn't cut off
  Don't color the collection header in considering
  Golden cards bubble to the top of Considering, too
  Adjust card collection header when colored golden
  Allow cards in Considering to gilded
  Hide focus ring on new card titles and step inputs
  Add hover effect for comment edit button
  Add hover effect to overflow button
  Improve multi-account behavior of the PWA
  Remove unneeded *
  Rename test
  Review the code to move cards
  Update editor
  Generalize and delete mentions too
  Remove unused code
  Make sure we don't remove accesses if collection is accessible
  ...
2025-07-08 15:34:01 -05:00
Andy Smith 00d68a482c Move Add Card button to header 2025-07-08 15:30:43 -05:00
Andy Smith 0491cd0818 More subtle styles 2025-07-08 15:00:06 -05:00
Andy Smith dcfa8357de Clarify notification actions 2025-07-08 14:49:12 -05:00
Jason Zimdars aaf577a971 Re-write help content, try a modal-like display 2025-07-08 14:33:42 -05:00