Commit Graph

2171 Commits

Author SHA1 Message Date
Jason Zimdars 96602d7a97 Show date instead of time for notifications older than 1 day 2025-07-07 17:12:43 -05:00
Andy Smith c338132b6f Clean odds and ends 2025-07-07 16:57:35 -05:00
Andy Smith ef2e9cf428 Remove actions markup and CSS 2025-07-07 16:41:47 -05:00
Andy Smith 524feedbfd WIP 2025-07-07 16:06:31 -05:00
Andy Smith a27987bd8e Add a button to remove pins from tray 2025-07-07 15:29:00 -05:00
Andy Smith 9e02af489d Rename expander button 2025-07-07 15:18:24 -05:00
Jason Zimdars 98f9ba5512 Allow cards in Considering to gilded 2025-07-07 15:14:33 -05:00
Andy Smith f00abdd089 Add another actions sections inside the tray 2025-07-07 15:11:28 -05:00
Andy Smith 6e2eacd3d8 Hide focus ring on new card titles and step inputs 2025-07-07 13:23:19 -05:00
Andy Smith f9c7862fc1 Add hover effect for comment edit button 2025-07-07 10:12:32 -05:00
Andy Smith 95dac275fd Add hover effect to overflow button 2025-07-07 10:07:56 -05:00
Andy Smith 84d5f64d1f Merge pull request #695 from basecamp/focus-hover-styles
Focus hover styles
2025-07-07 09:49:08 -05:00
Mike Dalessio e3c1e2c00a Improve multi-account behavior of the PWA
- PWA manifest:
  - declares slugged scope
  - includes the account name (and non-prod environment name) in the title

So we can have one PWA installed for each account (in each
environment) and links should get routed properly.

ref: https://3.basecamp.com/2914079/buckets/37331921/todos/8827769164
2025-07-05 13:05:08 -04:00
Jorge Manrubia 0191eb85dc Merge branch 'main' into card-attachments
* main:
  Don't create mentions from drafts until those are published
  Change Active Storage account slug extension to a to_prepare block
  dep: bump actiontext-lexical for previewable attachment fix
  Add assertion for composite command line
  Remove trace
  restore the right command
  Update action text
  The prompt confirmation system wasn't really working after moving to lexical
  Parse commands where it's just a gid properly
  Move inside concerns or the override won't work
  Truncation for comment author line
  Avoid duplicated queries and, instead, bump the last ones
  Adjust screen for screen readers
  Adjust icon sizing and uploading styles
2025-07-04 17:38:27 +02:00
Jason Zimdars 132059e77a This is a hack but we should be showing the card description and attachments for new cards 2025-07-03 16:54:26 -05:00
Jason Zimdars 0539d366d7 Display attachments in events for comments 2025-07-03 16:48:43 -05:00
Jason Zimdars cf4c6dba9c Indicate cards with attachments in the description 2025-07-03 15:56:25 -05:00
Andy Smith 757ff4ff2b Merge branch 'main' into focus-hover-styles 2025-07-03 15:14:14 -05:00
Jason Zimdars 8f42086703 Truncation for comment author line 2025-07-03 15:06:15 -05:00
Andy Smith 5c2997422f Address PR feedback 2025-07-03 15:00:12 -05:00
Jason Zimdars 5d34cb3f51 Adjust screen for screen readers 2025-07-03 14:37:31 -05:00
Jason Zimdars 24fa687b2d Merge branch 'main' into jz-7-3-25
* main: (57 commits)
  Rename /add_card => /add
  Cards' "stalled" metric is reset when reconsidered
  Use composite commands even for single commands since they can carry custom titles, which is what we want with AI
  Fix merge issues
  More prompt tweaks
  Support completed by via natural language
  Add filter pill for completed by
  Add "close by" filter
  Add /reopen command
  Improved support to act on cards via ID
  Refine prompt
  Add more tests and fix failing ones
  Add clarifying comment
  Return standalone command when only one command
  Extract attachable concerns
  Format
  Update lexical
  Use your user gid to resolve yourself, so that this is not ambiguous
  Support trailing spaces in inserted commands
  Disable attachments in the terminal
  ...
2025-07-03 11:04:15 -05:00
Jorge Manrubia f18b79d464 Rename /add_card => /add 2025-07-03 17:23:56 +02:00
Jason Zimdars 954d209cbc Link should break out of frame 2025-07-03 10:13:09 -05:00
Jason Zimdars 1dfe541bd4 Allow deselecting a Workflow 2025-07-03 10:11:36 -05:00
Jason Zimdars 645d4b3497 Fix broken page title 2025-07-03 09:35:24 -05:00
Jorge Manrubia a1a8828191 Merge pull request #684 from basecamp/fizzy-do-prompts
Add prompts to the Fizzy menu
2025-07-03 16:28:31 +02:00
Jorge Manrubia bd7b9a442e Merge branch 'main' into fizzy-do-prompts
* main: (57 commits)
  Untenanted access in authenticated controllers should request auth
  dep: bundle update
  dep: update Rails
  dep: bump AR::Tenanted
  Clean up the cable meta tag
  Fix activity feed pagination to fetch on demand
  Create a "published" event if a card is created published
  Scatter Honcho seeds over a 30 day period
  Fix the PWA manifest to use slugged URLs
  Collection publication edits render a turbo frame
  Collection workflow edits render a turbo frame
  Collection entropy config edits render a turbo frame
  Use automatic sizing where supported
  Introduce a separate controller for collection entropy config
  Add `card_id` to index
  Move to scope and inline method
  Prefer modern syntax
  Fix that stage should be visible above card background
  Indicate opens menu
  Hide dialog targets from screen readers when closed
  ...

# Conflicts:
#	db/schema.rb
#	db/schema_cache.yml
2025-07-03 16:11:00 +02:00
Mike Dalessio b667c1f9cd PWS manifest uses paths and not URLs 2025-07-03 10:10:03 -04:00
Mike Dalessio a268a5f00b Merge pull request #697 from basecamp/flavorjones/fix-pwa
Fix the PWA manifest to use slugged URLs
2025-07-03 10:05:46 -04:00
Jorge Manrubia 5ccb69a8d4 Add filter pill for completed by
This is pending to de-duplicate and tidy up, will do separately
2025-07-03 14:38:28 +02:00
Jorge Manrubia ca4628b457 Add more tests and fix failing ones 2025-07-03 12:46:36 +02:00
Jorge Manrubia 11d2b005a2 Support trailing spaces in inserted commands 2025-07-03 09:57:01 +02:00
Jorge Manrubia 75a8316609 Disable attachments in the terminal 2025-07-03 09:35:38 +02:00
Mike Dalessio a565504113 Fix activity feed pagination to fetch on demand
Commit 01c642e6 restructured the page so that the "next page" link was
always in view, meaning the page always loaded the entire history.

Now we load the next day as the user scrolls to the bottom, as intended.
2025-07-03 01:36:21 -04:00
Mike Dalessio 59548ac7eb Fix the PWA manifest to use slugged URLs
ref: https://fizzy.37signals.com/5986089/collections/2/cards/991
2025-07-02 23:51:00 -04:00
Mike Dalessio ccf961dad2 Merge pull request #696 from basecamp/flavorjones/collection-workflow-save
Collection edit page uses turbo frames to avoid resetting the user access form
2025-07-02 22:28:51 -04:00
Mike Dalessio 4589360dd1 Collection publication edits render a turbo frame
so we don't disturb the rest of the edit page.
2025-07-02 22:25:09 -04:00
Mike Dalessio 0799ad050b Collection workflow edits render a turbo frame
so we don't disturb the rest of the edit page.
2025-07-02 22:24:49 -04:00
Mike Dalessio 263bc486ed Collection entropy config edits render a turbo frame
so we don't disturb the rest of the edit page.
2025-07-02 22:24:41 -04:00
Mike Dalessio 36727ba5ea Introduce a separate controller for collection entropy config
which opens the door to rendering turbo frames in the responses to
collection edits.
2025-07-02 17:41:29 -04:00
Andy Smith 4bc1b36d3d Clean up --hover variables 2025-07-02 16:14:34 -05:00
Jason Zimdars aff0a38b37 Move to scope and inline method 2025-07-02 16:14:25 -05:00
Jason Zimdars 25a33fb9c8 Merge branch 'main' into card-steps
* main: (22 commits)
  Fix that stage should be visible above card background
  Indicate opens menu
  Hide dialog targets from screen readers when closed
  Mark up as heading for screen reader navigation
  Copy for screen readers
  Don't hide the input so it's accessible to screen readers
  Point skip links to correct anchor, don't navigate with turbo
  There aren't any `li` children so just use `div`
  Use headings for screen reader navigation
  Use `h3` for individual cards in collection view
  Make collection title `h1` for screen reader navigation
  Esc should not propagate when closing dialogs
  squash! Remove session controller actions other than delete
  Screen reader: Use heading for comments navigation
  Remove the invitation codes for now
  Remove session controller actions other than delete
  Correct label for field
  Style
  Screen reader: De-duplicate links for each person in account settings
  Account.signal_account is no longer optional
  ...
2025-07-02 16:09:49 -05:00
Jason Zimdars a31637bac7 Merge branch 'main' into accessibility-improvments
* main:
  squash! Remove session controller actions other than delete
  Remove the invitation codes for now
  Remove session controller actions other than delete
  Account.signal_account is no longer optional
  Remove local authentication code
  Drop the password column from the users table.
2025-07-02 16:07:29 -05:00
Jason Zimdars 41e40b5444 Indicate opens menu 2025-07-02 15:57:39 -05:00
Jason Zimdars b8f58dc70b Mark up as heading for screen reader navigation 2025-07-02 15:34:32 -05:00
Jason Zimdars 6b4c32ef9f Copy for screen readers 2025-07-02 15:34:17 -05:00
Jason Zimdars ca70d47576 Copy edits 2025-07-02 15:08:58 -05:00
Jason Zimdars 10893b8fa2 Don't hide the input so it's accessible to screen readers 2025-07-02 15:02:37 -05:00