David Heinemeier Hansson
b8775d41f5
Inline perma to container partial
...
Reveals all the container elements and perma wasnt used elsewhere.
2025-04-17 16:06:28 +02:00
David Heinemeier Hansson
0e442ac0d0
Use card replacement for card updates too
2025-04-17 15:56:56 +02:00
David Heinemeier Hansson
461c104ac2
Extract helper method to keep partial at a uniform level of abstraction
2025-04-17 15:42:07 +02:00
David Heinemeier Hansson
63b2abe020
Remove duplicated conditional
2025-04-17 15:38:47 +02:00
David Heinemeier Hansson
b508a93aba
Style
2025-04-17 15:36:11 +02:00
David Heinemeier Hansson
182d1c934b
Note that we dont want to keep reloading these frames
2025-04-17 15:35:56 +02:00
David Heinemeier Hansson
ac9cbad4f9
I like this even better
2025-04-17 15:32:09 +02:00
David Heinemeier Hansson
62088b66d1
Suffix qualifier is unnnecessary
2025-04-17 15:30:55 +02:00
David Heinemeier Hansson
df1f623435
Group partials for container
2025-04-17 15:25:11 +02:00
David Heinemeier Hansson
b788ef1638
Match domain language
2025-04-17 15:23:40 +02:00
David Heinemeier Hansson
4dbd8205ce
Fix trailing space
2025-04-17 15:21:14 +02:00
David Heinemeier Hansson
7adbd8d634
Use card rerendering instead of redirects
2025-04-17 15:20:27 +02:00
David Heinemeier Hansson
d019e282ae
Better name
2025-04-17 15:00:14 +02:00
David Heinemeier Hansson
770029c26d
Stick with domain language
2025-04-17 14:59:15 +02:00
David Heinemeier Hansson
547e5ea24f
Rerender instead of redirect
2025-04-17 14:54:29 +02:00
David Heinemeier Hansson
ab1835294d
Style
2025-04-17 14:53:45 +02:00
David Heinemeier Hansson
f24287915f
Extract partials that can be rerendered
2025-04-17 14:52:35 +02:00
David Heinemeier Hansson
4d0dddec46
No need to loop through a job when this is the sole point of the action
2025-04-17 14:31:28 +02:00
David Heinemeier Hansson
87ce4a623b
Even clearer about where these pins are going
2025-04-17 14:31:02 +02:00
David Heinemeier Hansson
1437bcb3b7
Clearer about where these are being sent
2025-04-17 14:29:12 +02:00
David Heinemeier Hansson
8fe8241069
Reuse create template
2025-04-17 14:14:08 +02:00
David Heinemeier Hansson
bddd624e41
Match template name to container id
2025-04-17 14:14:03 +02:00
David Heinemeier Hansson
fc0cf3917f
Pin without redirect
...
Use turbo stream response to save on the redirect latency
2025-04-17 14:05:26 +02:00
David Heinemeier Hansson
07e801b74c
Fix pinning to tray
...
They need to have a complete dom element that is unique
2025-04-17 13:52:55 +02:00
David Heinemeier Hansson
0c743d27a8
There is no more/less flicker with morphing
...
Where did you see the flickering that this solved, @jorgemanrubia?
2025-04-17 13:42:49 +02:00
David Heinemeier Hansson
b5d6d40462
Use domain language termn
2025-04-17 13:42:23 +02:00
David Heinemeier Hansson
bf99da8914
Style
2025-04-17 13:33:45 +02:00
David Heinemeier Hansson
a5de4863fa
Allow for multiple notifications to be read
...
cc @kevinmcconnell
2025-04-17 11:39:37 +02:00
Kevin McConnell
6c8fe164b3
Read a card should dismiss all notifications
...
Previous code assumed that there was a single notification to dismiss
for that card, but in practice there can be zero or many. If it's zero,
we need to avoid the crash. If it's many, we should dismiss them all.
Also re-rendering the notification stack after dismissing enables us to
remove all the removed cards, as well as reveal any older ones that were
previously outside the visible page size.
This reverts commit 6135909b7e .
2025-04-17 09:40:59 +01:00
Jason Zimdars
68d1c3cce5
Merge branch 'main' into add-card-description
...
* main:
Fix close card notch state
Add fizzy-app-102 as a replica
2025-04-16 19:09:45 -05:00
Jason Zimdars
94ccbdb601
Fix close card notch state
2025-04-16 19:06:18 -05:00
Jason Zimdars
47d0ae98a1
Remove DraftCommenting
2025-04-16 19:01:21 -05:00
Jason Zimdars
d257cb5fb6
No longer used
2025-04-16 18:57:47 -05:00
Jason Zimdars
7b3b5c471b
Add a description filed for cards
2025-04-16 18:53:26 -05:00
Jason Zimdars
b5090c4b21
Copy edit
2025-04-16 10:39:24 -05:00
Jason Zimdars
00dd312cd6
Change alignment
2025-04-16 10:39:24 -05:00
Jason Zimdars
beae3d9a6b
Clearer assignment icon
2025-04-16 10:39:24 -05:00
Jason Zimdars
5c4c06d74c
No longer used
2025-04-16 10:39:24 -05:00
Andy Smith
5eccad2659
Pluralize "Day"
2025-04-16 10:23:58 -05:00
Andy Smith
5ccff34e6b
Add Closes Today styles
2025-04-16 10:20:16 -05:00
Andy Smith
6fb69294a3
Smaller badge size
2025-04-16 10:14:24 -05:00
David Heinemeier Hansson
7c5a58bf4d
Note that this need to be able to dynamically appear
2025-04-16 17:12:31 +02:00
David Heinemeier Hansson
5dc6e0394f
Style
2025-04-16 17:12:20 +02:00
David Heinemeier Hansson
00cbe8101c
Slim it down
2025-04-16 17:07:43 +02:00
David Heinemeier Hansson
cfa2f2d1f9
Trailing spaces
2025-04-16 17:02:48 +02:00
David Heinemeier Hansson
2ced8e643d
Clarify a bit
2025-04-16 17:01:32 +02:00
David Heinemeier Hansson
d8ec2c3364
More natural to fetch that which will be shown first
2025-04-16 16:58:03 +02:00
David Heinemeier Hansson
5ce289642f
Rely on caching of notifications
2025-04-16 16:57:54 +02:00
David Heinemeier Hansson
6135909b7e
Card readings just need to remove the notification
...
No need to broadcast everything again
2025-04-16 16:51:18 +02:00
Andy Smith
7f944b601f
Remove unused DaysUntilFormatter
2025-04-16 09:49:42 -05:00