David Heinemeier Hansson
c463f342bf
Ensure user is returned
2025-04-12 20:30:28 +02:00
David Heinemeier Hansson
a579e67057
We are not using the parameter
2025-04-12 20:08:42 +02:00
David Heinemeier Hansson
6bbf68a4f9
The tenanted db is the account scope
2025-04-12 20:06:34 +02:00
David Heinemeier Hansson
760cbb6c99
Drop boosts
...
Killed by design.
2025-04-12 18:52:54 +02:00
David Heinemeier Hansson
1b732c41c7
Use render svg
2025-04-12 18:15:05 +02:00
David Heinemeier Hansson
120e8da1d5
Unused
2025-04-12 14:14:34 +02:00
David Heinemeier Hansson
4723b7b504
Style
2025-04-12 14:13:20 +02:00
David Heinemeier Hansson
d3c5c86b21
Style
2025-04-12 14:06:11 +02:00
David Heinemeier Hansson
a9c6f8bceb
No reuse likely
2025-04-12 13:51:47 +02:00
David Heinemeier Hansson
b36b2f04a9
Too clever to have the redirect_to directly on the factory method return
2025-04-12 13:49:23 +02:00
David Heinemeier Hansson
19c537af64
Inline anemic method
2025-04-12 13:48:03 +02:00
David Heinemeier Hansson
1a70be06c6
Fix trailing CR
2025-04-12 13:37:31 +02:00
David Heinemeier Hansson
706178f3c4
Better naming
2025-04-12 13:33:54 +02:00
David Heinemeier Hansson
d4a31fec6d
Dont overload the main transaction
...
Even if we are going to get rid of this cleanup_events stuff.
2025-04-12 13:33:06 +02:00
David Heinemeier Hansson
2357c75063
Reads better with a verb first
2025-04-12 13:09:49 +02:00
David Heinemeier Hansson
e8a839d5f6
We have a callback dependency to do this actually
2025-04-12 11:47:08 +02:00
David Heinemeier Hansson
0031ce34ea
Correct order
2025-04-12 11:46:17 +02:00
David Heinemeier Hansson
e4efe446e6
Simlpe callback is actually enough
...
Since the Comment already knows about the card.
2025-04-12 11:45:34 +02:00
David Heinemeier Hansson
f2c2b0492e
Have to solve this in an overhaul of events
2025-04-12 11:42:50 +02:00
David Heinemeier Hansson
f5b30456a0
Comments arent part of event summaries any more
2025-04-12 11:42:41 +02:00
David Heinemeier Hansson
e75d2bcaa1
Scopes last
2025-04-12 11:37:39 +02:00
David Heinemeier Hansson
d8f9511e08
Unused
2025-04-12 11:34:56 +02:00
David Heinemeier Hansson
1a9a65fffb
Unused
2025-04-12 11:31:50 +02:00
David Heinemeier Hansson
2f8a9bed0e
There is only ever one account per database
...
So there is no protection in scoping things by account cc @jorgemanrubia
2025-04-12 11:30:28 +02:00
David Heinemeier Hansson
9359cac330
Style
2025-04-12 11:24:02 +02:00
David Heinemeier Hansson
b2b9c99745
Style
2025-04-12 11:23:48 +02:00
David Heinemeier Hansson
81a89dbda1
Comments should always have messages
2025-04-12 11:23:45 +02:00
David Heinemeier Hansson
b8c3ac8145
Cache busting should happen as a comment in the partial, not as an actual key component
2025-04-12 11:22:31 +02:00
David Heinemeier Hansson
cef8899bda
Comments are not currently used as notifiables
2025-04-12 11:18:59 +02:00
David Heinemeier Hansson
9f1c3ae046
Note my discontent
2025-04-12 11:17:01 +02:00
David Heinemeier Hansson
1c4e0d3ccc
Not using the destroy callback
2025-04-12 11:11:30 +02:00
David Heinemeier Hansson
63c05220ce
Clearer naming
2025-04-12 11:09:55 +02:00
David Heinemeier Hansson
ecffdc2af4
Spacing
2025-04-12 11:07:27 +02:00
David Heinemeier Hansson
735a12abfc
Better name
2025-04-12 11:07:02 +02:00
David Heinemeier Hansson
9f7bbbef58
Split draft commenting back out to a dedicated concern
2025-04-12 11:05:56 +02:00
David Heinemeier Hansson
27d90abbd6
Reduce the direct knowledge of comments inside the card
2025-04-12 11:04:16 +02:00
David Heinemeier Hansson
b698eefa06
Messageables already have access to the card
2025-04-12 11:00:15 +02:00
David Heinemeier Hansson
24b02c42fd
Comments are dependents of messages, so need to destroy the latter to get the former
2025-04-12 10:59:59 +02:00
David Heinemeier Hansson
60a0360203
Remove more activity scoring related to comments
2025-04-12 10:52:48 +02:00
David Heinemeier Hansson
fb733b9a60
No more tracking commenting as an activity for sorting
...
We are doing away with all the automated activity scoring, but for now
lets just get rid of it for comments.
2025-04-12 10:50:25 +02:00
David Heinemeier Hansson
81f431d946
Comment-specific behavior needs to live in the comment
...
This really is a bit of a tangled mess. Everyone knows everything about
everyone else.
2025-04-12 10:39:56 +02:00
David Heinemeier Hansson
bb64adfd1b
Most important methods first
2025-04-12 10:39:19 +02:00
David Heinemeier Hansson
4d2ba5b432
Use the explicit method for now
2025-04-12 10:27:57 +02:00
David Heinemeier Hansson
80bc1dd163
Reactions dont have any callbacks so can just be deleted
2025-04-12 10:15:38 +02:00
David Heinemeier Hansson
6f3ac772ea
Merge branch 'main' into comments-refactoring
...
* main:
Show more of the summary before truncating
Improve event summaries
Add this for debugging empty event cards
Some actions shouldn't be available to closed cards
Nicer spacing when the large button isn't present
Update `card-color` in a couple more places
Don't show the engagement toggle on closed cards
Show more of the summary before truncating
Improve event summaries
Remove shadows from notifications you can't see
Add this for debugging empty event cards
Some actions shouldn't be available to closed cards
Nicer spacing when the large button isn't present
Update `card-color` in a couple more places
Don't show the engagement toggle on closed cards
Style drafted cards
Considering needs to include drafted cards or you'll never be able to see them
This item makes no sense until it's saved
Tighten engagement switch design, only display it for published cards
2025-04-12 09:56:28 +02:00
Andy Smith
f60ce4f7a6
Fix notch padding
2025-04-11 16:40:54 -05:00
Andy Smith
47974b5e3b
Fix failing pin test
2025-04-11 16:14:56 -05:00
Andy Smith
dc474627cb
Add padding to message when closed
2025-04-11 16:11:28 -05:00
Andy Smith
019c16b3e3
Fix issues after merge
2025-04-11 16:09:44 -05:00
Andy Smith
11ecc5d489
Merge in latest from main
2025-04-11 15:39:07 -05:00