Commit Graph

5512 Commits

Author SHA1 Message Date
Jose Farias 4a382b535a Merge pull request #131 from basecamp/new-filters
New filtering UI
2024-11-13 14:32:21 -06:00
Jose Farias a2092efc0a Add assigners to filter summary 2024-11-13 14:27:23 -06:00
Jose Farias 058c10d89f Use Current.user's name for filter chips
It'll use the name anyway (instead of "me") when re-rendering the perma after navigating.
2024-11-13 14:02:41 -06:00
Jose Farias cc2b799b1c Allow assigner ids param 2024-11-13 14:01:31 -06:00
Jose Farias 33d1f7f022 Sort filter params before hashing
So that param order doesn't matter
2024-11-13 13:55:46 -06:00
Jose Farias 4dfba46142 Fix tests 2024-11-13 13:55:30 -06:00
Jose Farias af1aa3fd62 Test field accessors 2024-11-13 13:51:54 -06:00
Jose Farias bef8882490 Test filter chips controller 2024-11-13 13:44:33 -06:00
Jose Farias a3fb92d506 Test filter terms 2024-11-13 13:39:04 -06:00
Jose Farias 458a6a1ac2 Wire up assigner filters 2024-11-13 13:34:51 -06:00
Jose Farias 72ddd18bcc Spell out button_to params 2024-11-13 13:23:12 -06:00
Jason Zimdars e9ada829fc Flip them back 2024-11-13 13:12:09 -06:00
Jason Zimdars eee2f8d516 Revert "Not using this after all"
This reverts commit 4137930616.
2024-11-13 12:51:34 -06:00
Jose Farias 768b48ea03 Use Filter class method to digest fixture params 2024-11-13 12:08:23 -06:00
Jason Zimdars 4137930616 Not using this after all 2024-11-12 21:00:23 -06:00
Jason Zimdars 619dcc171c Use turbo frame for assignments 2024-11-12 20:50:17 -06:00
Jason Zimdars 3da6f954dd Use turbo frame for due dates 2024-11-12 20:23:46 -06:00
Jose Farias 8301db767a Add frame to search terms form 2024-11-12 20:20:38 -06:00
Jose Farias ec16237bf4 Render each kind of filter in its own frame 2024-11-12 19:58:19 -06:00
Jose Farias d77eafe012 button -> chip 2024-11-12 19:26:21 -06:00
Jose Farias ea1fb674d9 No need to apply terms from the controller anymore 2024-11-12 19:24:51 -06:00
Jose Farias 932fc341ce Add terms to filter 2024-11-12 19:14:40 -06:00
Jose Farias 8bc89d497c buttons -> chips 2024-11-12 18:55:35 -06:00
Jose Farias e399702217 Clean up Filter class methods 2024-11-12 16:36:59 -06:00
Jose Farias e53df951f2 KNOWN_PARAMS -> PERMITTED_PARAMS 2024-11-12 16:36:38 -06:00
Jason Zimdars 143008cfa1 Render with a helper 2024-11-12 15:28:20 -06:00
Jason Zimdars bcde27c4d1 New grid layout and addition of features menu 2024-11-12 15:26:16 -06:00
Jose Farias 6384d5eb0e Remove most_active as index option 2024-11-11 17:29:16 -06:00
Jason Zimdars adf98d61b8 Fix styles regression 2024-11-11 17:15:52 -06:00
Jose Farias 3b513fc726 Wire up search 2024-11-11 15:40:10 -06:00
Jose Farias 9e99d961ba Iron out quirks from navigating back and forth 2024-11-11 15:05:54 -06:00
Jose Farias eff8539b66 Fix test 2024-11-11 14:23:00 -06:00
Jose Farias 2d422d7bff Merge branch 'main' into new-filters
* main:
  Simplify
  Another round of design on the stage picker UI
2024-11-11 13:46:25 -06:00
Jose Farias 0baaf5d87f Wire up filter form sans search 2024-11-11 13:46:15 -06:00
Jose Farias d455b72906 Hash filter params 2024-11-08 15:17:55 -06:00
Jason Zimdars 171922a9b7 Simplify 2024-11-08 10:33:09 -06:00
Jason Zimdars 110d2a30b7 Another round of design on the stage picker UI 2024-11-07 22:11:08 -06:00
Jose Farias b1570e34ed Remove unused files 2024-11-07 17:05:19 -06:00
Jose Farias 3db6e230c9 Update links to use new system 2024-11-07 17:03:52 -06:00
Jose Farias 1383766cd8 Merge branch 'main' into new-filters
* main: (24 commits)
  Increase filter tests specificity
  Add some more tests for bubble filters
  Simplify filter destruction
  Add derived_params alias
  Split out `fields` and `params` for filters
  exists? -> any?
  Assert params after resource removal
  Put includes on the same line
  Comment on the query merger controller
  Test param sanitization
  Sanitize params after initialization
  Unnecessary parens
  Improve denormalized filters note
  idempotent_create -> persist
  Pull out `strip_default_params`
  Update denormalization comment
  Unnecessary newline
  No need to set resources in `to_params` anymore
  Delegate default_params to class
  Add tests
  ...
2024-11-07 16:55:00 -06:00
Jose Farias 75d2b793a3 Increase filter tests specificity 2024-11-07 16:52:49 -06:00
Jose Farias 6b3d7e7274 Merge pull request #130 from basecamp/unnested-filters
Unnest bubble filters
2024-11-07 16:15:41 -06:00
Jose Farias da37fa56d8 Add some more tests for bubble filters 2024-11-07 16:13:00 -06:00
Jose Farias 5cc4aa0634 Simplify filter destruction 2024-11-07 16:09:12 -06:00
Jose Farias aca9a69ce1 Add derived_params alias 2024-11-07 12:48:27 -06:00
Jose Farias 77a9b267d8 Split out fields and params for filters 2024-11-07 12:44:26 -06:00
Jose Farias fb08ff394d exists? -> any? 2024-11-07 11:35:26 -06:00
Jose Farias 201a543a9b Assert params after resource removal 2024-11-07 11:34:56 -06:00
Jose Farias 8f17152108 Put includes on the same line 2024-11-07 11:32:44 -06:00
Jose Farias 4c02a46867 Comment on the query merger controller 2024-11-07 11:32:21 -06:00