Andy Smith
806fc9958b
Merge pull request #716 from basecamp/hide-focus-rings-on-cards
...
Hide focus ring on new card titles and step inputs
2025-07-07 13:25:38 -05:00
Andy Smith
6e2eacd3d8
Hide focus ring on new card titles and step inputs
2025-07-07 13:23:19 -05:00
Andy Smith
26e89f8cec
Merge pull request #715 from basecamp/comment-btn-hover
...
Add hover effect to overflow button
2025-07-07 10:14:22 -05:00
Andy Smith
f9c7862fc1
Add hover effect for comment edit button
2025-07-07 10:12:32 -05:00
Andy Smith
95dac275fd
Add hover effect to overflow button
2025-07-07 10:07:56 -05:00
Andy Smith
84d5f64d1f
Merge pull request #695 from basecamp/focus-hover-styles
...
Focus hover styles
2025-07-07 09:49:08 -05:00
Mike Dalessio
402a918031
Merge pull request #714 from basecamp/flavorjones/tenanted-pwa-manifest
...
Improve multi-account behavior of the PWA
2025-07-05 13:09:12 -04:00
Mike Dalessio
e3c1e2c00a
Improve multi-account behavior of the PWA
...
- PWA manifest:
- declares slugged scope
- includes the account name (and non-prod environment name) in the title
So we can have one PWA installed for each account (in each
environment) and links should get routed properly.
ref: https://3.basecamp.com/2914079/buckets/37331921/todos/8827769164
2025-07-05 13:05:08 -04:00
Jorge Manrubia
88074cc7ed
Remove unneeded *
2025-07-04 21:57:18 +02:00
Jorge Manrubia
3167126bda
Rename test
2025-07-04 20:03:59 +02:00
Jorge Manrubia
34c25812a1
Merge pull request #713 from basecamp/move-collections
...
Review the code to move cards
2025-07-04 19:57:27 +02:00
Jorge Manrubia
919211244b
Review the code to move cards
...
- Scope accessed records
- Keep consistency by moving events too
2025-07-04 19:56:48 +02:00
Jorge Manrubia
3eadd5db41
Update editor
2025-07-04 19:18:59 +02:00
Jorge Manrubia
3071782aa8
Merge pull request #712 from basecamp/collections-consistency
...
Remove notifications/mentions when losing access to collection
2025-07-04 19:10:36 +02:00
Jorge Manrubia
3fb3e5b48e
Generalize and delete mentions too
2025-07-04 19:08:29 +02:00
Jorge Manrubia
cbeefc5b74
Remove unused code
2025-07-04 19:00:22 +02:00
Jorge Manrubia
9e0d668348
Make sure we don't remove accesses if collection is accessible
2025-07-04 18:56:30 +02:00
Jorge Manrubia
c621cc6cc9
Destroy notifications when losing access to collection
2025-07-04 18:52:29 +02:00
Jorge Manrubia
b8b4ef5463
Extract common concern to examine attachments
2025-07-04 17:53:37 +02:00
Jorge Manrubia
0191eb85dc
Merge branch 'main' into card-attachments
...
* main:
Don't create mentions from drafts until those are published
Change Active Storage account slug extension to a to_prepare block
dep: bump actiontext-lexical for previewable attachment fix
Add assertion for composite command line
Remove trace
restore the right command
Update action text
The prompt confirmation system wasn't really working after moving to lexical
Parse commands where it's just a gid properly
Move inside concerns or the override won't work
Truncation for comment author line
Avoid duplicated queries and, instead, bump the last ones
Adjust screen for screen readers
Adjust icon sizing and uploading styles
2025-07-04 17:38:27 +02:00
Jorge Manrubia
ec0c019967
Merge pull request #711 from basecamp/mentionable-published
...
Don't create mentions from drafts until those are published
2025-07-04 17:28:19 +02:00
Jorge Manrubia
b9f7634457
Merge pull request #706 from basecamp/duplicated-seraches
...
Avoid duplicated queries and, instead, bump the last ones
2025-07-04 17:28:15 +02:00
Jorge Manrubia
17f9df8df3
Don't create mentions from drafts until those are published
...
https://fizzy.37signals.com/5986089/collections/2/cards/982
2025-07-04 17:25:39 +02:00
Jason Zimdars
2f1f45c1c7
Merge branch 'main' into jz-7-3-25-pm
...
* main:
Change Active Storage account slug extension to a to_prepare block
dep: bump actiontext-lexical for previewable attachment fix
Add assertion for composite command line
Remove trace
restore the right command
Update action text
The prompt confirmation system wasn't really working after moving to lexical
Parse commands where it's just a gid properly
Move inside concerns or the override won't work
2025-07-03 19:24:56 -05:00
Mike Dalessio
ec5f7b1efa
Merge pull request #710 from basecamp/flavorjones/fix-attach-after-reload
...
Change Active Storage account slug extension to a to_prepare block
2025-07-03 19:02:23 -04:00
Mike Dalessio
05984845ca
Change Active Storage account slug extension to a to_prepare block
...
because it was breaking in development after a reload.
2025-07-03 19:01:03 -04:00
Mike Dalessio
abb4046f0f
Merge pull request #709 from basecamp/flavorjones/lexical-bump-for-previewable-attachments
...
dep: bump actiontext-lexical for previewable attachment fix
2025-07-03 18:37:03 -04:00
Mike Dalessio
93f9e93239
dep: bump actiontext-lexical for previewable attachment fix
...
ref: https://fizzy.37signals.com/5986089/collections/2/cards/1004
2025-07-03 18:35:53 -04:00
Jorge Manrubia
fc2e7597f0
Merge pull request #708 from basecamp/commandline-issues
...
More prompt fixes
2025-07-04 00:09:22 +02:00
Jorge Manrubia
68277183e3
Add assertion for composite command line
2025-07-04 00:08:47 +02:00
Jorge Manrubia
3ed7c940d9
Remove trace
2025-07-04 00:07:03 +02:00
Jason Zimdars
f1fe0ade1d
Merge branch 'main' into jz-7-3-25-pm
...
* main:
Store the normalized line not the raw line!
Always resolve rich text commands
2025-07-03 17:06:27 -05:00
Jorge Manrubia
2cd8df4975
restore the right command
2025-07-04 00:05:52 +02:00
Jorge Manrubia
5c68dac4d5
Update action text
2025-07-04 00:05:39 +02:00
Jason Zimdars
132059e77a
This is a hack but we should be showing the card description and attachments for new cards
2025-07-03 16:54:26 -05:00
Jason Zimdars
0539d366d7
Display attachments in events for comments
2025-07-03 16:48:43 -05:00
Jorge Manrubia
809d23245f
The prompt confirmation system wasn't really working after moving to lexical
...
The async value setting was biting us here
2025-07-03 23:29:36 +02:00
Jorge Manrubia
c134df1bb8
Parse commands where it's just a gid properly
2025-07-03 23:10:19 +02:00
Jorge Manrubia
994560c1b7
Move inside concerns or the override won't work
2025-07-03 23:06:37 +02:00
Jason Zimdars
cf4c6dba9c
Indicate cards with attachments in the description
2025-07-03 15:56:25 -05:00
Jorge Manrubia
8071c7b522
Store the normalized line not the raw line!
2025-07-03 22:40:16 +02:00
Jorge Manrubia
fd418b123e
Always resolve rich text commands
...
I don't remember why I added this but we don't really need it. Also, this result
in potential ambiguity even when you use prompts for standalone tags and mentions
2025-07-03 22:21:50 +02:00
Andy Smith
757ff4ff2b
Merge branch 'main' into focus-hover-styles
2025-07-03 15:14:14 -05:00
Jason Zimdars
8f42086703
Truncation for comment author line
2025-07-03 15:06:15 -05:00
Andy Smith
5c2997422f
Address PR feedback
2025-07-03 15:00:12 -05:00
Jorge Manrubia
fef9e74503
Avoid duplicated queries and, instead, bump the last ones
2025-07-03 21:52:58 +02:00
Jason Zimdars
5d34cb3f51
Adjust screen for screen readers
2025-07-03 14:37:31 -05:00
Jason Zimdars
512cd32b2d
Adjust icon sizing and uploading styles
2025-07-03 14:36:15 -05:00
Jorge Manrubia
020c99fc99
Update editor
2025-07-03 19:57:29 +02:00
Jorge Manrubia
26cb727e0c
Update editor
2025-07-03 19:55:55 +02:00