Commit Graph

5512 Commits

Author SHA1 Message Date
Mike Dalessio 31007c7bdb Create a "published" event if a card is created published
This isn't the normal workflow in the app, but this problem will show
up if we create cards programmatically (e.g., the seeds)
2025-07-03 01:08:53 -04:00
Mike Dalessio a0d506435f Scatter Honcho seeds over a 30 day period
to make the activity page look a bit more realistic
2025-07-03 01:08:03 -04:00
Mike Dalessio 59548ac7eb Fix the PWA manifest to use slugged URLs
ref: https://fizzy.37signals.com/5986089/collections/2/cards/991
2025-07-02 23:51:00 -04:00
Mike Dalessio ccf961dad2 Merge pull request #696 from basecamp/flavorjones/collection-workflow-save
Collection edit page uses turbo frames to avoid resetting the user access form
2025-07-02 22:28:51 -04:00
Mike Dalessio 4589360dd1 Collection publication edits render a turbo frame
so we don't disturb the rest of the edit page.
2025-07-02 22:25:09 -04:00
Mike Dalessio 0799ad050b Collection workflow edits render a turbo frame
so we don't disturb the rest of the edit page.
2025-07-02 22:24:49 -04:00
Mike Dalessio 263bc486ed Collection entropy config edits render a turbo frame
so we don't disturb the rest of the edit page.
2025-07-02 22:24:41 -04:00
Jason Zimdars 77a7509896 Merge pull request #689 from basecamp/card-steps
Add steps to cards
2025-07-02 17:27:23 -05:00
Jason Zimdars 462878630e Use automatic sizing where supported 2025-07-02 16:42:27 -05:00
Mike Dalessio 36727ba5ea Introduce a separate controller for collection entropy config
which opens the door to rendering turbo frames in the responses to
collection edits.
2025-07-02 17:41:29 -04:00
Andy Smith a2f9339cdb Remove unused --outline vars 2025-07-02 16:40:59 -05:00
Jason Zimdars 16535db20e Add card_id to index 2025-07-02 16:23:37 -05:00
Andy Smith 7c30fd6674 Focus ring for collection select 2025-07-02 16:18:12 -05:00
Andy Smith a07c827cdf Clarify comment 2025-07-02 16:15:16 -05:00
Andy Smith 4bc1b36d3d Clean up --hover variables 2025-07-02 16:14:34 -05:00
Jason Zimdars aff0a38b37 Move to scope and inline method 2025-07-02 16:14:25 -05:00
Jason Zimdars 27aaa815c7 Prefer modern syntax 2025-07-02 16:12:37 -05:00
Jason Zimdars 25a33fb9c8 Merge branch 'main' into card-steps
* main: (22 commits)
  Fix that stage should be visible above card background
  Indicate opens menu
  Hide dialog targets from screen readers when closed
  Mark up as heading for screen reader navigation
  Copy for screen readers
  Don't hide the input so it's accessible to screen readers
  Point skip links to correct anchor, don't navigate with turbo
  There aren't any `li` children so just use `div`
  Use headings for screen reader navigation
  Use `h3` for individual cards in collection view
  Make collection title `h1` for screen reader navigation
  Esc should not propagate when closing dialogs
  squash! Remove session controller actions other than delete
  Screen reader: Use heading for comments navigation
  Remove the invitation codes for now
  Remove session controller actions other than delete
  Correct label for field
  Style
  Screen reader: De-duplicate links for each person in account settings
  Account.signal_account is no longer optional
  ...
2025-07-02 16:09:49 -05:00
Jorge Manrubia 15eb09a1fe Close should show up before than clear for "cl" 2025-07-02 23:08:52 +02:00
Jason Zimdars a31637bac7 Merge branch 'main' into accessibility-improvments
* main:
  squash! Remove session controller actions other than delete
  Remove the invitation codes for now
  Remove session controller actions other than delete
  Account.signal_account is no longer optional
  Remove local authentication code
  Drop the password column from the users table.
2025-07-02 16:07:29 -05:00
Jason Zimdars f623f6fea8 Fix that stage should be visible above card background 2025-07-02 16:06:22 -05:00
Jorge Manrubia 0c4baed8a4 Show help menu without introducing newlines after updating lexical 2025-07-02 23:03:38 +02:00
Jason Zimdars 41e40b5444 Indicate opens menu 2025-07-02 15:57:39 -05:00
Jason Zimdars 86e6309735 Hide dialog targets from screen readers when closed 2025-07-02 15:57:30 -05:00
Mike Dalessio 2377770ef6 Stay on the collection edit page after changing workflow
ref: https://fizzy.37signals.com/5986089/collections/2/cards/852
2025-07-02 16:53:53 -04:00
Jorge Manrubia 7913513826 Reset after entering help command 2025-07-02 22:35:52 +02:00
Jason Zimdars b8f58dc70b Mark up as heading for screen reader navigation 2025-07-02 15:34:32 -05:00
Jason Zimdars 6b4c32ef9f Copy for screen readers 2025-07-02 15:34:17 -05:00
Jorge Manrubia b469caca33 Add command to show help menu
cc @jzimdars
2025-07-02 22:25:57 +02:00
Jason Zimdars ca70d47576 Copy edits 2025-07-02 15:08:58 -05:00
Jason Zimdars 10893b8fa2 Don't hide the input so it's accessible to screen readers 2025-07-02 15:02:37 -05:00
Jorge Manrubia 33768757db Don't submit on /help command 2025-07-02 21:59:53 +02:00
Jorge Manrubia 8330bb25fc Support help command 2025-07-02 21:55:13 +02:00
Jason Zimdars 6504813b4a Point skip links to correct anchor, don't navigate with turbo 2025-07-02 14:53:47 -05:00
Jason Zimdars 46093caeb8 There aren't any li children so just use div 2025-07-02 14:52:10 -05:00
Andy Smith 4c42b8fe15 Merge branch 'main' into focus-hover-styles
* main: (21 commits)
  squash! Remove session controller actions other than delete
  Remove the invitation codes for now
  Remove session controller actions other than delete
  Account.signal_account is no longer optional
  Remove local authentication code
  Drop the password column from the users table.
  Script to create Users for existing 37id accounts
  Configure Mission Control to skip tenanted authentication
  Script to update URLs and attachments in cards and comments
  Make sure seeds are creating sluggable tenants
  Script to rename tenants after the QB account id
  Update the signups tests to work with untenanted paths
  Update the Command classes to handle paths with account slugs
  Update bin/dev to point at the new tenant URLs
  Patch Active Storage controllers to generate slugged URLs
  Point Action Cable at the slugged cable endpoint
  Extract pieces from the tenanting initializer
  Patch Turbo to use the request script name
  Use the new AR::Tenanted convention for action cable connections
  Use a tenant resolver that recognizes the account slug
  ...
2025-07-02 14:51:45 -05:00
Jorge Manrubia b0e35bcd54 Remove trace 2025-07-02 21:51:42 +02:00
Jason Zimdars c19e5a6253 Use headings for screen reader navigation 2025-07-02 14:46:43 -05:00
Jason Zimdars 70d6a7190f Use h3 for individual cards in collection view 2025-07-02 14:42:53 -05:00
Jason Zimdars db99e5928c Make collection title h1 for screen reader navigation 2025-07-02 14:38:29 -05:00
Jason Zimdars 985337a91c Esc should not propagate when closing dialogs 2025-07-02 14:29:15 -05:00
Jorge Manrubia ccdaec4721 Include command in the search string 2025-07-02 21:27:47 +02:00
Mike Dalessio b99b80bc3d Merge pull request #690 from basecamp/flavorjones/cleanup-20250702
Cleanup after moving beta into a datacenter
2025-07-02 15:27:01 -04:00
Jorge Manrubia ddb0470480 Format 2025-07-02 21:26:24 +02:00
Jorge Manrubia cee3925057 Add all commands 2025-07-02 21:26:10 +02:00
Mike Dalessio 4537037a4c squash! Remove session controller actions other than delete 2025-07-02 15:23:59 -04:00
Jason Zimdars 91aa8be4fc Screen reader: Use heading for comments navigation 2025-07-02 14:22:16 -05:00
Mike Dalessio 7f1b384425 Remove the invitation codes for now
until I circle back for https://3.basecamp.com/2914079/buckets/37331921/todos/8746162337
2025-07-02 15:15:05 -04:00
Mike Dalessio fa1c5f7279 Remove session controller actions other than delete
and do some general cleanup around sessions controllers and the
sign_in_as test helper
2025-07-02 15:03:28 -04:00
Jason Zimdars 08043a7c5e Correct label for field 2025-07-02 14:01:10 -05:00