Commit Graph

7114 Commits

Author SHA1 Message Date
Mike Dalessio 8ce97e85b2 Merge pull request #1652 from basecamp/flavorjones/3062-draft-card-creation-time
Change "ADDED" to "DRAFTED" when rendering draft cards
2025-11-20 12:17:30 -05:00
Andy Smith 3469965f7a Merge pull request #1644 from basecamp/fix-too-large-filters
Remove special Safari hack
2025-11-20 10:48:22 -06:00
Stanko Krtalić c33802d37b Fix attachemnts (#1627)
* Load keys from tenanted dbs

* Implement sgid swapping

* Fix sgid generation

* Flip the logic to do lookups by tenant and id

* Create missing blobs

* Copy over variations

* fix-active-storage-links: fix mentions

* Fix variant generation

* Fix avatars

* Fix avatars

---------

Co-authored-by: Mike Dalessio <mike@37signals.com>
2025-11-20 11:47:49 -05:00
Jason Zimdars fd3b32fd15 Merge pull request #1643 from basecamp/account-to-cache-key
Add `Current.account` to cache key
2025-11-20 10:27:59 -06:00
Mike Dalessio 7ba4d7ed73 Merge pull request #1653 from basecamp/flavorjones/claude-md
Add a CLAUDE.md and a STYLE.md
2025-11-20 11:18:15 -05:00
Mike Dalessio 7ef7a8e49b Add a CLAUDE.md and a STYLE.md
The CLAUDE.md file is a stripped-down version of a file originally
generated by Claude.

The STYLE.md file is inspired by an internal 37signals style guide.
2025-11-20 10:20:02 -05:00
Mike Dalessio 71f2ffbf59 Change "ADDED" to "DRAFTED" when rendering draft cards
ref: https://app.fizzy.do/5986089/cards/3062
2025-11-20 09:32:42 -05:00
Stanko Krtalić 4217984f1b Merge pull request #1651 from basecamp/add-retries-to-activestorage-analzejob
Retry file analisys on FileNotFoundError
2025-11-20 15:27:25 +01:00
Mike Dalessio 88750a3498 Prefer Time.current to Time.now 2025-11-20 09:13:17 -05:00
Stanko K.R. e8a7b19647 Retry file analisys on FileNotFoundError 2025-11-20 15:09:43 +01:00
Stanko Krtalić f6cfb5fde4 Merge pull request #1648 from basecamp/fix-user-avatars-in-notification-bundles
Fix missing avatars in notification bundle emails
2025-11-20 11:19:13 +01:00
Stanko K.R. 8a1cbdd0ae Fix links in previews 2025-11-20 10:49:29 +01:00
Kevin McConnell 5aa960b243 Merge pull request #1649 from basecamp/switch-accounts-in-same-window
Don't open account links in new window
2025-11-20 09:45:23 +00:00
Kevin McConnell 4fc85883ee Don't open account links in new window
This allows switching account in-place inside the same PWA or browser
tab.
2025-11-20 09:36:18 +00:00
Stanko K.R. cc41a42221 Fix missing avatars in notification bundle emails 2025-11-20 10:33:42 +01:00
Kevin McConnell e37038c0a6 Merge pull request #1647 from basecamp/avoid-notification-deadlocks
Process notification recipients in consistent order
2025-11-20 09:27:57 +00:00
Kevin McConnell bc73cf692d Process notification recipients in consistent order
We've seen some cases of deadlock when processing notifications, because
locks are gathered on the users in different orders. Let's try sticking
to a consistent order instead, which should cause the jobs to serialize
rather than deadlock.
2025-11-20 09:20:48 +00:00
Mike Dalessio 19d8e41b38 Merge pull request #1646 from basecamp/flavorjones/improve-search-results
Improve search results
2025-11-19 18:09:18 -05:00
Mike Dalessio 99fe5ff934 Make sure that comments show up in search properly
when the search term appears in both the comment and the card description
2025-11-19 18:02:36 -05:00
Mike Dalessio 378705a30d Deduplicate filter results
when both a card and that card's comments match the search term, we
don't want to show it multiple times.

ref: https://app.fizzy.do/5986089/cards/3030
2025-11-19 17:51:38 -05:00
Jason Zimdars a500cbf43a Merge pull request #1645 from basecamp/jz-11-19-25
JZ 11-19-25
2025-11-19 16:47:59 -06:00
Jason Zimdars f35623b75f Capitalize 2025-11-19 16:47:02 -06:00
Jason Zimdars 67da7cba75 Update test 2025-11-19 16:46:09 -06:00
Mike Dalessio a5f5b592c2 test: remove redundant session setup 2025-11-19 17:43:40 -05:00
Jason Zimdars 25e2d98c35 Don't label these, they're expected and obvious (I think) 2025-11-19 16:26:55 -06:00
Jason Zimdars a15043a336 The symbol is hard to read, go back to text labels 2025-11-19 16:23:21 -06:00
Jason Zimdars 0259cb860d Fix awkward wrapping on mobile 2025-11-19 16:16:16 -06:00
Jason Zimdars 7e008864f2 Ensure back buttons collapse to icons on small screens 2025-11-19 16:04:21 -06:00
Andy Smith 96eec219b3 Actually, keep it, but just target mobile Safari 2025-11-19 16:04:11 -06:00
Andy Smith 221c03c3df Remove special Safari hack 2025-11-19 16:02:25 -06:00
Jason Zimdars 5bab67999e Add Current.account to cache key 2025-11-19 15:44:57 -06:00
Mike Dalessio 6592a0e89a Merge pull request #1642 from basecamp/flavorjones/join-code-exhaustion
Display a helpful error message when join code is exhausted
2025-11-19 15:54:30 -05:00
Mike Dalessio c53b56c1db Display a helpful error message when join code is exhausted
ref: https://app.fizzy.do/5986089/cards/3015
2025-11-19 15:53:25 -05:00
Andy Smith 30a201f1ed Merge pull request #1636 from basecamp/mini-bubble-reposition
Don't show mini bubbles in Maybe column
2025-11-19 14:12:31 -06:00
Mike Dalessio 1382920e9b Merge pull request #1641 from basecamp/flavorjones/stats-dashboard-3
Small tweaks to dashboard
2025-11-19 14:37:11 -05:00
Mike Dalessio 775a339e3a Small tweaks to dashboard 2025-11-19 14:36:46 -05:00
Mike Dalessio 49ac5defed Merge pull request #1640 from basecamp/flavorjones/stats-dashboard-2
Small improvements to the stats dashboard
2025-11-19 14:31:44 -05:00
Mike Dalessio 2fe578c5e5 Small improvements to the stats dashboard 2025-11-19 14:31:13 -05:00
Mike Dalessio 1dd7672a8d Merge pull request #1637 from basecamp/flavorjones/admin-dashboard
Basic admin dashboard
2025-11-19 14:24:50 -05:00
Mike Dalessio 362be963c0 Add a very rudimentary admin dashboard. 2025-11-19 14:23:47 -05:00
Mike Dalessio 4636b31f06 Authorization ensure_staff uses identity.staff
for use on untenanted routes
2025-11-19 14:23:47 -05:00
Mike Dalessio 6de979daaa Merge pull request #1639 from basecamp/flavorjones/http-basic-auth
Restore http basic auth in prod
2025-11-19 14:16:56 -05:00
Mike Dalessio 47c05e6d6a Restore basic auth on signup
broken in 6e304958
2025-11-19 14:12:59 -05:00
Fernando Álvarez 672816dec5 Move production jobs to specific hosts 2025-11-19 19:12:02 +01:00
Andy Smith e0625070ed Don't show mini bubbles in Maybe column 2025-11-19 11:48:58 -06:00
Fernando Álvarez a6a4bb236b Split jobs hosts for Staging
Related to https://3.basecamp.com/2914079/buckets/37331921/todos/9266308208
2025-11-19 18:31:29 +01:00
Mike Dalessio 945505e147 Merge pull request #1635 from basecamp/flavorjones/fix-active-storage-account-slugs
Fix account slugs in Active Storage URLs
2025-11-19 09:01:52 -05:00
Mike Dalessio 711cc8568e Fix account slugs in Active Storage URLs 2025-11-19 08:51:12 -05:00
Mike Dalessio 977169c688 Merge pull request #1634 from basecamp/flavorjones/unscoped-pwa
Remove the account slug from the PWA manifest
2025-11-19 08:30:48 -05:00
Mike Dalessio 5a85466732 Remove the account slug from the PWA manifest
- linked in the `head` on all requests (previously just tenanted requests)
- `start_url` and `scope` are "/" (previously account slug)
2025-11-19 08:27:41 -05:00