8e479dddba
Clearer still
2025-04-15 16:04:11 +02:00
5d22809e29
No public use of this concept, so inline it
2025-04-15 16:03:14 +02:00
680611503d
Distinguish between administering and just changing
2025-04-15 16:00:29 +02:00
a6a96fd5c8
Dont repeat the same checks from doing, make it clearer where the difference is
2025-04-15 15:55:29 +02:00
93178636cd
Flesh out all the tests
2025-04-15 15:41:01 +02:00
2e8df45680
Flesh out tests for users controller
2025-04-15 15:36:11 +02:00
af0a42080b
Allow users to edit themselves
2025-04-15 15:35:39 +02:00
abd2af3d8a
Dont need an index for a single record
2025-04-15 15:35:28 +02:00
2ace519d91
There is only one account, so just check join code directly
2025-04-15 15:35:10 +02:00
7e5f71fedd
We will only have one account record per account
...
Not sure why this was added in the first place.
2025-04-15 15:17:30 +02:00
61b24483a7
Deploy to new node
...
Our production node has been replaced; `fizzy-app-101` is the new one.
2025-04-15 09:38:02 +01:00
028a43e652
Title is on the related card
2025-04-14 15:50:24 +01:00
bc8060a2dd
Merge pull request #399 from basecamp/consolidate-cards
...
Consolidate cards
2025-04-14 09:40:58 -05:00
a88264ed0a
Merge branch 'main' into consolidate-cards
...
* main: (94 commits)
Source order seems to be significant
Use `card.title`
Nicer flow
Fix string interpolation
Fix constant
Use record lookup
Always use sole
Explained less and extracted nothing of value
Weird double negative
Remove anemic and indirect method that explained nothing
Can use record lookup for workflows
Access control has already been done through the card
Style
Use _path in all cases where we are not potentially changing the domain
Clearer
Spacing
Get rid of card_title
Join the two users controllers but split out role setting
Ensure user is returned
We are not using the parameter
...
2025-04-14 09:40:22 -05:00
289487a383
Source order seems to be significant
...
Regressed in d3c5c86b21
2025-04-14 09:23:57 -05:00
3cfdaf1129
Use card.title
2025-04-14 08:54:54 -05:00
cfb345bc32
Nicer flow
2025-04-13 20:39:09 +02:00
80c518b7e1
Fix string interpolation
2025-04-13 20:36:16 +02:00
e8a730c239
Fix constant
2025-04-13 20:36:07 +02:00
34232c0e31
Use record lookup
2025-04-13 20:30:03 +02:00
d9a9690137
Always use sole
2025-04-13 20:29:10 +02:00
9e0b9c08c2
Explained less and extracted nothing of value
2025-04-13 20:28:35 +02:00
33278469ef
Weird double negative
2025-04-13 20:26:58 +02:00
a5df54015e
Remove anemic and indirect method that explained nothing
2025-04-13 20:25:59 +02:00
e2a931b657
Can use record lookup for workflows
2025-04-13 20:24:16 +02:00
366fe06113
Access control has already been done through the card
2025-04-13 20:22:53 +02:00
e12ef119da
Style
2025-04-13 20:17:24 +02:00
dbf61f4fc3
Use _path in all cases where we are not potentially changing the domain
2025-04-13 08:17:36 +02:00
7b60748796
Clearer
2025-04-13 08:11:25 +02:00
4ef46ccd19
Spacing
2025-04-13 08:10:47 +02:00
5b524254b9
Merge pull request #403 from basecamp/commit-to-single-account
...
The tenanted db is the account scope
2025-04-13 07:58:12 +02:00
cf93da6886
Get rid of card_title
...
We can just set untitled on assignment of empty
2025-04-12 21:29:56 +02:00
a106b1b6a7
Join the two users controllers but split out role setting
2025-04-12 20:30:47 +02:00
c463f342bf
Ensure user is returned
2025-04-12 20:30:28 +02:00
a579e67057
We are not using the parameter
2025-04-12 20:08:42 +02:00
6bbf68a4f9
The tenanted db is the account scope
2025-04-12 20:06:34 +02:00
19dbd5b325
Merge pull request #402 from basecamp/drop-boosts
...
Drop boosts
2025-04-12 18:54:46 +02:00
760cbb6c99
Drop boosts
...
Killed by design.
2025-04-12 18:52:54 +02:00
1b732c41c7
Use render svg
2025-04-12 18:15:05 +02:00
120e8da1d5
Unused
2025-04-12 14:14:34 +02:00
4723b7b504
Style
2025-04-12 14:13:20 +02:00
d3c5c86b21
Style
2025-04-12 14:06:11 +02:00
a9c6f8bceb
No reuse likely
2025-04-12 13:51:47 +02:00
b36b2f04a9
Too clever to have the redirect_to directly on the factory method return
2025-04-12 13:49:23 +02:00
19c537af64
Inline anemic method
2025-04-12 13:48:03 +02:00
9b89562755
Merge pull request #398 from basecamp/comments-refactoring
...
Comments refactoring
2025-04-12 13:45:10 +02:00
1a70be06c6
Fix trailing CR
2025-04-12 13:37:31 +02:00
706178f3c4
Better naming
2025-04-12 13:33:54 +02:00
d4a31fec6d
Dont overload the main transaction
...
Even if we are going to get rid of this cleanup_events stuff.
2025-04-12 13:33:06 +02:00
2357c75063
Reads better with a verb first
2025-04-12 13:09:49 +02:00
David Heinemeier Hansson