Commit Graph

3550 Commits

Author SHA1 Message Date
Andy Smith 950ee83358 Add hover effects to buttons 2025-07-01 16:18:06 -05:00
Andy Smith 380e981a40 WIP Set up global vars for focus ring 2025-07-01 15:41:51 -05:00
Andy Smith aa67ed0a2c Refactor how link underlines are added 2025-07-01 15:09:28 -05:00
Andy Smith 560e9d9d8f Separate toggle buttons from main component 2025-07-01 15:07:53 -05:00
Andy Smith c39bd244e2 Scope icon size variable to button 2025-07-01 15:02:25 -05:00
Mike Dalessio 5f31e6612b Merge pull request #685 from basecamp/flavorjones/fix-sqlite-backups
SQLiteBackupsJob explicitly uses db_config.database_path
2025-07-01 15:39:45 -04:00
Mike Dalessio fe8b71c2c9 SQLiteBackupsJob explicitly uses db_config.database_path
because using db_config.database will give us the sqlite file URL with
query params, and that's not what we mean.

This should restore nightly backups.
2025-07-01 15:32:13 -04:00
Jorge Manrubia 43ec523eaa Update action text lexical! 2025-07-01 09:58:33 +02:00
Jorge Manrubia c2e1b36d7e Merge pull request #675 from basecamp/command-errors
Show command errors
2025-07-01 09:56:42 +02:00
Jorge Manrubia 50b4f34f34 Copy tweaks 2025-07-01 09:51:11 +02:00
Jorge Manrubia 888923d32b Copy tweaks 2025-07-01 09:50:10 +02:00
Jorge Manrubia 01bda1b529 Merge pull request #672 from basecamp/filter-ignore-diacritics
Convert diacritics to approximations before filtering
2025-07-01 09:46:14 +02:00
Jorge Manrubia a5f5a4ec26 Remove helper not used anymore because lexical handles it
https://github.com/basecamp/actiontext-lexical/pull/18
2025-07-01 09:44:24 +02:00
Jorge Manrubia 2ab322adfe Tidy up code to normalize text, extract text helpers 2025-07-01 09:42:22 +02:00
Mike Dalessio 96408e6088 Merge pull request #683 from basecamp/flavorjones/fix-closed-notifications
Fix notification rendering on card closure events
2025-06-30 23:49:20 -04:00
Mike Dalessio 3156fbd770 Fix notification rendering on card closure events
where the closure no longer exists, possibly due to being
reopened.

Previously, fragment caching generally prevented any problems, but if
the cache is busted for any reason (like Andy did in c7eeb56c), then
the previous logic would raise an exception like "undefined method
'reason' for nil".

So, if the closure no longer exists, let's just note that it was
closed, and by who.
2025-06-30 23:45:53 -04:00
Jason Zimdars fb1ec2ab3a Copy edits 2025-06-30 18:14:48 -05:00
Jason Zimdars ab5d6931de Color the output red, too 2025-06-30 18:14:43 -05:00
Jason Zimdars ffb422ac61 This attribute is no longer needed 2025-06-30 17:31:07 -05:00
Jason Zimdars dec57f1a9a Perform conversion on the client side 2025-06-30 17:30:34 -05:00
Jason Zimdars 3af949edca Merge branch 'main' into filter-ignore-diacritics
* main:
  Clear the comments cache
  Add context for search screens
  Needs changed for both states
  Use lighter icon and update asset
  Add btn--circle class to user edit form
  Organize button variants
  Untangle `avatar btn` crossover styles
  Remove redundant classes and styles for avatars
  Adjust footer line height
  Tweak padding
2025-06-30 17:01:43 -05:00
Andy Smith ec287b2a50 Merge pull request #676 from basecamp/clear-cache
Clear the comments cache
2025-06-30 16:48:12 -05:00
Andy Smith c7eeb56cfa Clear the comments cache 2025-06-30 16:47:08 -05:00
Jorge Manrubia 179ae45bf3 Show command errors
I went with placing htis logic at the command level since it plays well with the composite structure, where you don't know whether you are handling one command or many commands, and you want to aggregate all the errors. I didn't leverage the existing support with rails' model errors because that customizing those message is cumbersome (either i18n or using custom validation logic for everything).
2025-06-30 23:10:39 +02:00
Jorge Manrubia eb3fc208a9 Merge pull request #674 from basecamp/search-context
Make search results screen a "cards context for Fizzy do
2025-06-30 22:15:30 +02:00
Jorge Manrubia 9db96bc4a4 Add context for search screens 2025-06-30 22:13:42 +02:00
Andy Smith 95310da203 Merge pull request #650 from basecamp/misc-polish
Tweak padding
2025-06-30 15:07:41 -05:00
Jason Zimdars f3c3a72887 Needs changed for both states 2025-06-30 15:00:03 -05:00
Jason Zimdars a8e495db36 Merge branch 'update-bookmark-button'
* update-bookmark-button:
  Use lighter icon and update asset
2025-06-30 14:52:10 -05:00
Jason Zimdars 45f2ace71b Use lighter icon and update asset 2025-06-30 14:47:33 -05:00
Andy Smith bd144396b7 Merge pull request #673 from basecamp/avatar-cleanup
Avatar cleanup
2025-06-30 14:35:32 -05:00
Andy Smith 79c0847a0e Add btn--circle class to user edit form 2025-06-30 14:29:09 -05:00
Andy Smith 4d07735cd5 Organize button variants 2025-06-30 14:18:14 -05:00
Andy Smith 39fce2aba1 Untangle avatar btn crossover styles 2025-06-30 14:15:59 -05:00
Andy Smith be003cd3f7 Remove redundant classes and styles for avatars 2025-06-30 14:00:59 -05:00
Jason Zimdars 2678f8c099 Convert diacritics to approximations before filtering
- Introduces a helper method for setting the filterable value
- Updates `filter_controller.js` to use `data-filter-text-value` attribute populated with converted content. This was previous `data-value` in the earlier implementation but ignored in the current on.
- Also uses the same helper to make @mentions diacritic insensitive
2025-06-30 13:53:50 -05:00
Jorge Manrubia dc351959e8 Remove creation and closure params 2025-06-27 20:28:40 +02:00
Jorge Manrubia 05d1a68e11 Merge pull request #670 from basecamp/final-commands
Open profiles with natural language
2025-06-27 15:27:39 +02:00
Jorge Manrubia 1f21c12c35 Support viewing user profiles and activity 2025-06-27 15:22:45 +02:00
Jorge Manrubia a1340c81d7 Support downcase 2025-06-27 14:17:14 +02:00
Jorge Manrubia 4e894fa5fe refresh fixtures 2025-06-27 13:55:50 +02:00
Jorge Manrubia 7da4696952 Always downcase names 2025-06-27 13:55:10 +02:00
Jorge Manrubia d06a38f883 Merge pull request #669 from basecamp/time-filters
Add support for more time-related queries
2025-06-27 13:42:11 +02:00
Jorge Manrubia f5832f1a36 Remove vcr_record call 2025-06-27 13:40:57 +02:00
Jorge Manrubia cabf57dec3 Support closing soon and falling back soon via natural language 2025-06-27 13:39:19 +02:00
Jorge Manrubia aa656dc2f4 Add scopes and filters for falling back soon and auto closing soon 2025-06-27 13:39:17 +02:00
Jorge Manrubia 716ea6cafa Fix label 2025-06-27 13:38:47 +02:00
Jorge Manrubia 4d5017b671 Add chip filters for the new time window filters
rename close => closure to ease interpretation by the LLM
2025-06-27 13:38:45 +02:00
Jorge Manrubia 3391a20843 Fix: creator_ids is an array, not a single value 2025-06-27 13:38:23 +02:00
Jorge Manrubia 3fbfa1404c Add support for filtering by creation or completion windows of times 2025-06-27 13:38:22 +02:00