Commit Graph

5337 Commits

Author SHA1 Message Date
Jorge Manrubia a680235773 Redirect to home if remove yourself from the collection 2025-09-17 18:21:50 +02:00
Andy Smith c7737f6e35 Merge branch 'main' into nav-filter-handle-collapsed-sections
* main: (55 commits)
  Use polymorphic_url instead of path
  Rename redundant name
  Exclude inactive users
  Send HTML to campfire instead of JSON
  Fix crash due to missing default value
  Bundle rails from main
  Sort alphabetically
  Now that we have space on the left, move it there
  Add missing actions
  Remove URL field from edit form
  Improve active state
  Don't need to navigate this list
  Style show view
  Style web hooks forms and list WIP
  Rename methods for clarity
  Use HTML5 validation for the URL
  Change the icon if there are webhooks on a collection
  Simplify delinquency tracking
  Scope Webhooks to Collections
  Limit access to webhooks to admins
  ...
2025-09-17 11:12:31 -05:00
Jorge Manrubia 515fb72d54 Add buttons for toggle on and off 2025-09-17 18:08:26 +02:00
Andy Smith de7780b5e5 Don't save state to localStorage when filtering 2025-09-17 11:07:24 -05:00
Stanko Krtalić e34eee8237 Merge pull request #1127 from basecamp/send-urls-in-webhooks
Use polymorphic_url instead of path
2025-09-17 14:08:32 +02:00
Stanko K.R. f020d377f3 Use polymorphic_url instead of path 2025-09-17 14:05:43 +02:00
Jorge Manrubia 87c0e3faaa Merge pull request #1126 from basecamp/notify-system
Don´t add system users to collections
2025-09-17 13:32:00 +02:00
Jorge Manrubia f1d76a7cb7 Exclude inactive users
The system user should never be a subsriber but we should not serve it if it is
2025-09-17 13:26:53 +02:00
Stanko K.R. 5710aa724f Send HTML to campfire instead of JSON 2025-09-17 13:16:00 +02:00
Jorge Manrubia d622c4ade1 Tidy up a bit 2025-09-17 12:52:34 +02:00
Stanko Krtalić 9b55ff241c Merge pull request #1124 from basecamp/fix-missing-default-value-for-delinquency-tracker
Fix crash due to missing default value
2025-09-17 11:53:41 +02:00
Stanko K.R. 661471e9e8 Fix crash due to missing default value 2025-09-17 11:47:46 +02:00
Andy Smith 5ea7b5f3ee Use same approach for both section loops 2025-09-16 15:01:24 -05:00
Andy Smith 0c88ee2d97 Make things more concise 2025-09-16 14:56:31 -05:00
Andy Smith ec0433d721 Remember localStorage state after filtering 2025-09-16 14:46:21 -05:00
Jason Zimdars ae07de1ba1 Sort alphabetically 2025-09-16 14:29:02 -05:00
Jason Zimdars 4b64b17e38 Now that we have space on the left, move it there 2025-09-16 14:16:31 -05:00
Jason Zimdars b5d880c063 Merge pull request #1101 from basecamp/involvement-defaults
Involvement defaults
2025-09-16 14:16:24 -05:00
Jason Zimdars 1258b0e6e0 Merge pull request #1111 from basecamp/on-deck-entropic
Cards in On Deck adopt the same entropy behavior as ones in Doing
2025-09-16 14:15:47 -05:00
Andy Smith 3cad86411f WIP 2025-09-16 14:14:38 -05:00
Stanko K.R. 34222b9717 Add missing actions 2025-09-16 20:23:50 +02:00
Stanko K.R. b49e8d2d34 Remove URL field from edit form 2025-09-16 20:18:35 +02:00
Jason Zimdars 2e9273c6ab Improve active state 2025-09-16 20:08:06 +02:00
Jason Zimdars 784d6cf690 Don't need to navigate this list
I doubt most collections will ever have more than a handul
2025-09-16 20:08:06 +02:00
Jason Zimdars daee271940 Style show view 2025-09-16 20:08:06 +02:00
Jason Zimdars a5b4c88d27 Style web hooks forms and list WIP 2025-09-16 20:08:06 +02:00
Stanko K.R. ce1d6469e7 Rename methods for clarity 2025-09-16 20:08:06 +02:00
Stanko K.R. 63e64a060d Use HTML5 validation for the URL 2025-09-16 20:08:06 +02:00
Stanko K.R. 5b3089e11e Change the icon if there are webhooks on a collection 2025-09-16 20:08:06 +02:00
Stanko K.R. dd3063b01d Simplify delinquency tracking 2025-09-16 20:08:03 +02:00
Stanko K.R. 02a421675f Scope Webhooks to Collections 2025-09-16 20:07:25 +02:00
Stanko K.R. 25b2daad93 Limit access to webhooks to admins 2025-09-16 20:04:20 +02:00
Stanko K.R. 1d192c9d42 Ignore low-volume webhooks for delinquency checks 2025-09-16 20:04:20 +02:00
Stanko K.R. fee25a49ea Periodically cleanup deliveries 2025-09-16 20:04:20 +02:00
Stanko K.R. 9d77b17b8c Remove encryption 2025-09-16 20:04:20 +02:00
Stanko K.R. d7db973397 Use the same timestamp from the body in the header
Else replay attack prevention doesn't work
2025-09-16 20:04:20 +02:00
Stanko K.R. df87ee8b35 Rename private IP ranges to disallowed IP ranges 2025-09-16 20:04:20 +02:00
Stanko K.R. b8317ce88d Fix indentation 2025-09-16 20:04:20 +02:00
Stanko K.R. 5e4d15d802 Remove concurrency limit
It won't be useful in practice for now, and we can always put it back in if the need arises
2025-09-16 20:04:20 +02:00
Stanko K.R. 1b09a39b1a Adhere to the redirect and params sanitization convention 2025-09-16 20:04:20 +02:00
Stanko K.R. 2fc9215b1d Add support for Basecamp, Campfire & Slack webhooks 2025-09-16 20:04:20 +02:00
Stanko K.R. 4879995013 Serialize events 2025-09-16 20:04:20 +02:00
Stanko K.R. 0bdbc5f5e8 Add abuse prevention 2025-09-16 20:04:18 +02:00
Stanko K.R. 4da69fb69f Move reactivation out of edit 2025-09-16 20:03:57 +02:00
Stanko K.R. 5c6cad057f Extract triggering logic into a concern 2025-09-16 20:03:57 +02:00
Stanko K.R. 9d717239e7 Dispatch Webhooks on event creation 2025-09-16 20:03:57 +02:00
Stanko K.R. 1930067e08 Allow Webhooks to be disabled 2025-09-16 20:03:57 +02:00
Stanko K.R. 9cfd1e43af Enable subscribing to specific actions 2025-09-16 20:03:57 +02:00
Stanko K.R. a515ea3b1f Create webhooks 2025-09-16 20:03:55 +02:00
Jorge Manrubia b5a2c4a25e Tidy up code a bit 2025-09-16 13:18:13 +02:00