Jason Zimdars
e86be26f43
Update test
...
This test is a little naive because it matches cards in stages
regardless of engagement status unlike the actual conroller. For example
`@new_card` gets created and moved to a stage but it's actually not even
published and so shouldn't be stageable.
2025-08-28 21:24:23 -05:00
Jason Zimdars
b261cf629a
Fix layout when filtering by closed
...
`.card_columns` needs to be present for Recently Closed to have the
correct layout.
2025-08-28 21:01:02 -05:00
Jason Zimdars
bd36e43348
Engagement status interferes with stages filter
...
I'm not entirely sure why `engagement_status` is even present here but
it ends up being inherited by the Recently Closed section because
@closed doesn't explicityly set its status.That makes the cards in
closed disappear when filtering by stage becaue they return true for
`engagement_status = doing`.
2025-08-28 20:56:40 -05:00
Jason Zimdars
f80ef52f81
Workflow stage filter should only apply to cards in doing
...
No other column has Workflows so they should be unaffected by the filter
2025-08-28 20:54:23 -05:00
Jason Zimdars
d32e9e9fd8
Merge pull request #1000 from basecamp/jz/8-28-25pm
...
jz/8 28 25pm
2025-08-28 16:54:46 -05:00
Jason Zimdars
8c12c45233
Add an obvious way back to the collection
2025-08-28 16:49:05 -05:00
Jason Zimdars
93108cc6e8
Don't show the active columns when filtering "Closed by"
2025-08-28 16:42:54 -05:00
Jason Zimdars
d3f16f49d9
Don't show add button when looking at multiple collections
...
This can be confusing if you expect to be able to add a card in the
current context
2025-08-28 16:33:11 -05:00
Jason Zimdars
21304786af
Better pattern alignment where the elements touch
2025-08-28 16:24:45 -05:00
Jason Zimdars
a926665d6d
Make the pattern fit a little better
2025-08-28 16:19:27 -05:00
Jason Zimdars
ecd551f38a
Pull actions in from the extreme edges and match #main width
2025-08-28 16:15:14 -05:00
Jason Zimdars
178eaf0ecd
Restore empty state, made it filter aware
2025-08-28 15:54:41 -05:00
Jason Zimdars
be39aa41d0
Merge pull request #998 from basecamp/jz/fizzy-nav
...
Minor Fizzy menu tweaks
2025-08-28 14:31:42 -05:00
Jason Zimdars
b1feebb129
Balance buttons
2025-08-28 14:12:01 -05:00
Jason Zimdars
0ffaf75c32
Remove blue outline, ensure hover state is visible in dark mode
2025-08-28 14:08:16 -05:00
Jason Zimdars
e1dfe17d0e
Merge pull request #997 from basecamp/golden-filter
...
Filter by golden status
2025-08-28 13:44:31 -05:00
Jason Zimdars
ce05d800d3
Filter by golden status
2025-08-28 13:39:02 -05:00
Andy Smith
f11a309902
Merge pull request #996 from basecamp/ff-font-size-bug
...
Max size for bubble number to prevent FF bug
2025-08-28 13:37:58 -05:00
Andy Smith
18417d1bd2
Max size for bubble number to prevent FF bug
2025-08-28 13:34:45 -05:00
Andy Smith
9733886db3
Merge pull request #988 from basecamp/fizzy-menu-everywhere
...
Fizzy menu everywhere
2025-08-28 12:25:44 -05:00
Andy Smith
f89413f3f5
Merge branch 'main' into fizzy-menu-everywhere
...
* main:
Add a focus effect when hovering columns
Fix up hotkeys
test: backfill hotkeys helper tests
refactor: remove unused routes associated with "resource :account"
test: backfill account route tests to prepare for refactor
Alphabetically order concerns (#992 )
Copy
Don't show the filter if there aren't any tags
Add clearer labels for sorting options
Prevent deleting the last collection
Don't show "All collections" when there's only the default collection
Rename engagement columns
2025-08-28 12:24:14 -05:00
Andy Smith
2036071ddd
Remove collection filtering where it's not needed
2025-08-28 12:22:48 -05:00
Jason Zimdars
ce1b47ce41
Merge pull request #995 from basecamp/hover-cols
...
Add a focus effect when hovering columns
2025-08-28 12:16:47 -05:00
Andy Smith
3db7644c06
Merge pull request #989 from basecamp/single-collection
...
Single collection
2025-08-28 12:15:15 -05:00
Jason Zimdars
3d252850fb
Add a focus effect when hovering columns
2025-08-28 12:10:37 -05:00
Mike Dalessio
f4f38015dd
Merge pull request #993 from basecamp/flavorjones/clean-up-unused-routes-1
...
refactor: remove unused routes associated with "resource :account"
2025-08-28 12:19:05 -04:00
Jorge Manrubia
8f1a6852fa
Preferred form of passing the tenant slug
2025-08-28 18:09:13 +02:00
Mike Dalessio
f488b2e767
Merge pull request #994 from basecamp/flavorjones/linux-hotkey-labels
...
Fix up hotkey labels
2025-08-28 12:03:12 -04:00
Jorge Manrubia
c2fe32cdfc
Fix email
2025-08-28 17:59:13 +02:00
Jorge Manrubia
4427524e53
We do need the host!
2025-08-28 17:55:12 +02:00
Mike Dalessio
5f4ee049c6
Fix up hotkeys
...
ref: https://fizzy.37signals.com/5986089/collections/2/cards/1452
2025-08-28 11:47:45 -04:00
Mike Dalessio
28c4cc7cee
test: backfill hotkeys helper tests
...
and remove support for the unused use case of comma-delimited-strings
2025-08-28 11:44:51 -04:00
Jorge Manrubia
02c538bbb7
Run for each tenant
2025-08-28 17:38:52 +02:00
Jorge Manrubia
5fe66dd602
Fix job class
2025-08-28 17:37:35 +02:00
Jorge Manrubia
9ba9a5758b
Remove hosts for now
...
Docker subnets causing trouble and this is not really part of the email change
2025-08-28 17:21:15 +02:00
Mike Dalessio
87d81e608b
refactor: remove unused routes associated with "resource :account"
...
- Drop from 313 unused routes to 306 unused routes
- Use a namespace for the account-related resource routes
- Controllers are nested under the "Account" module now
- Move views from "accounts/" to "account/"
2025-08-28 11:12:24 -04:00
Jorge Manrubia
5c890bbc34
Bundle every few hours by default
2025-08-28 17:08:22 +02:00
Mike Dalessio
e26c1db5c5
test: backfill account route tests to prepare for refactor
2025-08-28 11:01:52 -04:00
Jorge Manrubia
e4ab1366be
Add unsubscribe links and headers for emails
...
https://3.basecamp.com/2914079/buckets/37331921/todos/9002504172
2025-08-28 16:59:24 +02:00
Jorge Manrubia
243779dbcf
Copy
2025-08-28 13:07:27 +02:00
Jorge Manrubia
960f074b3f
Don't bundle new notifications is bundling is disabled
2025-08-28 12:53:19 +02:00
Jorge Manrubia
4e2717a61f
Merge main into bundle-emails branch
2025-08-28 12:42:43 +02:00
Jorge Manrubia
c1c359f030
Review existing bundles when changing the pending bundles
2025-08-28 12:29:40 +02:00
Jorge Manrubia
2adb4571e1
Copy
2025-08-28 12:03:49 +02:00
Jorge Manrubia
fb95c8aa92
Copy
2025-08-28 12:02:12 +02:00
Jorge Manrubia
53144a379c
Add option to change the bundled email notification frequency
2025-08-28 11:56:40 +02:00
Jorge Manrubia
082a10e3d0
Add notification settings model
2025-08-28 11:20:28 +02:00
Stanko Krtalić
41edfae2b5
Alphabetically order concerns ( #992 )
2025-08-28 11:07:56 +02:00
Jorge Manrubia
169bf490eb
Leverage existing polymorphic routes
2025-08-28 10:34:36 +02:00
Jorge Manrubia
65d90b73bd
Use URLs instead of paths so that these work from emails
...
Having to do this is not ideal but it's the simpler way of reusing
other custom route resolvers. The alternative would be to duplicate the code
for resolving comments and such.
2025-08-28 10:32:01 +02:00