9e921b85c0
Merge branch 'main' into add-card-description
2025-04-19 20:00:43 +02:00
3003105ac9
Flesh out the rest of the controller tests
2025-04-18 16:16:04 +02:00
f6cd21f7cb
Extract default stages into something that will be created together with a new Workflow in the model
2025-04-18 16:07:01 +02:00
fd21838f88
Add assert_in_body helper
...
Coming upstream
2025-04-18 16:06:30 +02:00
44a5215da7
Merge branch 'main' into add-card-description
...
* main:
Fix failing test (we're no longer redirecting here
Display the empty message via CSS when there are no unread notifications
Hide Previously Seen section when empty with CSS
2025-04-17 17:08:49 -05:00
c61fa77d6b
Fix failing test (we're no longer redirecting here
...
See: #411
2025-04-17 17:03:18 -05:00
04f9a0f83a
Merge branch 'main' into add-card-description
...
* main: (33 commits)
Run beamer accessories in production only
Less noisy logging in production
Inline perma to container partial
Use card replacement for card updates too
Extract helper method to keep partial at a uniform level of abstraction
Remove duplicated conditional
Style
Note that we dont want to keep reloading these frames
I like this even better
Suffix qualifier is unnnecessary
Group partials for container
Match domain language
Fix trailing space
Use card rerendering instead of redirects
Better name
Stick with domain language
Fix tests
Rerender instead of redirect
Style
Extract partials that can be rerendered
...
2025-04-17 16:40:23 -05:00
7adbd8d634
Use card rerendering instead of redirects
2025-04-17 15:20:27 +02:00
06da295f44
Fix tests
2025-04-17 14:56:53 +02:00
7b5a1c0232
Fix test
2025-04-17 14:32:26 +02:00
fc0cf3917f
Pin without redirect
...
Use turbo stream response to save on the redirect latency
2025-04-17 14:05:26 +02:00
a5de4863fa
Allow for multiple notifications to be read
...
cc @kevinmcconnell
2025-04-17 11:39:37 +02:00
47d0ae98a1
Remove DraftCommenting
2025-04-16 19:01:21 -05:00
91194d1b66
Fixed up controller test
2025-04-16 16:37:06 +02:00
50e4587dd9
Fix trailing spaces
2025-04-16 11:56:21 +02:00
375afeac7b
Fix test
2025-04-16 11:55:35 +02:00
73f272f132
Use one controller for all notification readings
2025-04-15 19:14:50 +02:00
93178636cd
Flesh out all the tests
2025-04-15 15:41:01 +02:00
2e8df45680
Flesh out tests for users controller
2025-04-15 15:36:11 +02:00
dbf61f4fc3
Use _path in all cases where we are not potentially changing the domain
2025-04-13 08:17:36 +02:00
a106b1b6a7
Join the two users controllers but split out role setting
2025-04-12 20:30:47 +02:00
6bbf68a4f9
The tenanted db is the account scope
2025-04-12 20:06:34 +02:00
760cbb6c99
Drop boosts
...
Killed by design.
2025-04-12 18:52:54 +02:00
7861b7c087
Just open one turbo stream per card
...
Per comment is excessive and needless
2025-04-11 17:58:11 +02:00
79700162fc
Use correct stream name
...
comment, :comments makes no sense for a stream for the reactions
2025-04-11 17:47:35 +02:00
f4ce57e308
Move comments under cards
2025-04-11 16:21:44 +02:00
4f3f322528
Rename inconsistency: go with goldness
2025-04-11 10:22:18 +02:00
1bac0b84b3
Add tests
2025-04-11 09:36:24 +02:00
c7b3b45977
Merge pull request #391 from basecamp/cards-pagination-2
...
Paginate collection cards
2025-04-10 15:10:54 +02:00
695247ae9b
Paginate collection cards
2025-04-10 15:09:56 +02:00
aa7694ce7b
Update fixtures and test
2025-04-09 17:28:24 -05:00
723e6d94f5
Rename bubbles => cards
2025-04-09 14:50:58 +02:00
9bbb59a166
Test for Bubbles::RecoversController
2025-04-07 14:30:05 +01:00
23892296da
Move readings under bubbles and out of double nesting
2025-04-07 14:06:56 +02:00
481be72162
Move bubbles publish out from the double nesting
2025-04-07 13:55:12 +02:00
ce0c6146be
Move bubble pops out from double nesting
2025-04-07 13:45:51 +02:00
e4f7837ebe
Remove double nesting under bubbles for engagement
2025-04-07 13:30:31 +02:00
c06802856e
Move boosts under bubbles
...
But also remove the need for a bucket nesting
2025-04-06 21:04:28 +02:00
4fd1472fae
Move bubble watch out from the needless bucket nesting
2025-04-06 19:22:40 +02:00
eb0614c44f
Use a more ergonomic API for watching
...
Passing a boolean vs using explicit on/off methods feel too low level
and doesnt read right in most of these cases.
2025-04-06 19:17:26 +02:00
a58fcd3123
Nicer API
2025-04-06 13:26:10 +02:00
cdd78b41ee
Tag exclusively by title
2025-04-06 13:19:22 +02:00
540316e639
Move taggings under bubbles
2025-04-05 21:54:48 +02:00
25b89ce8a9
Trailing CR
2025-04-05 17:18:18 +02:00
5134985418
Simplify the assignments flow
...
We now submit on every selection, so we dont need a whole form and
checkboxes to do it.
This needs some design tune-up after the change, though. cc @jzimdars
2025-04-05 17:14:57 +02:00
d0953d6f87
Pull assignments out of the double nesting
2025-04-05 15:59:51 +02:00
b4c0fec7a6
Move Assignments under Bubble
...
Since that what we are assigning
2025-04-05 15:51:53 +02:00
e69c1bd0a1
Break pins out of the double nesting
...
Its cumbersome and needless
2025-04-05 15:45:16 +02:00
866a80e133
Fix up the tests
2025-04-05 15:26:49 +02:00
bfb7ed1216
Move pins to my space
...
We used the my/ space in HEY to reflect anything that was primarily
hinged off Current.user. Good to use here too.
2025-04-05 14:57:24 +02:00
David Heinemeier Hansson