Commit Graph

2747 Commits

Author SHA1 Message Date
Andy Smith a07c827cdf Clarify comment 2025-07-02 16:15:16 -05:00
Andy Smith 4bc1b36d3d Clean up --hover variables 2025-07-02 16:14:34 -05:00
Andy Smith 4c42b8fe15 Merge branch 'main' into focus-hover-styles
* main: (21 commits)
  squash! Remove session controller actions other than delete
  Remove the invitation codes for now
  Remove session controller actions other than delete
  Account.signal_account is no longer optional
  Remove local authentication code
  Drop the password column from the users table.
  Script to create Users for existing 37id accounts
  Configure Mission Control to skip tenanted authentication
  Script to update URLs and attachments in cards and comments
  Make sure seeds are creating sluggable tenants
  Script to rename tenants after the QB account id
  Update the signups tests to work with untenanted paths
  Update the Command classes to handle paths with account slugs
  Update bin/dev to point at the new tenant URLs
  Patch Active Storage controllers to generate slugged URLs
  Point Action Cable at the slugged cable endpoint
  Extract pieces from the tenanting initializer
  Patch Turbo to use the request script name
  Use the new AR::Tenanted convention for action cable connections
  Use a tenant resolver that recognizes the account slug
  ...
2025-07-02 14:51:45 -05:00
Mike Dalessio 4537037a4c squash! Remove session controller actions other than delete 2025-07-02 15:23:59 -04:00
Mike Dalessio 7f1b384425 Remove the invitation codes for now
until I circle back for https://3.basecamp.com/2914079/buckets/37331921/todos/8746162337
2025-07-02 15:15:05 -04:00
Mike Dalessio fa1c5f7279 Remove session controller actions other than delete
and do some general cleanup around sessions controllers and the
sign_in_as test helper
2025-07-02 15:03:28 -04:00
Mike Dalessio c8be7418c1 Account.signal_account is no longer optional 2025-07-02 12:04:26 -04:00
Mike Dalessio da69bd1689 Remove local authentication code 2025-07-02 11:59:21 -04:00
Andy Smith 0c5e54caf4 Workflow swatch buttons 2025-07-01 17:26:40 -05:00
Andy Smith 2df9d65b37 Workflow previews 2025-07-01 17:24:44 -05:00
Andy Smith 624dc823c4 Make card column filters interactive 2025-07-01 17:16:09 -05:00
Andy Smith 9250c19e94 Hover effect for collection picker on cards 2025-07-01 16:58:57 -05:00
Andy Smith 6f40afcfae Ensure avatar image size takes up the whole container 2025-07-01 16:42:47 -05:00
Andy Smith f901f1a82a Handle dark mode 2025-07-01 16:33:45 -05:00
Andy Smith 06706a78d8 Subtler hover for buttons 2025-07-01 16:26:48 -05:00
Andy Smith 950ee83358 Add hover effects to buttons 2025-07-01 16:18:06 -05:00
Andy Smith 380e981a40 WIP Set up global vars for focus ring 2025-07-01 15:41:51 -05:00
Andy Smith aa67ed0a2c Refactor how link underlines are added 2025-07-01 15:09:28 -05:00
Andy Smith 560e9d9d8f Separate toggle buttons from main component 2025-07-01 15:07:53 -05:00
Andy Smith c39bd244e2 Scope icon size variable to button 2025-07-01 15:02:25 -05:00
Mike Dalessio b8368de002 Update the Command classes to handle paths with account slugs 2025-07-01 15:56:14 -04:00
Mike Dalessio 98e6bd8cd7 Point Action Cable at the slugged cable endpoint
I proposed this upstream in https://github.com/rails/rails/pull/55250,
but it's not clear if the presence of script_name should _always_
prefix generated URLs, so for now it's local to Fizzy.
2025-07-01 15:56:14 -04:00
Mike Dalessio 33d5eccb70 Use the new AR::Tenanted convention for action cable connections 2025-07-01 15:56:14 -04:00
Mike Dalessio fe8b71c2c9 SQLiteBackupsJob explicitly uses db_config.database_path
because using db_config.database will give us the sqlite file URL with
query params, and that's not what we mean.

This should restore nightly backups.
2025-07-01 15:32:13 -04:00
Jorge Manrubia c2e1b36d7e Merge pull request #675 from basecamp/command-errors
Show command errors
2025-07-01 09:56:42 +02:00
Jorge Manrubia 50b4f34f34 Copy tweaks 2025-07-01 09:51:11 +02:00
Jorge Manrubia 888923d32b Copy tweaks 2025-07-01 09:50:10 +02:00
Jorge Manrubia 01bda1b529 Merge pull request #672 from basecamp/filter-ignore-diacritics
Convert diacritics to approximations before filtering
2025-07-01 09:46:14 +02:00
Jorge Manrubia a5f5a4ec26 Remove helper not used anymore because lexical handles it
https://github.com/basecamp/actiontext-lexical/pull/18
2025-07-01 09:44:24 +02:00
Jorge Manrubia 2ab322adfe Tidy up code to normalize text, extract text helpers 2025-07-01 09:42:22 +02:00
Mike Dalessio 3156fbd770 Fix notification rendering on card closure events
where the closure no longer exists, possibly due to being
reopened.

Previously, fragment caching generally prevented any problems, but if
the cache is busted for any reason (like Andy did in c7eeb56c), then
the previous logic would raise an exception like "undefined method
'reason' for nil".

So, if the closure no longer exists, let's just note that it was
closed, and by who.
2025-06-30 23:45:53 -04:00
Jason Zimdars fb1ec2ab3a Copy edits 2025-06-30 18:14:48 -05:00
Jason Zimdars ab5d6931de Color the output red, too 2025-06-30 18:14:43 -05:00
Jason Zimdars ffb422ac61 This attribute is no longer needed 2025-06-30 17:31:07 -05:00
Jason Zimdars dec57f1a9a Perform conversion on the client side 2025-06-30 17:30:34 -05:00
Jason Zimdars 3af949edca Merge branch 'main' into filter-ignore-diacritics
* main:
  Clear the comments cache
  Add context for search screens
  Needs changed for both states
  Use lighter icon and update asset
  Add btn--circle class to user edit form
  Organize button variants
  Untangle `avatar btn` crossover styles
  Remove redundant classes and styles for avatars
  Adjust footer line height
  Tweak padding
2025-06-30 17:01:43 -05:00
Andy Smith c7eeb56cfa Clear the comments cache 2025-06-30 16:47:08 -05:00
Jorge Manrubia 179ae45bf3 Show command errors
I went with placing htis logic at the command level since it plays well with the composite structure, where you don't know whether you are handling one command or many commands, and you want to aggregate all the errors. I didn't leverage the existing support with rails' model errors because that customizing those message is cumbersome (either i18n or using custom validation logic for everything).
2025-06-30 23:10:39 +02:00
Jorge Manrubia eb3fc208a9 Merge pull request #674 from basecamp/search-context
Make search results screen a "cards context for Fizzy do
2025-06-30 22:15:30 +02:00
Jorge Manrubia 9db96bc4a4 Add context for search screens 2025-06-30 22:13:42 +02:00
Andy Smith 95310da203 Merge pull request #650 from basecamp/misc-polish
Tweak padding
2025-06-30 15:07:41 -05:00
Jason Zimdars f3c3a72887 Needs changed for both states 2025-06-30 15:00:03 -05:00
Jason Zimdars a8e495db36 Merge branch 'update-bookmark-button'
* update-bookmark-button:
  Use lighter icon and update asset
2025-06-30 14:52:10 -05:00
Jason Zimdars 45f2ace71b Use lighter icon and update asset 2025-06-30 14:47:33 -05:00
Andy Smith 79c0847a0e Add btn--circle class to user edit form 2025-06-30 14:29:09 -05:00
Andy Smith 4d07735cd5 Organize button variants 2025-06-30 14:18:14 -05:00
Andy Smith 39fce2aba1 Untangle avatar btn crossover styles 2025-06-30 14:15:59 -05:00
Andy Smith be003cd3f7 Remove redundant classes and styles for avatars 2025-06-30 14:00:59 -05:00
Jason Zimdars 2678f8c099 Convert diacritics to approximations before filtering
- Introduces a helper method for setting the filterable value
- Updates `filter_controller.js` to use `data-filter-text-value` attribute populated with converted content. This was previous `data-value` in the earlier implementation but ignored in the current on.
- Also uses the same helper to make @mentions diacritic insensitive
2025-06-30 13:53:50 -05:00
Jorge Manrubia dc351959e8 Remove creation and closure params 2025-06-27 20:28:40 +02:00