Commit Graph

303 Commits

Author SHA1 Message Date
David Heinemeier Hansson a5de4863fa Allow for multiple notifications to be read
cc @kevinmcconnell
2025-04-17 11:39:37 +02:00
David Heinemeier Hansson 91194d1b66 Fixed up controller test 2025-04-16 16:37:06 +02:00
David Heinemeier Hansson 50e4587dd9 Fix trailing spaces 2025-04-16 11:56:21 +02:00
David Heinemeier Hansson 375afeac7b Fix test 2025-04-16 11:55:35 +02:00
David Heinemeier Hansson 73f272f132 Use one controller for all notification readings 2025-04-15 19:14:50 +02:00
David Heinemeier Hansson 93178636cd Flesh out all the tests 2025-04-15 15:41:01 +02:00
David Heinemeier Hansson 2e8df45680 Flesh out tests for users controller 2025-04-15 15:36:11 +02:00
David Heinemeier Hansson dbf61f4fc3 Use _path in all cases where we are not potentially changing the domain 2025-04-13 08:17:36 +02:00
David Heinemeier Hansson a106b1b6a7 Join the two users controllers but split out role setting 2025-04-12 20:30:47 +02:00
David Heinemeier Hansson 6bbf68a4f9 The tenanted db is the account scope 2025-04-12 20:06:34 +02:00
David Heinemeier Hansson 760cbb6c99 Drop boosts
Killed by design.
2025-04-12 18:52:54 +02:00
David Heinemeier Hansson 60a0360203 Remove more activity scoring related to comments 2025-04-12 10:52:48 +02:00
David Heinemeier Hansson fb733b9a60 No more tracking commenting as an activity for sorting
We are doing away with all the automated activity scoring, but for now
lets just get rid of it for comments.
2025-04-12 10:50:25 +02:00
David Heinemeier Hansson 7861b7c087 Just open one turbo stream per card
Per comment is excessive and needless
2025-04-11 17:58:11 +02:00
David Heinemeier Hansson 79700162fc Use correct stream name
comment, :comments makes no sense for a stream for the reactions
2025-04-11 17:47:35 +02:00
David Heinemeier Hansson f4ce57e308 Move comments under cards 2025-04-11 16:21:44 +02:00
Jorge Manrubia 4f3f322528 Rename inconsistency: go with goldness 2025-04-11 10:22:18 +02:00
Jorge Manrubia 806609e77b Use gild/ungild 2025-04-11 10:20:06 +02:00
Jorge Manrubia f4b2bec5ce Fix test 2025-04-11 09:57:45 +02:00
Jorge Manrubia 1bac0b84b3 Add tests 2025-04-11 09:36:24 +02:00
Jason Zimdars ca067f7ca0 Fix tests
This is cheating a little because Doing and Considering are both always sorted by Latest at the moment. Keeping it like this while we vet this new direction
2025-04-10 14:42:42 -05:00
Jorge Manrubia c7b3b45977 Merge pull request #391 from basecamp/cards-pagination-2
Paginate collection cards
2025-04-10 15:10:54 +02:00
Jorge Manrubia 695247ae9b Paginate collection cards 2025-04-10 15:09:56 +02:00
Jorge Manrubia 468bbf1388 Add test 2025-04-10 13:15:29 +02:00
Jason Zimdars aa7694ce7b Update fixtures and test 2025-04-09 17:28:24 -05:00
Jorge Manrubia 473fa1dafd Rename constant 2025-04-09 21:28:29 +02:00
Jorge Manrubia 221bbb3247 Fix renames that the scripts missed 2025-04-09 14:56:59 +02:00
Jorge Manrubia 723e6d94f5 Rename bubbles => cards 2025-04-09 14:50:58 +02:00
Kevin McConnell 9bbb59a166 Test for Bubbles::RecoversController 2025-04-07 14:30:05 +01:00
David Heinemeier Hansson 23892296da Move readings under bubbles and out of double nesting 2025-04-07 14:06:56 +02:00
David Heinemeier Hansson bcd6c6dd66 Move bubble stagings out from double nesting 2025-04-07 14:00:30 +02:00
David Heinemeier Hansson 481be72162 Move bubbles publish out from the double nesting 2025-04-07 13:55:12 +02:00
David Heinemeier Hansson ce0c6146be Move bubble pops out from double nesting 2025-04-07 13:45:51 +02:00
Jorge Manrubia 2106fb464a Revert "Scope searches by user"
This reverts commit 47552dd8d7.
2025-04-07 13:42:57 +02:00
Jorge Manrubia 47552dd8d7 Scope searches by user 2025-04-07 13:42:27 +02:00
Jorge Manrubia e4f7837ebe Remove double nesting under bubbles for engagement 2025-04-07 13:30:31 +02:00
Jorge Manrubia 16e8041524 Add unique constraint for keeping tags unique on a per-account basis 2025-04-07 11:36:34 +02:00
Jorge Manrubia f403ed070c Downcase tag titles 2025-04-07 10:43:23 +02:00
Jorge Manrubia 99584a17f4 Ignore case when trying to match tags 2025-04-07 06:01:43 +02:00
David Heinemeier Hansson c06802856e Move boosts under bubbles
But also remove the need for a bucket nesting
2025-04-06 21:04:28 +02:00
David Heinemeier Hansson 4fd1472fae Move bubble watch out from the needless bucket nesting 2025-04-06 19:22:40 +02:00
David Heinemeier Hansson eb0614c44f Use a more ergonomic API for watching
Passing a boolean vs using explicit on/off methods feel too low level
and doesnt read right in most of these cases.
2025-04-06 19:17:26 +02:00
David Heinemeier Hansson 5e78a1dab1 Make it clearer that this takes a title string not a tag object 2025-04-06 13:28:52 +02:00
David Heinemeier Hansson a58fcd3123 Nicer API 2025-04-06 13:26:10 +02:00
David Heinemeier Hansson cdd78b41ee Tag exclusively by title 2025-04-06 13:19:22 +02:00
David Heinemeier Hansson ee22e69e6e Move taggings to bubbles 2025-04-05 22:19:12 +02:00
David Heinemeier Hansson 540316e639 Move taggings under bubbles 2025-04-05 21:54:48 +02:00
David Heinemeier Hansson 25b89ce8a9 Trailing CR 2025-04-05 17:18:18 +02:00
David Heinemeier Hansson 5134985418 Simplify the assignments flow
We now submit on every selection, so we dont need a whole form and
checkboxes to do it.

This needs some design tune-up after the change, though. cc @jzimdars
2025-04-05 17:14:57 +02:00
David Heinemeier Hansson d0953d6f87 Pull assignments out of the double nesting 2025-04-05 15:59:51 +02:00