Commit Graph

3573 Commits

Author SHA1 Message Date
Jorge Manrubia b0e35bcd54 Remove trace 2025-07-02 21:51:42 +02:00
Jorge Manrubia ccdaec4721 Include command in the search string 2025-07-02 21:27:47 +02:00
Jorge Manrubia ddb0470480 Format 2025-07-02 21:26:24 +02:00
Jorge Manrubia cee3925057 Add all commands 2025-07-02 21:26:10 +02:00
Jorge Manrubia 3e8d164807 Update editor 2025-07-02 18:33:55 +02:00
Jason Zimdars d699223248 Tweak virtual cursor 2025-07-02 11:27:41 -05:00
Jorge Manrubia 725071d40a Update editor 2025-07-02 18:09:17 +02:00
Jorge Manrubia 6383918c03 Update editor 2025-07-02 18:08:22 +02:00
Jorge Manrubia cbe246c3c1 Revert "We insert these now to make sure the cursor is visible when the attachment is the only element in the paragraph"
This reverts commit b67d2eefd7.
2025-07-02 18:03:29 +02:00
Jorge Manrubia b67d2eefd7 We insert these now to make sure the cursor is visible when the attachment is the only element in the paragraph 2025-07-02 18:03:02 +02:00
Jorge Manrubia 31c3a08387 Update editor 2025-07-02 17:51:20 +02:00
Jason Zimdars 36d1da692c Use selection color 2025-07-02 10:27:42 -05:00
Jason Zimdars e1fc813bb1 Make caption more WYSIWYG 2025-07-02 10:27:42 -05:00
Jason Zimdars 4f8fd6107d Mentions should match the surrounding text 2025-07-02 10:27:42 -05:00
Jorge Manrubia 1d60ce24f7 Update editor 2025-07-02 17:25:42 +02:00
Jorge Manrubia 797a586552 Update editor 2025-07-02 17:11:46 +02:00
Jorge Manrubia 09ee0324cd Push simulated cursor (I'll ask for design help next) 2025-07-02 16:05:50 +02:00
Jorge Manrubia 18afaa87c2 For custom attachments we don't manage figures anymore, but action-text-attachments
So that we keep HTML valid when nesting them within paragraphs
2025-07-02 16:01:34 +02:00
Andy Smith 22283851ee Style prompts and insertions in the terminal 2025-07-01 13:58:54 -05:00
Jorge Manrubia a34b18a77c Refine 2025-07-01 18:33:45 +02:00
Jorge Manrubia 9e45cf625d Remove caching so that it doesn't interfere when working on design 2025-07-01 18:31:51 +02:00
Jorge Manrubia 6440e22030 To be used 2025-07-01 18:31:26 +02:00
Jorge Manrubia b2f9bf1f2e Stub for command prompts 2025-07-01 18:27:38 +02:00
Jorge Manrubia 36daa58858 Use lexical from github for design work 2025-07-01 16:12:55 +02:00
Jorge Manrubia d6ba1573c3 Set max height for the menus 2025-07-01 16:11:28 +02:00
Jorge Manrubia cae01b777e Add prompt for tags too 2025-07-01 14:58:24 +02:00
Jorge Manrubia 60d243da52 Support direct references such as @user via rich text commands 2025-07-01 14:16:29 +02:00
Jorge Manrubia 93be9e945f Support user prompts in Fizzy do, move parsing logic to context 2025-07-01 14:06:39 +02:00
Jorge Manrubia 0f7b45ab38 Use lexical in the command line 2025-07-01 12:15:02 +02:00
Jorge Manrubia 939d68b941 Don't prevent default with light/right arrows since this prevents moving cursor on input fields 2025-07-01 11:38:44 +02:00
Jorge Manrubia 43ec523eaa Update action text lexical! 2025-07-01 09:58:33 +02:00
Jorge Manrubia c2e1b36d7e Merge pull request #675 from basecamp/command-errors
Show command errors
2025-07-01 09:56:42 +02:00
Jorge Manrubia 50b4f34f34 Copy tweaks 2025-07-01 09:51:11 +02:00
Jorge Manrubia 888923d32b Copy tweaks 2025-07-01 09:50:10 +02:00
Jorge Manrubia 01bda1b529 Merge pull request #672 from basecamp/filter-ignore-diacritics
Convert diacritics to approximations before filtering
2025-07-01 09:46:14 +02:00
Jorge Manrubia a5f5a4ec26 Remove helper not used anymore because lexical handles it
https://github.com/basecamp/actiontext-lexical/pull/18
2025-07-01 09:44:24 +02:00
Jorge Manrubia 2ab322adfe Tidy up code to normalize text, extract text helpers 2025-07-01 09:42:22 +02:00
Mike Dalessio 96408e6088 Merge pull request #683 from basecamp/flavorjones/fix-closed-notifications
Fix notification rendering on card closure events
2025-06-30 23:49:20 -04:00
Mike Dalessio 3156fbd770 Fix notification rendering on card closure events
where the closure no longer exists, possibly due to being
reopened.

Previously, fragment caching generally prevented any problems, but if
the cache is busted for any reason (like Andy did in c7eeb56c), then
the previous logic would raise an exception like "undefined method
'reason' for nil".

So, if the closure no longer exists, let's just note that it was
closed, and by who.
2025-06-30 23:45:53 -04:00
Jason Zimdars fb1ec2ab3a Copy edits 2025-06-30 18:14:48 -05:00
Jason Zimdars ab5d6931de Color the output red, too 2025-06-30 18:14:43 -05:00
Jason Zimdars ffb422ac61 This attribute is no longer needed 2025-06-30 17:31:07 -05:00
Jason Zimdars dec57f1a9a Perform conversion on the client side 2025-06-30 17:30:34 -05:00
Jason Zimdars 3af949edca Merge branch 'main' into filter-ignore-diacritics
* main:
  Clear the comments cache
  Add context for search screens
  Needs changed for both states
  Use lighter icon and update asset
  Add btn--circle class to user edit form
  Organize button variants
  Untangle `avatar btn` crossover styles
  Remove redundant classes and styles for avatars
  Adjust footer line height
  Tweak padding
2025-06-30 17:01:43 -05:00
Andy Smith ec287b2a50 Merge pull request #676 from basecamp/clear-cache
Clear the comments cache
2025-06-30 16:48:12 -05:00
Andy Smith c7eeb56cfa Clear the comments cache 2025-06-30 16:47:08 -05:00
Jorge Manrubia 179ae45bf3 Show command errors
I went with placing htis logic at the command level since it plays well with the composite structure, where you don't know whether you are handling one command or many commands, and you want to aggregate all the errors. I didn't leverage the existing support with rails' model errors because that customizing those message is cumbersome (either i18n or using custom validation logic for everything).
2025-06-30 23:10:39 +02:00
Jorge Manrubia eb3fc208a9 Merge pull request #674 from basecamp/search-context
Make search results screen a "cards context for Fizzy do
2025-06-30 22:15:30 +02:00
Jorge Manrubia 9db96bc4a4 Add context for search screens 2025-06-30 22:13:42 +02:00
Andy Smith 95310da203 Merge pull request #650 from basecamp/misc-polish
Tweak padding
2025-06-30 15:07:41 -05:00