Commit Graph

3860 Commits

Author SHA1 Message Date
Jorge Manrubia b30bc85f4e Rework prompt to make it less ambiguous and better overall 2025-07-18 05:11:08 +02:00
Jorge Manrubia 1486392b6b WIP 2025-07-17 13:32:37 +02:00
Jorge Manrubia 5f04696fe8 Rewrite prompt to be more accurate and example-driven 2025-07-17 13:32:36 +02:00
Mike Dalessio 941ee05dcb Merge pull request #757 from basecamp/flavorjones/ruby-3.4.5
dep: bump to ruby 3.4.5
2025-07-16 19:15:33 -04:00
Mike Dalessio a099b4101a dep: bump to ruby 3.4.5
Also:

- bump bundler to 2.7.0
- work around the fix for https://bugs.ruby-lang.org/issues/21196 that appeared in 3.4.5
2025-07-16 19:13:39 -04:00
David Heinemeier Hansson caaa205557 Switch to docker-dev 2025-07-16 15:33:22 -07:00
Jason Zimdars acef439f7e Cache needs to include publication key 2025-07-16 15:49:53 -05:00
Mike Dalessio 130ae4025e Merge pull request #753 from basecamp/flavorjones/console-invitation
First iteration on adding new users, from the console.
2025-07-16 13:01:22 -04:00
Mike Dalessio 4955cb6647 First iteration on adding new users, from the console. 2025-07-16 12:59:47 -04:00
Jason Zimdars f29980b9e7 Fix clear button position in Safari
See: https://fizzy.37signals.com/5986089/collections/2/cards/1097
2025-07-16 11:39:09 -05:00
Jason Zimdars 468a29c9ad Give them screen reader labels
See: https://fizzy.37signals.com/5986089/collections/2/cards/1106
2025-07-16 11:33:33 -05:00
Jason Zimdars f0235e7e07 Not needed
See: https://fizzy.37signals.com/5986089/collections/2/cards/1108
2025-07-16 11:08:06 -05:00
Jason Zimdars ec8084074f Add missing lang attribute
See: https://fizzy.37signals.com/5986089/collections/2/cards/1110
2025-07-16 11:05:23 -05:00
Jason Zimdars c46ea5471c Restore missing aspect ratio on the perma
We want to keep a pleasing shape when looking at the full card. It already expands as needed on mobile or when the description is lengthy
cc: @andyra
2025-07-16 11:03:45 -05:00
Jason Zimdars d4cae4a596 Give the field more space when typing on mobile 2025-07-16 08:48:03 -05:00
Jason Zimdars 15a809855d We're only concerned with truncating the placeholder, scope to that 2025-07-16 08:30:03 -05:00
Mike Dalessio 1d4f52a045 Merge pull request #750 from basecamp/flavorjones/user-deactivate
Make User deactivation work properly with 37id/Launchpad
2025-07-15 18:50:21 -04:00
Mike Dalessio e69023993c Make sure users can't login from launchpad if they're deactivated
Just in case the SignalId::User deletion failed.
2025-07-15 18:47:38 -04:00
Mike Dalessio 9f887e17f5 Destroy the SignalId::User when a user is deactivated 2025-07-15 18:30:23 -04:00
Jason Zimdars c777fc3804 Fix that tray toggle was nearly invisible in dark mode 2025-07-14 10:55:58 -05:00
Andy Smith 8d60592ccd Merge pull request #720 from basecamp/notification-links
Notification links
2025-07-10 17:04:31 -05:00
Andy Smith 83b262aff8 Merge pull request #740 from basecamp/mobile-card-improvements
Mobile card improvements
2025-07-10 16:44:37 -05:00
Andy Smith 71ead7f35a Hide empty p tag 2025-07-10 16:34:11 -05:00
Jason Zimdars 70c2cc62a1 Merge branch 'main' into public-collection-cards
* main:
  Revert "Adjust borders"
  Don't allow wrapping initially
  Adjust borders
  Truncate long commands
  Try using env safe insets to avoid overlapping elements on mobile
  Correct asset width and remove caption input focus ring
  Revert "Make a focus-ring global variable"
  Make a focus-ring global variable
  Set `id` explicitly so the `label for` reference works
  Higher resolution image
  When adding a card out of context, default to most recently accessed collection
  Fine tuning to handle different attachment types
  Replace helper with view lookup
  Make nil safe
  Extract attachments to a partial
  Remove `card_published` check and render its own template
  Extract common concern to examine attachments
  This is a hack but we should be showing the card description and attachments for new cards
  Display attachments in events for comments
  Indicate cards with attachments in the description
2025-07-10 16:33:51 -05:00
Jason Zimdars 74ac6fae9e Merge branch 'mobile-insets'
* mobile-insets:
  Revert "Adjust borders"
  Don't allow wrapping initially
  Adjust borders
  Try using env safe insets to avoid overlapping elements on mobile
2025-07-10 16:31:34 -05:00
Andy Smith af097e3747 Move workflow below title when it won't fit comfortably on the side 2025-07-10 16:23:22 -05:00
Andy Smith cebbc390a1 Consistent card title size 2025-07-10 16:17:10 -05:00
Andy Smith bd8f37e742 Tighten up space below header 2025-07-10 16:16:52 -05:00
Andy Smith 35ea2c3921 Use vw units for main padding 2025-07-10 16:16:40 -05:00
Jason Zimdars aa32b482ae Revert "Adjust borders"
This reverts commit 14979f3000.
2025-07-10 16:06:58 -05:00
Jason Zimdars 74e0cd3af8 Don't allow wrapping initially 2025-07-10 14:50:36 -05:00
Jason Zimdars 14979f3000 Adjust borders 2025-07-10 14:48:50 -05:00
Andy Smith 8da817c1ed Merge pull request #737 from basecamp/terminal-command-overflow
Truncate long commands
2025-07-10 14:48:11 -05:00
Andy Smith 0585c5f1e1 Truncate long commands 2025-07-10 14:44:22 -05:00
Jason Zimdars 0d1c0f4e75 Try using env safe insets to avoid overlapping elements on mobile 2025-07-10 14:26:58 -05:00
Andy Smith 207d315787 Merge pull request #736 from basecamp/attachment-focus-states
Attachment focus states
2025-07-10 14:15:43 -05:00
Andy Smith 221c2b30f5 Correct asset width and remove caption input focus ring 2025-07-10 14:04:27 -05:00
Andy Smith 20111d8830 Revert "Make a focus-ring global variable"
This reverts commit 39a8e60cbc.
2025-07-10 14:01:48 -05:00
Andy Smith 39a8e60cbc Make a focus-ring global variable 2025-07-10 14:00:00 -05:00
Jason Zimdars 4d65d2be85 Set id explicitly so the label for reference works 2025-07-10 12:56:59 -05:00
Andy Smith 073dfd2ae1 Tweak the hat padding 2025-07-10 11:34:08 -05:00
Andy Smith 5162677c44 Align dialog, shrink hat, canvas background 2025-07-10 11:20:37 -05:00
Jorge Manrubia 81560c73dd Use existing direct route 2025-07-10 14:57:20 +02:00
Jason Zimdars 8e6819c362 Higher resolution image 2025-07-09 16:03:28 -05:00
Jason Zimdars ed37bf0ff8 When adding a card out of context, default to most recently accessed collection 2025-07-09 15:37:39 -05:00
Jason Zimdars 32e967c1f9 Fine tuning to handle different attachment types 2025-07-09 14:46:33 -05:00
Jason Zimdars 7a058a18d9 Merge branch 'main' into card-attachments
* main:
  Add circle-on-mobile button class
2025-07-09 11:22:41 -05:00
Jason Zimdars a60eedf186 Merge branch 'main' into public-collection-cards
* main:
  Add circle-on-mobile button class
2025-07-09 11:20:41 -05:00
Jason Zimdars cd022fcc1c Not fit for public 2025-07-09 11:10:41 -05:00
Jason Zimdars 55f92e73f7 Not needed here 2025-07-09 11:08:09 -05:00