Jason Zimdars
b498dfd752
Restore related events hover effect
2025-03-18 15:59:37 -05:00
Kevin McConnell
d44562c24c
Merge pull request #306 from basecamp/quieter-notifs
...
Quieter notifs
2025-03-18 17:57:48 +00:00
Kevin McConnell
4216b1123e
Formatting
2025-03-18 17:53:32 +00:00
Kevin McConnell
e9ae2772e4
Add tests to validate notification recipients
2025-03-18 17:46:57 +00:00
Kevin McConnell
bc5e32e737
Only "published" notifies collection subscribers
...
The other notifications are only sent to the watchers of the bubble.
2025-03-18 17:46:57 +00:00
Jason Zimdars
a0d365289f
Merge pull request #305 from basecamp/tickets
...
New visual design
2025-03-18 08:35:23 -05:00
Jason Zimdars
836e6fab5e
Avoid touch when setting initial stage
2025-03-18 08:26:16 -05:00
Mike Dalessio
2c87c2fb15
Update schema files and fix some trivial test failures.
2025-03-18 09:14:16 -04:00
Jason Zimdars
28a569c49b
Tickets
2025-03-17 21:24:08 -05:00
Bruno Prieto
9a6d73b4d0
Merge pull request #302 from basecamp/a11y-first-round
...
First round of accessibility fixes
2025-03-14 18:01:57 +01:00
Jason Zimdars
e53052b7e7
Fix visual button regression
...
`.for-screen-reader` has specific behavior inside `.btn` that makes it unsuitable for use on form elements. This fix adds a second, functionally identical, class `visually-hidden` for those cases. Later we can figure out a way to make it clear when to use which.
2025-03-14 09:58:50 -05:00
Mike Dalessio
9719d43cf0
Merge pull request #303 from basecamp/flavorjones-bump-artenanted-8728b0ea
...
dep: bump dependencies
2025-03-14 10:18:09 -04:00
Mike Dalessio
325ec59ffd
dep: bundle update
...
- [ ] minitest: 5.25.4 -> 5.25.5
- used by active_record-tenanted, geared_pagination, importmap-rails, jbuilder, kamal, propshaft, rails, rails_structured_logging, sentry-rails, solid_cable, solid_cache, solid_queue, stimulus-rails, turbo-rails
- [ ] json: 2.10.1 -> 2.10.2
- used by rails_structured_logging
- [ ] sentry-ruby: 5.22.4 -> 5.23.0
- used by sentry-rails
2025-03-14 10:14:53 -04:00
Mike Dalessio
18db35aaa4
dep: bump active_record-tenanted
2025-03-14 10:11:41 -04:00
Bruno Prieto
10cdb8c1a8
Improve accessibility of comments and reactions
2025-03-14 02:29:44 +01:00
Bruno Prieto
7354e74432
Improve bubble readability for screen readers
2025-03-14 01:35:40 +01:00
Bruno Prieto
63a098fcdb
Fix filter input and label id assigments
2025-03-13 23:44:05 +01:00
Bruno Prieto
793a43ff27
Add aria-label and aria-description to filter dialog
...
Otherwise the browser will try to infer the properties. That process is slow for screen readers
2025-03-13 22:56:28 +01:00
Bruno Prieto
dfb49d0f87
Add aria-label and aria-description to filter dialog
...
Otherwise the browser will try to infer the properties. That process is slow for screen readers
2025-03-13 22:46:19 +01:00
Bruno Prieto
cea43da13f
Organize filter inputs by group, similar to fieldset
...
Menu tag is deprecated, li elements are only valid inside ul or ol elements
2025-03-13 22:36:12 +01:00
Mike Dalessio
9a75ca4986
Merge pull request #301 from basecamp/flavorjones-structured-log-tenant
...
Structured logs for controller actions now contain the tenant
2025-03-13 17:22:54 -04:00
Mike Dalessio
e08f073d73
Structured logs for controller actions now contain the tenant
2025-03-13 17:21:31 -04:00
Bruno Prieto
fdd3fb53c0
Label tag don't need a for attribute if it has a input as a children
...
Then input ids aren't required
2025-03-13 22:20:40 +01:00
Bruno Prieto
8a9d57e4c8
Show filter inputs for screen readers
2025-03-13 21:53:53 +01:00
Bruno Prieto
bcda67e114
Div is not a valid parent for list of li elements
2025-03-13 21:25:26 +01:00
Bruno Prieto
4425e0d16a
Hide bubbles for SR users for now
2025-03-13 21:24:30 +01:00
Mike Dalessio
f4c7167316
Merge pull request #299 from basecamp/flavorjones-fix-assignment-notif-recip
...
fix: Send assignment notifications only to the assignee
2025-03-13 12:29:37 -04:00
Mike Dalessio
3e374f4661
fix: Send assignment notifications only to the assignee(s)
...
ref: https://37s.fizzy.37signals.com/buckets/693169850/bubbles/999008619
2025-03-13 12:16:47 -04:00
Kevin McConnell
eabcc1d477
Use Docker Hub for deployments
2025-03-13 15:19:00 +00:00
Mike Dalessio
482aa90243
logging: suppress unstructured log lines
2025-03-13 09:46:14 -04:00
Mike Dalessio
ed92687f4c
logging: revert changes
2025-03-13 09:41:31 -04:00
Mike Dalessio
019a27787c
logging: try just setting log level
2025-03-13 09:38:54 -04:00
Mike Dalessio
3c2e7b8ae3
logging: suppress log entries that are not structured
...
Borrowed from the BC4 configuration.
2025-03-13 09:31:11 -04:00
Mike Dalessio
d1329e7985
dep: update active_record_tenanted to fix console issue
...
ref: https://37s.fizzy.37signals.com/buckets/693169862/bubbles/999008674
2025-03-12 13:26:09 -04:00
Mike Dalessio
325c49ec2a
doc: adding beta+production tenant URLs to the README
2025-03-12 12:18:28 -04:00
Mike Dalessio
31bbb6c76f
deploy: keeping beta to one tenant
2025-03-12 12:14:53 -04:00
Mike Dalessio
a337294650
deploy: update beta hosts for multi-tenancy
2025-03-12 11:56:58 -04:00
Mike Dalessio
5ea619fb8a
doc: update README with the development-tenant URL
...
and a note about db:fixtures:load
2025-03-12 10:51:34 -04:00
Mike Dalessio
dcb8d52dcd
dep: bump active_record-tenanted for a db:fixture:load fix
2025-03-12 09:54:39 -04:00
Mike Dalessio
52a1b49155
Merge pull request #295 from basecamp/flavorjones-update-ar-tenanted-for-trim-job-fix
...
dep: update active_record-tenanted
2025-03-12 09:37:53 -04:00
Mike Dalessio
11df869dfc
dep: update active_record-tenanted
...
for the fix in https://github.com/basecamp/active_record-tenanted/pull/45
2025-03-12 09:34:03 -04:00
Mike Dalessio
eb96412465
The 404 page is in the new Rails style, and lists the tenants
2025-03-12 08:40:11 -04:00
Mike Dalessio
bb5ed28130
kamal-proxy: add fizzy.37signals.com so we can return 404
...
instead of the TLD handshake error now seen
2025-03-12 08:29:40 -04:00
Mike Dalessio
dbe783c182
Final version of the tenancy migration script.
2025-03-12 08:27:30 -04:00
Mike Dalessio
a945f29e29
Merge pull request #279 from basecamp/flavorjones-tenant-v4
...
Introduce tenanting (v3)
2025-03-12 08:26:57 -04:00
Mike Dalessio
d8075b74b7
hack: to handle tenantname.fizzy.37signals.com
...
Let's do the needful thing for now, and clean it up once the gem has
exposed the tenant resolver as a config in a cleaner way.
2025-03-12 07:53:31 -04:00
Mike Dalessio
300dffd376
Script and configuration for a multi-tenant migration
...
ref: https://3.basecamp.com/2914079/buckets/37331921/messages/8422006338
The script takes advantage of the fact that we can bind to the
existing untenanted database by adding it explicitly (and temporarily)
as a readonly shard to the database.yml, and so in the script
with_original_db is connected to the original database.
storage/tenants/%{tenant}/ is now the root directory for all
state stored for a particular tenant, including active storage and the
database.
We leave the existing files and production database in place after the
migration, in case we need to roll back (by reverting the code and
config).
We also don't do a granular active storage blob copy, since the
attachments are mostly on Account (and not on Bubble). Instead we
hardlink the blobs on disk (so we don't take up additional space with
duplicates).
Finally, we're manually adding the kamal-proxy hosts to the deploy
file, so that we can generate letsencrypt certs for the
subdomains. This is only intended to be a short-term solution, we'll
want something like a wildcard cert before we go live.
2025-03-12 07:53:31 -04:00
Mike Dalessio
4af0fe01d6
Update recurring jobs to iterate over all tenants
2025-03-12 07:53:31 -04:00
Mike Dalessio
ca77968e55
Work around Rails' shard swapping lock in the Solid Cache config
...
Because solid cache started using shard swapping when given a
`database:` key in https://github.com/rails/solid_cache/pull/219 , and
Rails doesn't distinguish which database is being swapped and which
was locked.
Hopefully I can make a change upstream that will enable swap locking
only for a specific databases. Until then, let's just use a slightly
more verbose configuration to work around it.
2025-03-12 07:53:31 -04:00
Mike Dalessio
d9ece38753
Make the application multi-tenant
2025-03-12 07:53:31 -04:00