Commit Graph

606 Commits

Author SHA1 Message Date
Kevin McConnell bc5e32e737 Only "published" notifies collection subscribers
The other notifications are only sent to the watchers of the bubble.
2025-03-18 17:46:57 +00:00
Jason Zimdars 28a569c49b Tickets 2025-03-17 21:24:08 -05:00
Jason Zimdars e53052b7e7 Fix visual button regression
`.for-screen-reader` has specific behavior inside `.btn` that makes it unsuitable for use on form elements. This fix adds a second, functionally identical, class `visually-hidden` for those cases. Later we can figure out a way to make it clear when to use which.
2025-03-14 09:58:50 -05:00
Bruno Prieto 10cdb8c1a8 Improve accessibility of comments and reactions 2025-03-14 02:29:44 +01:00
Bruno Prieto 7354e74432 Improve bubble readability for screen readers 2025-03-14 01:35:40 +01:00
Bruno Prieto 63a098fcdb Fix filter input and label id assigments 2025-03-13 23:44:05 +01:00
Bruno Prieto 793a43ff27 Add aria-label and aria-description to filter dialog
Otherwise the browser will try to infer the properties. That process is slow for screen readers
2025-03-13 22:56:28 +01:00
Bruno Prieto dfb49d0f87 Add aria-label and aria-description to filter dialog
Otherwise the browser will try to infer the properties. That process is slow for screen readers
2025-03-13 22:46:19 +01:00
Bruno Prieto cea43da13f Organize filter inputs by group, similar to fieldset
Menu tag is deprecated, li elements are only valid inside ul or ol elements
2025-03-13 22:36:12 +01:00
Bruno Prieto fdd3fb53c0 Label tag don't need a for attribute if it has a input as a children
Then input ids aren't required
2025-03-13 22:20:40 +01:00
Bruno Prieto 8a9d57e4c8 Show filter inputs for screen readers 2025-03-13 21:53:53 +01:00
Bruno Prieto bcda67e114 Div is not a valid parent for list of li elements 2025-03-13 21:25:26 +01:00
Bruno Prieto 4425e0d16a Hide bubbles for SR users for now 2025-03-13 21:24:30 +01:00
Kevin McConnell 16a80ff3a6 More dynamic activity scores
This introduces a more dynamic system of activity scoring, to improve
the way bubbles "bubble up" due to their activity. There are a few
different parts we can tune here, and it's likely we'll need to make
adjustments once we get a feel for how this works in practice.

The basic idea here is:

- We assign points for certain types of event that happen on a bubble. A
  boost gets 1 point, a comment gets 10 points, and so on.
- These points decay over time, at a rate of 50% per day. So old
  activity is worth much less than new activity. Bubbles should rise up
  quickly when acted upon, bit will float back down if left idle.
- Some comments can score higher than others: the first comment from
  each person on a bubble is worth more (20) because it signals that
  more people are getting involved; and comments that follow a comment
  by a different author are also worth more (15) because that signals
  there's ongoing conversation between people, not just a series of
  notes being left by one individual.

In terms of implementation, we persist the score on the bubble
whenever it changes, but we handle the decay on the client side. That
allows us to cache the bubble representation without having to
continually change it while its activity decays.

We also keep a separate `activity_score_order` attribute on the model.
This can be used to sort the bubbles in order of "most active", without
having to think about the decay.
2025-03-05 17:16:31 +00:00
Kevin McConnell 748d09a5f7 Cache comment partial 2025-03-03 17:04:16 +00:00
Kevin McConnell 49fa8b21a6 Move current user check to controller
This is necessary to a) ensure people can't edit/delete comments they
don't own, and b) make the comment partial cacheable.
2025-03-03 17:04:16 +00:00
Jason Zimdars 65ceb3c5f0 Tighten-up headings so they look good when they wrap to two lines (rare) 2025-03-03 09:04:37 -07:00
Jason Zimdars 72592ec3cc Order events in the cluster so that the oldest is closest to the timestamp 2025-03-03 09:04:08 -07:00
Jason Zimdars a87ffd6473 Avoid squishing the switch when the bucket name is very long 2025-03-03 08:55:49 -06:00
Kevin McConnell e7da0d5327 Merge pull request #276 from basecamp/autosave-comments
Autosave comments
2025-02-28 15:30:21 +00:00
Kevin McConnell 5d1206e067 remote-auto-save -> outlet-auto-save 2025-02-28 15:15:09 +00:00
Kevin McConnell 4d13db0f8b Rename to local-save-controller 2025-02-28 15:13:23 +00:00
Kevin McConnell a7cde91a10 Don't save draft comment to local storage
Since we already save this to the database, along with the title.
2025-02-28 14:50:26 +00:00
Kevin McConnell 8bd207096b Pass user in locals 2025-02-27 10:45:18 +00:00
Jason Zimdars ed08b85c25 Fix that remote-auto-save loses markdown formatting by using local autosave 2025-02-26 17:48:02 -06:00
Jason Zimdars a0ffbc807f Auto save comments to local storage to prevent losing work 2025-02-26 17:37:49 -06:00
Jason Zimdars cf5ddbbb78 Style watchers block 2025-02-26 16:47:48 -06:00
Jason Zimdars 8ddf8d1ad3 Use local_assigns 2025-02-26 15:57:16 -06:00
Kevin McConnell fc1939d771 Avoid using Current in the partial 2025-02-26 10:53:03 +00:00
Kevin McConnell 385e299db7 Simplify param 2025-02-26 10:53:03 +00:00
Kevin McConnell a802b8de5a Allow managing bucket subscriptions 2025-02-26 10:53:03 +00:00
Kevin McConnell 6157d8b4bd Start watching when participating on a bubble
If you're added as an assignee, or if you comment, then your watching
preference will be toggled on.
2025-02-26 10:53:03 +00:00
Kevin McConnell 694783e5f3 Allow toggling watch preference
We use a true/false preference so we can tell the difference between
disabling the watch vs never having the watch. This is so we can toggle
off and on the preferences for a container (like the bucket) without
losing any bubble-specific preferences.
2025-02-26 10:53:03 +00:00
Jason Zimdars 8b0f11ab3e Use existing filters system to create some quick links 2025-02-25 16:57:03 -06:00
Jason Zimdars 256edbfa96 Special case self-assignment 2025-02-24 16:25:24 -06:00
Jason Zimdars ed0a815a35 Fix that title could overlap unread indicator 2025-02-24 16:05:42 -06:00
Jason Zimdars d254d1eb27 Bust this cache 2025-02-21 17:37:17 -06:00
Jason Zimdars 530b6e4a90 Stub notifications settings screen 2025-02-21 17:25:44 -06:00
Jason Zimdars 28bdc531b0 Mark individual notifications as read 2025-02-21 16:39:50 -06:00
Jason Zimdars 190e046479 Mark all notifications as read from the index 2025-02-21 12:12:00 -06:00
Jason Zimdars 302427f17b This isn't necessary 2025-02-21 10:54:18 -06:00
Jason Zimdars c4bc9242e2 Fix sign-in logo 2025-02-21 10:49:27 -06:00
Jason Zimdars 1d0562f905 Refactor 2025-02-21 10:44:40 -06:00
Jason Zimdars fb01444a88 "Added by…" is a more useful filter than "Assigned by…" 2025-02-20 16:07:07 -06:00
Jason Zimdars 1ad6a9adb8 Introduce quick filters on the page so the dialog becomes advanced filtering 2025-02-20 15:20:30 -06:00
Jason Zimdars 4b14bc0a55 Shadows for these buttons, too 2025-02-20 13:15:57 -06:00
Jason Zimdars 8cde1883a6 Filter activity by bucket 2025-02-19 18:05:12 -06:00
Jason Zimdars 1fde270b18 Restore back shortcut 2025-02-19 16:05:48 -06:00
Jason Zimdars 867479c7bf Display a link button when there are more unreads than the six we show 2025-02-19 15:17:31 -06:00
Jason Zimdars 2a6e559d7a Tighter comment excerpts 2025-02-19 14:10:36 -06:00