Commit Graph

1569 Commits

Author SHA1 Message Date
David Heinemeier Hansson b4c0fec7a6 Move Assignments under Bubble
Since that what we are assigning
2025-04-05 15:51:53 +02:00
David Heinemeier Hansson e69c1bd0a1 Break pins out of the double nesting
Its cumbersome and needless
2025-04-05 15:45:16 +02:00
David Heinemeier Hansson f725a69dee Let BubbleScoped find its own bucket
Then it will be easier to break things that are double nested out of
that nesting.
2025-04-05 15:44:47 +02:00
David Heinemeier Hansson 8708ff04c1 Fix indention 2025-04-05 15:27:40 +02:00
David Heinemeier Hansson 866a80e133 Fix up the tests 2025-04-05 15:26:49 +02:00
David Heinemeier Hansson e4c6fe4b55 Shape up pinning API and broadcast in the controller 2025-04-05 15:15:48 +02:00
David Heinemeier Hansson bfb7ed1216 Move pins to my space
We used the my/ space in HEY to reflect anything that was primarily
hinged off Current.user. Good to use here too.
2025-04-05 14:57:24 +02:00
David Heinemeier Hansson 7494dad91e Drop the toggles scope for taggings as well 2025-04-05 14:20:06 +02:00
David Heinemeier Hansson 384de24132 Get rid of odd toggles concept
This is just assignments.
2025-04-05 14:16:04 +02:00
David Heinemeier Hansson f063116df4 Group related associations together 2025-04-05 13:19:30 +02:00
David Heinemeier Hansson aefbac9c14 Get rid of single-use and slight awkward model scope
Really dont like that raw Arel.sql wrapping that is required.
2025-04-05 13:17:42 +02:00
David Heinemeier Hansson 61dfa5ecce Spacing 2025-04-05 12:58:56 +02:00
David Heinemeier Hansson 821f4c43d8 Excess CR 2025-04-05 12:49:19 +02:00
David Heinemeier Hansson 1463fa68f4 Sessions only depend on user and have no callback, so use the faster delete_all 2025-04-05 12:48:52 +02:00
David Heinemeier Hansson 8ff017fc5b Only one invocation of this, not carrying the worth of its indirection
Generally I am wary of including global state checks in the belly of
models. It is one thing to do it as a default parameter, but I think it
is too far to do it inside an actual method.
2025-04-05 12:40:08 +02:00
David Heinemeier Hansson d237885bd4 Extract User::Assignee role
Keep slimming down that User
2025-04-05 12:37:18 +02:00
David Heinemeier Hansson 17bdfb5df5 Already included in the Avatar concern 2025-04-05 12:35:41 +02:00
David Heinemeier Hansson 92ce80cc32 Extract User::Accessor concern
Our User model is getting overloaded
2025-04-05 12:34:39 +02:00
David Heinemeier Hansson 4c344d2c36 Use Rails 8.1 defaults
Avoids deprecation warnings during test runs
2025-04-05 12:34:02 +02:00
Jason Zimdars 9cae6bb75a Some browsers can't do this 2025-04-04 17:22:01 -05:00
Jason Zimdars adb04bf4df No need for special case here 2025-04-04 17:20:32 -05:00
Jason Zimdars 43c4ff55b4 Try a switch control for considering||doing 2025-04-04 17:20:22 -05:00
Jason Zimdars 0d6b9b7519 Stub star feature 2025-04-04 16:34:25 -05:00
Jason Zimdars 1f31ca597f Reset value here 2025-04-04 16:19:04 -05:00
Jason Zimdars 90d67654ea This is a bit narrow 2025-04-04 16:16:47 -05:00
Jason Zimdars d2d8c2121f Crisp edges 2025-04-04 16:14:38 -05:00
Jason Zimdars 0a7c7e7889 Use a variant of the bubble color for the perma surround 2025-04-04 16:06:21 -05:00
Andy Smith 61553b77aa Merge pull request #359 from basecamp/picture-icon-repair
Make sure the picture-add icon is square so it doesn't get clipped
2025-04-04 16:01:05 -05:00
Andy Smith a4cccb70a7 Make sure the picture-add icon is square so it doesn't get clipped 2025-04-04 15:21:33 -05:00
Jason Zimdars 4ecb5db6a9 Fix misalignment 2025-04-04 15:17:48 -05:00
Jorge Manrubia 77ad92c807 Restore missing link to navigate to cards 2025-04-04 18:12:02 +02:00
Jorge Manrubia 42f6412541 Merge pull request #356 from basecamp/show-stage
Fixes for permas
2025-04-04 18:01:14 +02:00
Jorge Manrubia 6512b8c726 Only consider in doing/considering published cards 2025-04-04 17:58:27 +02:00
Jason Zimdars a436e3461b Use the helper so we get "Untitled" instead of nil for untitled bubbles 2025-04-04 10:55:22 -05:00
Jason Zimdars ca0b8a6dd1 Not feeling this design 2025-04-04 10:52:56 -05:00
Jorge Manrubia c33d95c47c Show stages only when in doing 2025-04-04 17:52:47 +02:00
Andy Smith 067193d776 Merge pull request #355 from basecamp/missing-check-icons
Fix two icon_tag goofs
2025-04-04 10:42:33 -05:00
Andy Smith 55634a0fb9 Fix focus visible state 2025-04-04 10:42:21 -05:00
Andy Smith 1921c062f2 Fix two icon_tag goofs 2025-04-04 10:36:36 -05:00
Jorge Manrubia a41ee80e91 Remove duplication for tags 2025-04-04 17:27:36 +02:00
Jorge Manrubia 77e9e4b05f Merge pull request #353 from basecamp/sort-completed
Sort completed bubbles by most recently completed first
2025-04-04 17:12:05 +02:00
Jorge Manrubia a4fd270abd Merge pull request #354 from basecamp/rework-card-previews
Separate and reorganize templates for card previews and permas
2025-04-04 17:11:54 +02:00
Jorge Manrubia a7fc325184 Format 2025-04-04 17:01:30 +02:00
Jorge Manrubia 4ac2511771 Remove turbo frame for editing stages 2025-04-04 16:59:51 +02:00
Jorge Manrubia b95e528968 Render stages 2025-04-04 16:46:01 +02:00
Jorge Manrubia eb63d3fc6f Extract common layout for people 2025-04-04 16:40:39 +02:00
Jorge Manrubia 42111cbf4f Extract common layout for meta 2025-04-04 16:38:55 +02:00
Jorge Manrubia 56a3f6612a Extract common layout for assignees 2025-04-04 16:36:40 +02:00
Jorge Manrubia bb1b2a9704 Restore link to navigate to cards! 2025-04-04 16:34:28 +02:00
Jorge Manrubia 1295f80fd9 Extract common partial for the card background 2025-04-04 16:32:58 +02:00