b510ca0318
Don't choke for nil values
2025-04-23 10:56:00 +02:00
68e2e96076
Fix indentation
2025-04-23 10:44:42 +02:00
af8701567a
Extract method
2025-04-23 10:35:18 +02:00
c3cd873588
Rename collect => create
2025-04-23 10:30:30 +02:00
cdadc0373a
Don't trigger unless the mentionable content changes
...
This is also needed to prevent incorrect triggering on cascade touches!
2025-04-22 18:10:27 +02:00
a567e662e2
Fix: wrong delegation
2025-04-22 17:23:47 +02:00
9b4fec936e
Move mentions to comments
...
- It does not make sense to scan "event summaries" for notifications.
- Placing them at the message level prevents us from using the generic approach to extract the mentionable content
2025-04-22 16:17:37 +02:00
81961a3523
Fix unclosed tag
2025-04-22 15:30:03 +02:00
c75d4cb329
Fix broken permalinks
2025-04-22 15:26:56 +02:00
3bf73a0b71
Rename to match actual action
2025-04-22 14:22:23 +02:00
beac61699c
Not needed
2025-04-22 14:21:26 +02:00
d5f0359338
Extract mentionable content using reflection to remove duplicated logic and the need for additional concerns
2025-04-22 14:19:45 +02:00
9db675e589
Format
2025-04-22 14:15:40 +02:00
22df208f9a
Render proper content for mentions, don't send mentions to yourself
2025-04-22 14:11:21 +02:00
8aa99e34b4
Persist notification's creator
...
Instead of delegating. With a polymorphic relationship, relying on a certain
attribute implies doing things like aliasing "mentioner" to "creator" or similar.
2025-04-22 13:48:43 +02:00
4f06473405
Notifications for mentions showing up
2025-04-22 12:02:48 +02:00
aa3acfeaa8
Add plain text mentions
2025-04-22 11:26:56 +02:00
5b10b3a16e
Merge pull request #421 from basecamp/flavorjones-dep-rails-e9ee790d
...
dep: update rails to `e9ee790d`
2025-04-21 13:05:52 -04:00
01d741b3f4
dep: update rails
2025-04-21 13:03:49 -04:00
6d4691f32b
Merge pull request #420 from basecamp/descriptions-fix
...
Add card's description field
2025-04-21 17:28:18 +02:00
4f0cf0f5cb
Fix autosave working with the new description field
2025-04-21 17:05:35 +02:00
2c3ec3e806
Fix: Create new cards wasn't working
2025-04-21 17:00:25 +02:00
1680095266
Remove invalid "
2025-04-21 16:45:35 +02:00
b0aae3ad9e
Reapply "Add a description field for cards"
...
This reverts commit a4cc143b09
2025-04-21 16:45:24 +02:00
6392180493
Merge pull request #419 from basecamp/revert-408-add-card-description
...
Revert "Add a description field for cards"
2025-04-21 16:42:09 +02:00
a4cc143b09
Revert "Add a description field for cards"
2025-04-21 16:41:33 +02:00
4d1a1382e1
Fix seeds for new descriptions
2025-04-21 16:21:20 +02:00
9ecd7f7a60
Merge pull request #408 from basecamp/add-card-description
...
Add a description field for cards
2025-04-21 16:06:47 +02:00
fb83b5e70e
Merge branch 'main' into add-card-description
...
* main:
Fix trailing empty line
--skip-server in ci setup
Enumerate all the options for logging in
Have an empty first-run tenant too
Convert to conventional Rails style
Seed multiple seed accounts with basic DSL
Stlye
No need to run Solid Cache in development
Use morphing to replace the card and exclude turbo frames from being replaced
Name is already schema and UI required
Cards have a not-null schema and collections destroy all cards on deletion
No longer used
Inline touch check thats only used once
# Conflicts:
# app/views/cards/_container.html.erb
2025-04-21 16:04:06 +02:00
539b26c7df
Small enough DSL to inline it
2025-04-21 16:01:01 +02:00
55789b7a34
Merge pull request #416 from basecamp/replace-with-morph
...
Use morphing in the stream replace the card container
2025-04-21 15:40:28 +02:00
ad2c1ca8fc
Merge pull request #418 from basecamp/seed-multiple-dev-accounts
...
Seed multiple seed accounts with basic DSL
2025-04-21 15:27:10 +02:00
581070b22c
Fix trailing empty line
2025-04-21 15:26:47 +02:00
e1b2b623e8
--skip-server in ci setup
2025-04-21 15:26:19 +02:00
29948d8881
Enumerate all the options for logging in
2025-04-21 15:23:31 +02:00
dc12751192
Have an empty first-run tenant too
2025-04-21 15:23:18 +02:00
2bfead0381
Convert to conventional Rails style
2025-04-21 15:23:08 +02:00
99dbc04e2c
Format
2025-04-21 15:20:03 +02:00
ffdec1cc3b
Index description too
2025-04-21 15:18:11 +02:00
b6584ed655
Seed multiple seed accounts with basic DSL
2025-04-21 15:12:57 +02:00
7925cd7bf9
Extract partials
2025-04-21 14:52:21 +02:00
491e743c27
Place below associations
2025-04-21 14:48:07 +02:00
167563d9f8
Stlye
2025-04-21 14:01:53 +02:00
4b294ccaa6
No need to run Solid Cache in development
2025-04-21 13:55:09 +02:00
3e1a2bcc7e
Use morphing to replace the card and exclude turbo frames from being replaced
...
Reconnecting the frames result in a visible flickering.
This also prevents flickering in the avatars when replacing the card container.
2025-04-21 09:24:57 +02:00
89d1b316f0
Name is already schema and UI required
...
And we are not using these validations for display anywhere.
2025-04-21 09:21:55 +02:00
dc2205ee79
Cards have a not-null schema and collections destroy all cards on deletion
...
This shouldnt be necessary. Maybe remnant of some previous design?
2025-04-21 09:18:42 +02:00
48a6c05250
No longer used
2025-04-20 16:23:15 +02:00
d3fa62d4c2
Inline touch check thats only used once
...
Not worth loading an entire file for this.
2025-04-20 16:21:08 +02:00
ccd98f6d98
Update card.rb
2025-04-19 20:01:41 +02:00
Jorge Manrubia