Commit Graph

368 Commits

Author SHA1 Message Date
Jorge Manrubia aa3acfeaa8 Add plain text mentions 2025-04-22 11:26:56 +02:00
Jorge Manrubia b0aae3ad9e Reapply "Add a description field for cards"
This reverts commit a4cc143b09.
2025-04-21 16:45:24 +02:00
Jorge Manrubia a4cc143b09 Revert "Add a description field for cards" 2025-04-21 16:41:33 +02:00
Jorge Manrubia fb83b5e70e Merge branch 'main' into add-card-description
* main:
  Fix trailing empty line
  --skip-server in ci setup
  Enumerate all the options for logging in
  Have an empty first-run tenant too
  Convert to conventional Rails style
  Seed multiple seed accounts with basic DSL
  Stlye
  No need to run Solid Cache in development
  Use morphing to replace the card and exclude turbo frames from being replaced
  Name is already schema and UI required
  Cards have a not-null schema and collections destroy all cards on deletion
  No longer used
  Inline touch check thats only used once

# Conflicts:
#	app/views/cards/_container.html.erb
2025-04-21 16:04:06 +02:00
Jorge Manrubia 3e1a2bcc7e Use morphing to replace the card and exclude turbo frames from being replaced
Reconnecting the frames result in a visible flickering.

This also prevents flickering in the avatars when replacing the card container.
2025-04-21 09:24:57 +02:00
David Heinemeier Hansson 9e921b85c0 Merge branch 'main' into add-card-description 2025-04-19 20:00:43 +02:00
David Heinemeier Hansson 9cea403acd Make sure that any card getting read does not empty out the notifications tray
Since we wont rehydrate it
2025-04-18 16:32:27 +02:00
David Heinemeier Hansson f594bc09a0 Simplify
This is coming straight from the form, unlikely to blow up
2025-04-18 16:24:54 +02:00
David Heinemeier Hansson f6cd21f7cb Extract default stages into something that will be created together with a new Workflow in the model 2025-04-18 16:07:01 +02:00
David Heinemeier Hansson 1026408736 Need this for the draft header to be visible 2025-04-18 15:22:59 +02:00
David Heinemeier Hansson f3000a02c5 Follow render_card_replacement pattern
And clean up the rest of the implementation a tad.
2025-04-18 15:20:38 +02:00
David Heinemeier Hansson 7395d4e034 Removing the image can also just be done as a card replacement 2025-04-18 15:14:36 +02:00
Jason Zimdars 04f9a0f83a Merge branch 'main' into add-card-description
* main: (33 commits)
  Run beamer accessories in production only
  Less noisy logging in production
  Inline perma to container partial
  Use card replacement for card updates too
  Extract helper method to keep partial at a uniform level of abstraction
  Remove duplicated conditional
  Style
  Note that we dont want to keep reloading these frames
  I like this even better
  Suffix qualifier is unnnecessary
  Group partials for container
  Match domain language
  Fix trailing space
  Use card rerendering instead of redirects
  Better name
  Stick with domain language
  Fix tests
  Rerender instead of redirect
  Style
  Extract partials that can be rerendered
  ...
2025-04-17 16:40:23 -05:00
David Heinemeier Hansson 0e442ac0d0 Use card replacement for card updates too 2025-04-17 15:56:56 +02:00
David Heinemeier Hansson ac9cbad4f9 I like this even better 2025-04-17 15:32:09 +02:00
David Heinemeier Hansson 62088b66d1 Suffix qualifier is unnnecessary 2025-04-17 15:30:55 +02:00
David Heinemeier Hansson 4dbd8205ce Fix trailing space 2025-04-17 15:21:14 +02:00
David Heinemeier Hansson 7adbd8d634 Use card rerendering instead of redirects 2025-04-17 15:20:27 +02:00
David Heinemeier Hansson 547e5ea24f Rerender instead of redirect 2025-04-17 14:54:29 +02:00
David Heinemeier Hansson 4d0dddec46 No need to loop through a job when this is the sole point of the action 2025-04-17 14:31:28 +02:00
David Heinemeier Hansson 87ce4a623b Even clearer about where these pins are going 2025-04-17 14:31:02 +02:00
David Heinemeier Hansson 1437bcb3b7 Clearer about where these are being sent 2025-04-17 14:29:12 +02:00
David Heinemeier Hansson fc0cf3917f Pin without redirect
Use turbo stream response to save on the redirect latency
2025-04-17 14:05:26 +02:00
David Heinemeier Hansson 07e801b74c Fix pinning to tray
They need to have a complete dom element that is unique
2025-04-17 13:52:55 +02:00
David Heinemeier Hansson a5de4863fa Allow for multiple notifications to be read
cc @kevinmcconnell
2025-04-17 11:39:37 +02:00
Kevin McConnell 6c8fe164b3 Read a card should dismiss all notifications
Previous code assumed that there was a single notification to dismiss
for that card, but in practice there can be zero or many. If it's zero,
we need to avoid the crash. If it's many, we should dismiss them all.

Also re-rendering the notification stack after dismissing enables us to
remove all the removed cards, as well as reveal any older ones that were
previously outside the visible page size.

This reverts commit 6135909b7e.
2025-04-17 09:40:59 +01:00
Jason Zimdars d257cb5fb6 No longer used 2025-04-16 18:57:47 -05:00
Jason Zimdars 7b3b5c471b Add a description filed for cards 2025-04-16 18:53:26 -05:00
David Heinemeier Hansson 5dc6e0394f Style 2025-04-16 17:12:20 +02:00
David Heinemeier Hansson d8ec2c3364 More natural to fetch that which will be shown first 2025-04-16 16:58:03 +02:00
David Heinemeier Hansson 6135909b7e Card readings just need to remove the notification
No need to broadcast everything again
2025-04-16 16:51:18 +02:00
David Heinemeier Hansson 98401b9536 Explain this 2025-04-16 16:44:04 +02:00
David Heinemeier Hansson 4bb9085737 Hide implementation detail of reading 2025-04-16 16:41:22 +02:00
David Heinemeier Hansson 8ff71b2650 Dont turbo stream when coming from a read_all redirect 2025-04-16 16:21:31 +02:00
David Heinemeier Hansson 5932bf9316 This is rare enough that a redirect is fine 2025-04-16 16:21:16 +02:00
David Heinemeier Hansson d00a0433e9 Inline anemic method 2025-04-16 15:34:28 +02:00
David Heinemeier Hansson 73f272f132 Use one controller for all notification readings 2025-04-15 19:14:50 +02:00
David Heinemeier Hansson 2ea898324f We can just set the namespace directly in the class name 2025-04-15 16:36:40 +02:00
David Heinemeier Hansson 680611503d Distinguish between administering and just changing 2025-04-15 16:00:29 +02:00
David Heinemeier Hansson 2ace519d91 There is only one account, so just check join code directly 2025-04-15 15:35:10 +02:00
Andy Smith a88264ed0a Merge branch 'main' into consolidate-cards
* main: (94 commits)
  Source order seems to be significant
  Use `card.title`
  Nicer flow
  Fix string interpolation
  Fix constant
  Use record lookup
  Always use sole
  Explained less and extracted nothing of value
  Weird double negative
  Remove anemic and indirect method that explained nothing
  Can use record lookup for workflows
  Access control has already been done through the card
  Style
  Use _path in all cases where we are not potentially changing the domain
  Clearer
  Spacing
  Get rid of card_title
  Join the two users controllers but split out role setting
  Ensure user is returned
  We are not using the parameter
  ...
2025-04-14 09:40:22 -05:00
Jason Zimdars 289487a383 Source order seems to be significant
Regressed in d3c5c86b21
2025-04-14 09:23:57 -05:00
David Heinemeier Hansson cfb345bc32 Nicer flow 2025-04-13 20:39:09 +02:00
David Heinemeier Hansson e8a730c239 Fix constant 2025-04-13 20:36:07 +02:00
David Heinemeier Hansson 34232c0e31 Use record lookup 2025-04-13 20:30:03 +02:00
David Heinemeier Hansson d9a9690137 Always use sole 2025-04-13 20:29:10 +02:00
David Heinemeier Hansson 9e0b9c08c2 Explained less and extracted nothing of value 2025-04-13 20:28:35 +02:00
David Heinemeier Hansson 33278469ef Weird double negative 2025-04-13 20:26:58 +02:00
David Heinemeier Hansson a5df54015e Remove anemic and indirect method that explained nothing 2025-04-13 20:25:59 +02:00
David Heinemeier Hansson e2a931b657 Can use record lookup for workflows 2025-04-13 20:24:16 +02:00