Commit Graph

105 Commits

Author SHA1 Message Date
Jose Farias 11e9e691bf Clean up test names 2024-11-25 20:35:53 -06:00
Jose Farias 3e1b2c74e4 Make one-way assignment and tagging methods private 2024-11-25 17:55:25 -06:00
Jose Farias 36d930cd0e Add tests for tagging and assigning 2024-11-25 17:49:28 -06:00
Jose Farias 5e09f5a9b9 Remove swapping 2024-11-25 16:17:44 -06:00
Jose Farias f266e46b57 Wire up comboboxes 2024-11-21 19:58:21 -06:00
Jose Farias e117f4e5af boost_count -> boosts_count
This aligns better with counter_cache conventions, in case we turn boosts into a model later
2024-11-19 14:22:51 -06:00
Jose Farias c88fefd92a Clean up activity score tests 2024-11-19 14:18:27 -06:00
Jose Farias df746e5a64 Merge branch 'main' into activity-score
* main:
  Missed one
  Tighten up workflow panel
  Fix test
  Forget about the dividing line for now
  Add some structure to buckets index
  Adjust form
  Restore bucket settings link, adjust styles for filters
  No need for inline svg here anymore
2024-11-19 13:38:39 -06:00
Jose Farias 0c38699dec Merge branch 'main' into activity-score
* main: (22 commits)
  Fix layout issue that caused comment form to be unselectable
  Stick with stock buttons for now
  Still a little odd that it's a separate form but this conceptually belongs here
  We've got a utility for this
  Fix navbar alignment
  Kind of hate that icon, let's try something else
  Use new bubble shape
  Prevent bubble getting squished
  Fix image fit, try animation
  Don't assume `@filter` is set
  Clicking assignees filters by that assignee
  Restore behavior: clicking tags filters by that tag
  Make these consist from view-to-view
  Improve hover motion for meta bubbles
  No longer used
  Improve assignee bubble display, especially when there are multiple assignees
  name -> key
  ** not required
  Swap one? and many? branches
  Change title based on selected buckets
  ...
2024-11-19 13:09:57 -06:00
Jason Zimdars fada5fef59 Fix test 2024-11-19 12:52:39 -06:00
Jose Farias 0c51129e1e name -> key 2024-11-18 12:04:52 -06:00
Jose Farias 0995eee074 Turn filter chips into links 2024-11-18 11:34:44 -06:00
Jose Farias f1c8ae2f5f No need to pluck title
Was a debugging artifact
2024-11-15 18:21:39 -06:00
Jose Farias b4e8adca47 Pre-calculate comment counts and activity scores 2024-11-15 18:17:42 -06:00
Jose Farias fb04249209 Make filters into a simple form 2024-11-14 21:50:38 -06:00
Jose Farias 4dfba46142 Fix tests 2024-11-13 13:55:30 -06:00
Jose Farias af1aa3fd62 Test field accessors 2024-11-13 13:51:54 -06:00
Jose Farias bef8882490 Test filter chips controller 2024-11-13 13:44:33 -06:00
Jose Farias a3fb92d506 Test filter terms 2024-11-13 13:39:04 -06:00
Jose Farias 458a6a1ac2 Wire up assigner filters 2024-11-13 13:34:51 -06:00
Jose Farias 768b48ea03 Use Filter class method to digest fixture params 2024-11-13 12:08:23 -06:00
Jose Farias eff8539b66 Fix test 2024-11-11 14:23:00 -06:00
Jose Farias d455b72906 Hash filter params 2024-11-08 15:17:55 -06:00
Jose Farias 75d2b793a3 Increase filter tests specificity 2024-11-07 16:52:49 -06:00
Jose Farias da37fa56d8 Add some more tests for bubble filters 2024-11-07 16:13:00 -06:00
Jose Farias 5cc4aa0634 Simplify filter destruction 2024-11-07 16:09:12 -06:00
Jose Farias 77a9b267d8 Split out fields and params for filters 2024-11-07 12:44:26 -06:00
Jose Farias 201a543a9b Assert params after resource removal 2024-11-07 11:34:56 -06:00
Jose Farias ec04ccef4d Test param sanitization 2024-11-06 18:22:10 -06:00
Jose Farias 9efe94a277 idempotent_create -> persist 2024-11-06 18:09:55 -06:00
Jose Farias 12ce07639d Add tests 2024-11-06 17:49:14 -06:00
Jose Farias 3d9d169477 Many-to-many relationship for filters and filterables 2024-11-05 21:21:46 -06:00
Jose Farias ca6d018106 Attribute filter fixture to david 2024-11-05 15:45:13 -06:00
Jose Farias f3b456c551 Fix tests 2024-11-05 14:14:33 -06:00
Jose Farias f2706d0f74 Unnest bubble filters 2024-11-05 13:04:05 -06:00
Jose Farias e92da7c73a Test EventSummary bodies 2024-10-27 20:30:15 -06:00
Jose Farias ca0abdb3a5 Test capturing 2024-10-27 20:23:28 -06:00
Jose Farias a64752e573 Clear up messages integration test 2024-10-27 20:21:32 -06:00
Jose Farias 9e60362ca7 Write messages integration test 2024-10-27 20:17:34 -06:00
Jose Farias 2fb6ed76b3 Fix comments-dependent scopes 2024-10-27 19:50:06 -06:00
Jose Farias 0727414017 Lean into delegated types APIs 2024-10-27 17:39:30 -06:00
Jose Farias 4cd5dc0b35 Fix event tests 2024-10-27 12:33:51 -06:00
Jose Farias ede04d6d96 Fix search tests 2024-10-27 12:33:33 -06:00
Jose Farias f9712ea53f Messageables don't belong to bubble directly 2024-10-27 11:57:33 -06:00
Jose Farias 85d47a35ab threadables -> messageables 2024-10-25 15:03:31 -06:00
Jose Farias d88d9437f8 Clean up bubble tests 2024-10-24 18:21:06 -06:00
Jose Farias c57f18c20c Materialize abstract thread
The domain language is clearer if we just persist a thread. Also rename some models so their purpose is clear.
2024-10-24 17:36:14 -06:00
Jose Farias ad88f90302 Fine not to denormalize user names in events 2024-10-24 15:50:00 -06:00
Jose Farias 86e69c3989 Reorder events fixtures attributes 2024-10-24 11:33:06 -06:00
Jose Farias c41da5837c Add back bubble association to events 2024-10-24 11:22:23 -06:00