Commit Graph

1364 Commits

Author SHA1 Message Date
Mike Dalessio b7e5ca780c Extract the EventsTimeline controller concern 2025-03-26 07:37:42 -04:00
Kevin McConnell f099ab4dd9 Add console alias 2025-03-26 10:53:19 +00:00
Jason Zimdars 3bde5fdc1c Comments, list and font improvements 2025-03-25 16:59:13 -05:00
Jason Zimdars 2e390e31b8 Use variable 2025-03-25 15:06:25 -05:00
Jason Zimdars 07c2c53c49 Close attribute 2025-03-25 15:06:25 -05:00
Jason Zimdars 46cd84f306 Remove divider 2025-03-25 15:06:25 -05:00
Jason Fried eb54c6fa6d Thinner gridlines on home. 2025-03-25 12:29:34 -07:00
Mike Dalessio c7e8f78253 dep: update active_record-tenanted for db:reset support
and update some other dependencies along the way.
2025-03-25 15:01:45 -04:00
Mike Dalessio c4500befa6 Merge pull request #323 from basecamp/flavorjones-activity-loading-fix
Load past activity when collections list is quite long
2025-03-25 14:11:59 -04:00
Mike Dalessio 733e7f0b09 Load past activity when collections list is quite long
ref: https://37s.fizzy.37signals.com/buckets/693169850/bubbles/999008733

This moves the "fetch-on-visible" link to right after the
"div#activity" to which it will append, so that it immediately
triggers if the first day's grid is short.

The link previously was at the end of the page, meaning that a long
list of Collections would push it out of the viewport, requiring a
scroll before loading the next day.
2025-03-25 14:10:52 -04:00
Mike Dalessio 70519c4664 Merge pull request #322 from basecamp/flavorjones-remove-buckets-index
Remove the buckets#index action and view
2025-03-25 13:45:28 -04:00
Mike Dalessio 23e4fd9b1c Remove the buckets#index action and view
and have bucket#destroy redirect to root_path
2025-03-25 13:40:36 -04:00
Mike Dalessio 95a7406b67 Restore commenting and subscriber bar
removed in 403a328e
2025-03-25 09:43:26 -04:00
Jason Zimdars fa248c035d Alignment 2025-03-24 17:46:29 -05:00
Jason Zimdars 403a328ef8 Walk-back two-column comments design 2025-03-24 17:43:43 -05:00
Jason Zimdars abeb0762f6 Untangle list 2025-03-24 17:27:24 -05:00
Jason Zimdars c9a8f73134 Avoid wrapping 2025-03-24 17:04:18 -05:00
Jason Zimdars 7c54a20ece DRY this up a bit 2025-03-24 17:04:08 -05:00
Jason Zimdars ebca0caa03 Square headers, correct centering, use --grid-lines variable throughout 2025-03-24 16:36:13 -05:00
Mike Dalessio 7e65c3f325 Merge pull request #319 from basecamp/flavorjones-sidebar-no-more
Move tags and assignments partials out of "bubbles/sidebar"
2025-03-24 17:16:06 -04:00
Mike Dalessio a66dc2a789 Move tags and assignments partials out of "bubbles/sidebar"
They're part of the card now, let's name them that way.

Also, rename the "tag" partial to "tagging", following the naming
convention established by the controller.
2025-03-24 17:11:58 -04:00
Mike Dalessio 48dea279c8 Merge pull request #318 from basecamp/flavorjones-tag-list-cache
Card "tags" dropdown is no longer subject to the card fragment cache
2025-03-24 16:57:50 -04:00
Mike Dalessio 5ae87d8140 Ensure the tags dropdown is not subject to the cached card fragment
- Rearrange the _tags and _tag partial, so they are properly nested concerns
- Add turbo frames for _tags and _tag
- Load _tag in a separate request, so it's not cached with the card
- Cache _tag using the bubble and the account
- New model behavior: touch Account when tags are added or removed
- New controller action: "new" for taggings toggles, which renders the _tag partial
- Updating taggings responds with a turbo stream response that updates the _tags frame

This is very much a parallel change to what was done with assignments
in #317.
2025-03-24 16:48:11 -04:00
Mike Dalessio 506f74144b Touch Account when adding or removing a Tag
so we can properly cache the tags partial using account as part of the key.
2025-03-24 16:48:11 -04:00
Jason Zimdars 9c690c5822 Don't display before login 2025-03-24 15:19:51 -05:00
Mike Dalessio df377861fc Merge pull request #317 from basecamp/flavorjones-assignee-card-cache
Assignee dropdown no longer subject to the card fragment cache
2025-03-24 15:27:53 -04:00
Jason Zimdars bc5858081a Make sure back restores any active filters 2025-03-24 14:15:45 -05:00
Jason Zimdars 4bc125c7eb Load the form in a turbo frame so focused field doesn't intercept hotkeys 2025-03-24 14:15:28 -05:00
Jason Zimdars 9b9e09601e Introduce text-based UI 2025-03-24 11:33:04 -05:00
Mike Dalessio 44650cc36e Reload the assignees turbo frame when assigments are updated
Also, add a cache around the dropdown keyed on [bubble, bucket].
2025-03-21 17:53:41 -04:00
Mike Dalessio a830ec1999 Extract an "assignees" partial
pulling the avatars down from the "people" partial, and pulling the
add button up from the "assignment" partial.

The result is:

- the "bubbles/sidebar/assignment" partial is just the dialog box
- the "bubbles/assignees" partial contains everything about assignees
- the "bubbles/people" partial makes one render call

and I've introduced some turbo frames in the expectation of the next
commit which will load the dialog in the background.
2025-03-21 17:20:14 -04:00
Jason Zimdars cbc9567966 Smaller tray cards 2025-03-21 14:54:26 -05:00
Mike Dalessio 3689d7770e Merge pull request #314 from basecamp/flavorjones-tenanted-action-mailer
Configure tenanted Action Mailer URL helpers
2025-03-20 22:03:14 -04:00
Mike Dalessio 4992c3f971 Set up tenanted Action Mailer URL helpers
and update AR::Tenanted to a version that supports it.
2025-03-20 21:58:36 -04:00
Jason Zimdars 53b906423a Overflow needs to be on the nearest item 2025-03-20 18:12:43 -05:00
Jason Zimdars 39ebeadc08 Hide button when empty 2025-03-20 18:04:39 -05:00
Jason Zimdars 9dba039096 Missing class 2025-03-20 17:59:29 -05:00
Jason Zimdars eaf927f1a8 Refactor tray styles 2025-03-20 17:54:24 -05:00
Jason Zimdars 0da84efd01 Tray pins design 2025-03-20 16:52:56 -05:00
Jason Zimdars 1802a6391a Tweak events and dates 2025-03-20 13:54:56 -05:00
Mike Dalessio 9a23a7470e doc: update README with a section on testing
[skip ci]
2025-03-20 13:20:56 -04:00
Mike Dalessio 6b039b71ab Add a post-deploy hook to tag the release and post to basecamp
These scripts were only slightly modified from the versions in bc3
2025-03-20 13:17:11 -04:00
Mike Dalessio 7ad6e6850f dep: bundle update (solid_queue) 2025-03-20 13:10:09 -04:00
Mike Dalessio 10d4fc0fd8 dep: bundle update (rails, nokogiri) 2025-03-20 13:05:34 -04:00
Mike Dalessio c167b971b9 Add bin/ci 2025-03-20 12:57:28 -04:00
Jason Zimdars 0e0513dd77 Try addressing clipped descenders another way 2025-03-20 11:52:33 -05:00
Jason Zimdars 2f2dd1248d Revert "Address line-height"
This reverts commit efaeb26fab.
2025-03-20 11:52:33 -05:00
Mike Dalessio 947b963157 Merge pull request #308 from basecamp/flavorjones-fix-card-cache-on-bucket-change
Use the bucket name as part of the card cache key
2025-03-20 12:49:54 -04:00
Mike Dalessio 473703df3d Invalidate the bubble cache when the bucket name changes
by including the bucket name as part of the bubble cache key.

ref: https://37s.fizzy.37signals.com/buckets/693169850/bubbles/999008709

Co-authored-by: Kevin McConnell <kevin@37signals.com>
2025-03-20 12:46:23 -04:00
Jason Zimdars 2e0f787777 Polish trays behavior 2025-03-20 11:41:17 -05:00