Commit Graph

4858 Commits

Author SHA1 Message Date
Jorge Manrubia bf6f4cf2ba Reorded method and remove unnecessary param 2025-09-12 14:46:05 +02:00
Jorge Manrubia 57225e7c9a Add migration to convert accesses 2025-09-12 14:38:20 +02:00
Jason Zimdars d9d3e9f1a2 Update VCR for highlights tests
I don't see how this is related to my changes but it keeps failing
2025-09-11 22:32:04 -05:00
Jason Zimdars 76e2ae47f7 Tighten this up 2025-09-11 21:59:28 -05:00
Jason Zimdars 9ad813e5d0 Fix misleading test
The access involvement changes exposed that this test wasn't doing what it said it was. For this to be a self-assignment the event creator and assignee need to be the same
2025-09-11 21:33:21 -05:00
Jason Zimdars c4dec29b49 Assignment notifications should always be delivered
- They're effectively @mentions
- This means watching really reflects the UI state: Watching for new cards
2025-09-11 21:21:11 -05:00
Jason Zimdars 34e5b14b58 Move the watchers list into the turbo frame
Passes around a param to opt-out of rendering the watchers on the
notification settings screen
2025-09-11 18:05:34 -05:00
Jason Zimdars f9aed44fd2 Move involvement toggle and display all the watchers 2025-09-11 16:22:57 -05:00
Jason Zimdars e68b344cc2 Remove _Everything_ inolvement 2025-09-11 12:34:31 -05:00
Andy Smith 2a3cb28891 Merge pull request #1082 from basecamp/print-tweaks
A couple more print style tweaks
2025-09-10 17:21:18 -05:00
Jorge Manrubia ef6bd0daf6 Revert "Quick test for production I'll revert"
This reverts commit f05320287d.
2025-09-10 23:47:40 +02:00
Jason Zimdars 263f2d6201 Merge branch 'bring-back-not-assigned-on-perma' 2025-09-10 16:46:44 -05:00
Jason Zimdars 67f76e8874 We have space here to show it
And it makes the assignment UI clearer on the perma
2025-09-10 16:45:32 -05:00
Andy Smith c8b5b7397f A couple more print style tweaks 2025-09-10 16:44:04 -05:00
Jorge Manrubia f05320287d Quick test for production I'll revert 2025-09-10 23:35:44 +02:00
Andy Smith ccd18def01 Merge pull request #1080 from basecamp/print-styles
Print styles
2025-09-10 16:29:50 -05:00
Jason Zimdars 37b980c96c Merge pull request #1081 from basecamp/jz-9-10-25
JZ 9/10/25
2025-09-10 16:05:43 -05:00
Jason Zimdars a532d2d89b Adjust to there is no editing jog 2025-09-10 15:57:40 -05:00
Jason Zimdars b1c98a3eca Attempt to fix Windows line-height issue
https://fizzy.37signals.com/5986089/cards/1467
2025-09-10 15:53:00 -05:00
Jason Zimdars 4b8d777e16 Fix that two-column layout 2025-09-10 15:51:55 -05:00
Jason Zimdars 537fb15f95 Hide the progress bar 2025-09-10 13:46:02 -05:00
Jason Zimdars f7847717e9 Add a nicer effect when sticky 2025-09-10 13:42:52 -05:00
Jason Zimdars ed0b15f843 Consider the state where there is no activity yet
https://fizzy.37signals.com/5986089/cards/1582
2025-09-10 13:28:09 -05:00
Andy Smith ab0b3055c9 Cleanup 2025-09-10 13:18:59 -05:00
Jason Zimdars 9fe38ec8d1 Remove unimplemented closure filter
https://fizzy.37signals.com/5986089/cards/1558
2025-09-10 13:16:30 -05:00
Jason Zimdars 53e0950e24 Forward slash is better because period followed by a comma is awkward 2025-09-10 13:09:44 -05:00
Jason Zimdars 8f9e49c18e Save space by avoiding "and" 2025-09-10 13:06:29 -05:00
Andy Smith 22f9c9d168 WIP 2025-09-10 12:15:31 -05:00
Jorge Manrubia e08bbace69 Merge pull request #1076 from basecamp/cache-busted
Fix some issues with stale data due to caching
2025-09-10 17:41:19 +02:00
Jorge Manrubia 312c5c7331 Fix some cache invalidation problems
- https://fizzy.37signals.com/5986089/cards/1585
- https://fizzy.37signals.com/5986089/cards/1616
2025-09-10 17:37:13 +02:00
Jorge Manrubia 23d2512525 Bust user filtering cache when the displayed associations change 2025-09-10 16:55:37 +02:00
Jorge Manrubia 5345859d5c Merge pull request #1075 from basecamp/fallback-for-card-urls
Add redirect for old card paths
2025-09-10 15:17:32 +02:00
Jorge Manrubia 2999d351d3 Add redirect for old card paths 2025-09-10 15:16:49 +02:00
Jorge Manrubia f4ad6800f3 Script to migrate comments to new URL scheme 2025-09-10 12:24:15 +02:00
Jorge Manrubia 4b1f27057c Merge pull request #1074 from basecamp/notifications-issues
Notifications issues
2025-09-10 11:50:05 +02:00
Jorge Manrubia d345f707a1 Remove job test 2025-09-10 11:47:17 +02:00
Jorge Manrubia 4e72566856 Flatten card resource
We only need the parent collection for creating cards. Carrying it in the
rest of actions is a hassle.
2025-09-10 11:24:23 +02:00
Jorge Manrubia 7f7ecf0346 Delete notifications when the user loses access to the collection 2025-09-10 10:24:20 +02:00
Jorge Manrubia 2e51a34694 Extract method to fetch all the notifications for a card for a given user
We'll need to handle access changes
2025-09-10 10:08:14 +02:00
Jorge Manrubia b9c7ac225a Extract method 2025-09-10 10:07:58 +02:00
Jorge Manrubia 58c525e5a6 Broadcast notifications that are deleted
To prevent 404s when someone doesn't refresh the page
2025-09-10 09:50:22 +02:00
Jorge Manrubia 4cb090a23d Reorder 2025-09-10 09:38:18 +02:00
Jorge Manrubia 2752cd80b1 Merge pull request #1073 from basecamp/move-bulk-read
Use vanilla resources for handling notifications
2025-09-10 09:28:46 +02:00
Jorge Manrubia d533f05c7b Use vanilla resources for handling notifications 2025-09-10 09:17:57 +02:00
Jason Zimdars 6b01807e68 Merge pull request #1072 from basecamp/jz/fixes
Jz/fixes
2025-09-09 23:05:29 -05:00
Jason Zimdars b634d455f9 Menu above filters 2025-09-09 23:04:38 -05:00
Jason Zimdars 741cc74a9e Hide in pinned cards 2025-09-09 23:03:03 -05:00
Jason Zimdars 2a365a5683 Merge pull request #1071 from basecamp/card-meta-update
Just show icons for the second column
2025-09-09 22:53:48 -05:00
Jason Zimdars 825522158c Just show icons for the second column 2025-09-09 22:52:19 -05:00
Jason Zimdars 972732cbde Merge pull request #1070 from basecamp/bring-back-filter-terms
Bring back filter terms
2025-09-09 22:50:26 -05:00