Commit Graph

1803 Commits

Author SHA1 Message Date
Andy Smith c853d3c570 Merge branch 'main' into consolidate-cards
* main: (31 commits)
  Style drafted cards
  Considering needs to include drafted cards or you'll never be able to see them
  This item makes no sense until it's saved
  Tighten engagement switch design, only display it for published cards
  Needed to come first
  In order of appearance
  Schema movement -- is this because the dumper doesnt sort deterministically? cc @flavorjones
  Move comments under cards
  Fix indention
  Refresh timers when morphing happens
  Extract helper for card articles, use classes to determine when to show golden status
  Only consider golden those cards in "doing"
  Fix recently completed order for good!
  Place recently closed cards first
  Monkey patch a prepend_order method
  Rename inconsistency: go with goldness
  Touch
  Use gild/ungild
  Format
  Fix test
  ...
2025-04-11 12:43:05 -05:00
Andy Smith 29fbfe3b9f Remove comments 2025-04-11 12:27:15 -05:00
Jason Zimdars df96ee80fa Style drafted cards 2025-04-11 12:21:14 -05:00
Jason Zimdars 5997ef2c70 Considering needs to include drafted cards or you'll never be able to see them 2025-04-11 12:08:05 -05:00
Jason Zimdars 76336a52d6 This item makes no sense until it's saved 2025-04-11 11:56:26 -05:00
Jason Zimdars ee8559343a Tighten engagement switch design, only display it for published cards 2025-04-11 11:50:09 -05:00
Andy Smith 4a8398e318 Remove unused partials 2025-04-11 11:11:31 -05:00
Andy Smith c9b1d6d868 Style pinned cards 2025-04-11 11:09:04 -05:00
David Heinemeier Hansson f2811803d3 Needed to come first 2025-04-11 16:32:06 +02:00
David Heinemeier Hansson adabfba636 In order of appearance 2025-04-11 16:31:16 +02:00
David Heinemeier Hansson 0084dde686 Merge pull request #397 from basecamp/move-comments-under-cards
Move comments under cards
2025-04-11 16:26:43 +02:00
David Heinemeier Hansson cbdb9aa113 Schema movement -- is this because the dumper doesnt sort deterministically? cc @flavorjones 2025-04-11 16:24:38 +02:00
David Heinemeier Hansson f4ce57e308 Move comments under cards 2025-04-11 16:21:44 +02:00
David Heinemeier Hansson 64b529ce94 Fix indention 2025-04-11 16:12:18 +02:00
Jorge Manrubia 67917ff4d1 Merge pull request #396 from basecamp/fix-turbo-morph-issue
Refresh timers when morphing happens
2025-04-11 13:26:38 +02:00
Jorge Manrubia ba6eab509c Refresh timers when morphing happens 2025-04-11 13:26:01 +02:00
Jorge Manrubia 4e91d8a666 Merge pull request #395 from basecamp/golden-doing
Only consider golden those cards in "doing"
2025-04-11 12:04:00 +02:00
Jorge Manrubia 825bbf808e Extract helper for card articles, use classes to determine when to show golden status 2025-04-11 12:01:52 +02:00
Jorge Manrubia aef75feead Only consider golden those cards in "doing" 2025-04-11 11:49:52 +02:00
Jorge Manrubia 1275abd99e Fix recently completed order for good! 2025-04-11 11:37:02 +02:00
Jorge Manrubia 66b5732264 Place recently closed cards first 2025-04-11 11:27:38 +02:00
Jorge Manrubia bf038c7a74 Merge pull request #392 from basecamp/gold-cards
Gold cards
2025-04-11 10:49:45 +02:00
Jorge Manrubia 17aa9b97e9 Monkey patch a prepend_order method 2025-04-11 10:28:12 +02:00
Jorge Manrubia 4f3f322528 Rename inconsistency: go with goldness 2025-04-11 10:22:18 +02:00
Jorge Manrubia eae1669ac3 Touch 2025-04-11 10:20:30 +02:00
Jorge Manrubia 806609e77b Use gild/ungild 2025-04-11 10:20:06 +02:00
Jorge Manrubia b4297ab852 Format 2025-04-11 09:57:45 +02:00
Jorge Manrubia f4b2bec5ce Fix test 2025-04-11 09:57:45 +02:00
Jorge Manrubia 492a42ba92 Not needed anymore 2025-04-11 09:57:45 +02:00
Jorge Manrubia 5360b4ccb4 Add comment 2025-04-11 09:57:45 +02:00
Jorge Manrubia 1bac0b84b3 Add tests 2025-04-11 09:36:24 +02:00
Andy Smith 70a59eb341 WIP pins 2025-04-10 17:42:17 -05:00
Jason Zimdars da7a30203c Style golden cards 2025-04-10 17:14:04 -05:00
Andy Smith 57c76b6259 Consistent card resizing 2025-04-10 17:09:06 -05:00
Jason Zimdars 5560976091 Merge branch 'main' into gold-cards
* main:
  Try a segmented toggle for engagement
  Fix tests
  Rework min card design and meta section for all cards
  Move `title` to the `img` element so we get hover in both cases
  Remove sorting filter UI
  Sort Considering and Doing by `updated_at`
  Restore comment action icon
  Fix dot escaping container
  Seen cards should be flat
  Ensure overflow cards are hidden
  Arrow needs to match derived color
  Dialog target needs to be present
  This isn't necessary in the mini card template
  Revert "The button and dialog need not render in previews"
2025-04-10 16:42:45 -05:00
Jason Zimdars 0c107c5894 Fix that cards which were Drafted or in Considering were also being displayed in Doing
CC: @jorgemanrubia
2025-04-10 16:42:40 -05:00
Andy Smith 7ef49ccffa Polish up columns 2025-04-10 16:16:36 -05:00
Jason Zimdars 81ee2ab64d Try a segmented toggle for engagement 2025-04-10 16:06:35 -05:00
Andy Smith 7c3c3a9ef5 Less space above card-perma 2025-04-10 15:44:45 -05:00
Andy Smith 74d1571b19 Merge branch 'main' into consolidate-cards
* main: (45 commits)
  Fix tests
  Rework min card design and meta section for all cards
  Move `title` to the `img` element so we get hover in both cases
  Remove sorting filter UI
  Sort Considering and Doing by `updated_at`
  Restore comment action icon
  Fix dot escaping container
  Seen cards should be flat
  Ensure overflow cards are hidden
  Arrow needs to match derived color
  Dialog target needs to be present
  This isn't necessary in the mini card template
  Revert "The button and dialog need not render in previews"
  Paginate collection cards
  Add a rails helper for the new custom stream action
  Add test
  Reflect picked color automatically with a custom stream action
  Simplify conditions to pick up a color
  Reuse existing constant
  Update fixtures and test
  ...
2025-04-10 15:12:38 -05:00
Andy Smith 2d17e86945 Flat card styles 2025-04-10 15:02:03 -05:00
Andy Smith 8429669bf5 WIP card columns 2025-04-10 14:56:52 -05:00
Jason Zimdars ca067f7ca0 Fix tests
This is cheating a little because Doing and Considering are both always sorted by Latest at the moment. Keeping it like this while we vet this new direction
2025-04-10 14:42:42 -05:00
Jason Zimdars e4110734eb Rework min card design and meta section for all cards 2025-04-10 14:39:50 -05:00
Jason Zimdars 7fdf9ab2fd Move title to the img element so we get hover in both cases 2025-04-10 14:39:19 -05:00
Andy Smith 5b4a6b51a7 Extract perma container and filters into separate files 2025-04-10 13:27:55 -05:00
Andy Smith 59798124cb Extract doing toggle into partial 2025-04-10 13:22:06 -05:00
Andy Smith f319c22f62 Use grid for card-container 2025-04-10 13:02:38 -05:00
Andy Smith e062a80111 Refactor container BEM names 2025-04-10 12:34:44 -05:00
Andy Smith bcc2952b1a Stub out variants 2025-04-10 12:00:33 -05:00