Commit Graph

7027 Commits

Author SHA1 Message Date
Mike Dalessio cec94ff570 Merge pull request #1623 from basecamp/flavorjones/fix-reloading-in-development
Move AccountSlug::Extractor later in the stack for reloading in development
2025-11-18 09:27:47 -05:00
Mike Dalessio 3b717bbe0d Move AccountSlug::Extractor later in the stack
so that in development, it runs after reloading; but still before the
database selector middleware in case we ever want to do something
account-specific.
2025-11-18 09:20:47 -05:00
David Heinemeier Hansson 444d43f2ac Its been a few days 2025-11-18 14:52:07 +01:00
David Heinemeier Hansson 6e304958be No need to protect local dev/test 2025-11-18 14:32:54 +01:00
Kevin McConnell 2661c7ba63 Update LB scripts for production deployment 2025-11-18 12:52:23 +00:00
Andy Smith 249c06e4f6 Straighten out focus ring for the background image button 2025-11-18 11:29:40 +00:00
Andy Smith 7c8ebd1f02 Make sure assign button isn't tabbable when previewing 2025-11-18 11:29:31 +00:00
Andy Smith da5708b45c Update z-index 2025-11-18 11:29:23 +00:00
Kevin McConnell 9b3b2f5d29 Prevent pinning writes in non-primary DCs 2025-11-18 11:03:58 +00:00
Jorge Manrubia b335eab6de Merge pull request #1622 from basecamp/open-filter
Fix: don't show closed cards by default when filtering by "created by"
2025-11-18 11:43:22 +01:00
Jorge Manrubia 4a86e3a298 Don't show closed carsd when filtering by "added by"
You can still select the done filter if you want to.

https://app.fizzy.do/5986089/cards/2639
2025-11-18 11:40:01 +01:00
Jorge Manrubia 793aace69a Remove implicit order when filtering by closed cards
We set the order in the dedicated column controllers and we don't want this in place when using composable filters.

Also, this raises an error with the MySQL move when combined with assignees. Because we inject a .distinct there,
that messes up with the query select, resulting in having to add a redundant select to the closed sorting scope, so that
the closure.created_at is not lost.
2025-11-18 11:36:47 +01:00
Jorge Manrubia 38bb47a883 Merge pull request #1621 from basecamp/selection-no-one
Fix: Filter by "no one" assigned
2025-11-18 10:21:01 +01:00
Jorge Manrubia b55bd70a8a Make system test stable
We need to wait for the request to materialize before checking the DB
2025-11-18 10:20:02 +01:00
Jorge Manrubia 4deb310497 Fix: Filter by "no one" assigned
This also adds support to make some selection items exclusive in the combo boxes.
2025-11-18 10:13:13 +01:00
Kevin McConnell d584950457 Consolidate staging MySQL replica hostname 2025-11-18 08:29:42 +00:00
Jorge Manrubia 780d262093 Merge pull request #1606 from basecamp/plan-b+refresh-notifications
Reload notifications tray when the window regain the focus
2025-11-18 09:16:07 +01:00
Jorge Manrubia 96dc68a91b Merge pull request #1620 from basecamp/wrong-icon
Fix: use the move icon for cards that are triaged or postponed too
2025-11-18 09:13:55 +01:00
Jorge Manrubia 0d2870c1f9 Fix: use the move icon for cards that are triaged or postponed too
https://app.fizzy.do/5986089/cards/2905#comment_994785588
2025-11-18 09:10:39 +01:00
Jorge Manrubia 6269f3c47e Reload notifications tray when the window regain the focus
https://app.fizzy.do/5986089/cards/2743

It includes a debounce interval to avoid too many of these.
2025-11-18 08:49:19 +01:00
Mike Dalessio d8f935498a ActiveRecord::Type::Uuid#hex
to make it easier to convert when we have to look in the logs
2025-11-17 20:04:43 -05:00
Jason Zimdars 5964431fc4 Merge pull request #1592 from basecamp/add-nav-logotype
Add logotype to nav
2025-11-17 18:03:50 -06:00
Jason Zimdars a4ada7df20 Add logotype to public layout, too 2025-11-17 18:01:51 -06:00
Jason Zimdars ffabf4482d Merge pull request #1619 from basecamp/jz-11-17-25
JZ 11-17-25
2025-11-17 17:47:49 -06:00
Jason Zimdars cc9363987f Update test 2025-11-17 17:44:34 -06:00
Jason Zimdars f11ec1187c Keep padding the same all around 2025-11-17 17:40:26 -06:00
Jason Zimdars eeeb3a6e7e Remove extra mark-up 2025-11-17 17:38:25 -06:00
Jason Zimdars 51a9edf419 Contain hotkeys inside the button 2025-11-17 17:35:14 -06:00
Jason Zimdars def42d3375 Use symbols when reasonable 2025-11-17 17:35:01 -06:00
Jason Zimdars e3e56e8289 Hide hotkeys on mobile 2025-11-17 17:07:28 -06:00
Jason Zimdars 14d9d317ff Panels now need a specific upperbound in these cases 2025-11-17 17:05:44 -06:00
Jason Zimdars 13dce732b2 Fussy punctuation 2025-11-17 17:01:08 -06:00
Jason Zimdars 385b70eea5 Should be "Done" when user-facing 2025-11-17 16:59:56 -06:00
Jason Zimdars 91d1cd9bd4 Merge pull request #1590 from basecamp/activity-user-filter
Activity user filter
2025-11-17 16:56:37 -06:00
Jason Zimdars d8f519d7bf Adjust so the filters are only displayed when useful 2025-11-17 16:52:10 -06:00
Mike Dalessio da7219722f Merge pull request #1618 from basecamp/flavorjones/card-created-at
Update a card's `created_at` when it is published
2025-11-17 17:46:14 -05:00
Mike Dalessio 97a6916ae1 Update a card's created_at when it is published
ref: https://app.fizzy.do/5986089/cards/2854
2025-11-17 17:39:25 -05:00
Jason Fried 8534584052 Small copy adjustment on the new or sign in screen. 2025-11-17 13:14:12 -08:00
Mike Dalessio 695037c7ee Make sure rack-mini-profiler doesn't load in test 2025-11-17 15:03:26 -05:00
Mike Dalessio e3ce26c53d rubocop: more style fixes 2025-11-17 14:54:42 -05:00
Mike Dalessio f98478ee1e Merge pull request #1612 from basecamp/flavorjones/debounce-sign-in-enter
Prevent multiple form submissions during sign-in
2025-11-17 14:54:01 -05:00
Jason Zimdars fb19eb3586 Merge pull request #1613 from basecamp/menu-zoom-fix
Menu zoom fix
2025-11-17 13:51:59 -06:00
Mike Dalessio 6a3135b67a Introduce a simple stimulus controller for the magic link form
which avoids the double-submit problem from:

- https://app.fizzy.do/5986089/cards/2980
- https://app.fizzy.do/5986089/cards/2771
2025-11-17 14:48:20 -05:00
Jason Zimdars fdf02c8fe2 Don't allow zooming inside PWAs 2025-11-17 13:47:57 -06:00
Jason Zimdars 561542922c Target Safari to enforce min font size
Prevents zooming the viewport on Mobile Safari
2025-11-17 13:47:37 -06:00
Stanko K.R. b7404087bd Fix schema incomatibilities with production 2025-11-17 20:31:42 +01:00
Jorge Manrubia d263649b7e Extract partials 2025-11-17 20:21:56 +01:00
Jorge Manrubia 22d042b900 Fix typo with tag 2025-11-17 20:21:56 +01:00
Jason Zimdars 54197c0ef3 Add a user filter 2025-11-17 20:21:56 +01:00
Jason Zimdars 0e5e8d5019 Whitespace 2025-11-17 20:21:56 +01:00