Commit Graph

2119 Commits

Author SHA1 Message Date
David Heinemeier Hansson cf3cbccf23 Indention 2025-04-22 21:56:23 +02:00
David Heinemeier Hansson 93516f2e48 @collection is always available when card scoped 2025-04-22 21:51:38 +02:00
David Heinemeier Hansson dff55d6cb6 Style 2025-04-22 21:48:32 +02:00
David Heinemeier Hansson 5048e9c970 Duh, no before destroy commit, but this is still not right! 2025-04-22 21:40:30 +02:00
David Heinemeier Hansson 7124835e60 No long transactions!
If you intend to deactivate someone, and the process fails mid process,
so you only delete some sessions, or some accesses, you are actually
fine. The system is never left in an incomplete state. And that's really
the only time we should be using transactions with sqlite3 -- to prevent
actual data integrity issues.

The rest of the time, we should optimize for each transaction to be as
quick as possible. The sqlite3 writer lock is the one bottleneck that we
cant afford to overload.
2025-04-22 21:29:03 +02:00
David Heinemeier Hansson 90f05b7310 But feels more essentially part of the User, so list first 2025-04-22 21:25:30 +02:00
David Heinemeier Hansson 72d1d0baee Not related to the other two 2025-04-22 21:24:51 +02:00
David Heinemeier Hansson ad1e97767d Style 2025-04-22 21:22:42 +02:00
David Heinemeier Hansson c4fbed3156 Try a slimmer version
And I actually stopped liking that setup automatically starts the
server.
2025-04-22 21:20:55 +02:00
David Heinemeier Hansson 6cd8d54bf7 We werent using any of the other avatar methods 2025-04-22 21:20:18 +02:00
David Heinemeier Hansson 134333ae44 Dont do a lot of work inside a single transaction
Especially with sqlite3!
2025-04-22 21:01:11 +02:00
David Heinemeier Hansson 78d186bebd Really liking the new it-style yields in many places 2025-04-22 20:59:49 +02:00
Mike Dalessio bcd6468dc7 Merge pull request #424 from basecamp/dependabot/bundler/nokogiri-1.18.8
Bump nokogiri from 1.18.7 to 1.18.8
2025-04-22 11:48:50 -04:00
David Heinemeier Hansson dcf135c003 Fix rubocop 2025-04-22 14:45:22 +02:00
David Heinemeier Hansson 3d28203224 Use singular staging resource and beef up testing 2025-04-22 14:44:55 +02:00
David Heinemeier Hansson 5ea0ec8cb4 Test and fix setting workflow to nothing 2025-04-22 13:05:39 +02:00
David Heinemeier Hansson 8e35a3de9c Test workflowing updates card stages on change 2025-04-22 13:03:31 +02:00
David Heinemeier Hansson a7d17b38aa Be confident 2025-04-22 12:44:49 +02:00
David Heinemeier Hansson 827c00ce49 Extract Workflowing concern 2025-04-22 12:32:34 +02:00
David Heinemeier Hansson 20a2965181 Keep scopes together 2025-04-22 12:12:30 +02:00
David Heinemeier Hansson 7a46fd0948 Stick with open/close as a consistent pair instead of active/close 2025-04-22 12:08:56 +02:00
David Heinemeier Hansson 22abf0ba46 Remove anemic concern
Colors are a card concern.
2025-04-22 11:56:41 +02:00
David Heinemeier Hansson 268e367c6f Unused 2025-04-22 11:53:16 +02:00
David Heinemeier Hansson 2d5901fe1e Fix pin turbo stream response rendering 2025-04-22 11:48:19 +02:00
David Heinemeier Hansson 9b9acf36ae Events track due_date changes in particulars, not as a direct attribute 2025-04-22 11:21:09 +02:00
David Heinemeier Hansson 58c7eb41bb AI slop for the honcho seed data 2025-04-22 09:55:59 +02:00
dependabot[bot] 682da733da Bump nokogiri from 1.18.7 to 1.18.8
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.18.7 to 1.18.8.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.18.7...v1.18.8)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-version: 1.18.8
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-22 04:58:30 +00:00
Mike Dalessio 5b10b3a16e Merge pull request #421 from basecamp/flavorjones-dep-rails-e9ee790d
dep: update rails to `e9ee790d`
2025-04-21 13:05:52 -04:00
Mike Dalessio 01d741b3f4 dep: update rails 2025-04-21 13:03:49 -04:00
Jorge Manrubia 6d4691f32b Merge pull request #420 from basecamp/descriptions-fix
Add card's description field
2025-04-21 17:28:18 +02:00
Jorge Manrubia 4f0cf0f5cb Fix autosave working with the new description field 2025-04-21 17:05:35 +02:00
Jorge Manrubia 2c3ec3e806 Fix: Create new cards wasn't working 2025-04-21 17:00:25 +02:00
Jorge Manrubia 1680095266 Remove invalid " 2025-04-21 16:45:35 +02:00
Jorge Manrubia b0aae3ad9e Reapply "Add a description field for cards"
This reverts commit a4cc143b09.
2025-04-21 16:45:24 +02:00
Jorge Manrubia 6392180493 Merge pull request #419 from basecamp/revert-408-add-card-description
Revert "Add a description field for cards"
2025-04-21 16:42:09 +02:00
Jorge Manrubia a4cc143b09 Revert "Add a description field for cards" 2025-04-21 16:41:33 +02:00
David Heinemeier Hansson 4d1a1382e1 Fix seeds for new descriptions 2025-04-21 16:21:20 +02:00
Jorge Manrubia 9ecd7f7a60 Merge pull request #408 from basecamp/add-card-description
Add a description field for cards
2025-04-21 16:06:47 +02:00
Jorge Manrubia fb83b5e70e Merge branch 'main' into add-card-description
* main:
  Fix trailing empty line
  --skip-server in ci setup
  Enumerate all the options for logging in
  Have an empty first-run tenant too
  Convert to conventional Rails style
  Seed multiple seed accounts with basic DSL
  Stlye
  No need to run Solid Cache in development
  Use morphing to replace the card and exclude turbo frames from being replaced
  Name is already schema and UI required
  Cards have a not-null schema and collections destroy all cards on deletion
  No longer used
  Inline touch check thats only used once

# Conflicts:
#	app/views/cards/_container.html.erb
2025-04-21 16:04:06 +02:00
David Heinemeier Hansson 539b26c7df Small enough DSL to inline it 2025-04-21 16:01:01 +02:00
David Heinemeier Hansson 55789b7a34 Merge pull request #416 from basecamp/replace-with-morph
Use morphing in the stream replace the card container
2025-04-21 15:40:28 +02:00
David Heinemeier Hansson ad2c1ca8fc Merge pull request #418 from basecamp/seed-multiple-dev-accounts
Seed multiple seed accounts with basic DSL
2025-04-21 15:27:10 +02:00
David Heinemeier Hansson 581070b22c Fix trailing empty line 2025-04-21 15:26:47 +02:00
David Heinemeier Hansson e1b2b623e8 --skip-server in ci setup 2025-04-21 15:26:19 +02:00
David Heinemeier Hansson 29948d8881 Enumerate all the options for logging in 2025-04-21 15:23:31 +02:00
David Heinemeier Hansson dc12751192 Have an empty first-run tenant too 2025-04-21 15:23:18 +02:00
David Heinemeier Hansson 2bfead0381 Convert to conventional Rails style 2025-04-21 15:23:08 +02:00
Jorge Manrubia 99dbc04e2c Format 2025-04-21 15:20:03 +02:00
Jorge Manrubia ffdec1cc3b Index description too 2025-04-21 15:18:11 +02:00
David Heinemeier Hansson b6584ed655 Seed multiple seed accounts with basic DSL 2025-04-21 15:12:57 +02:00