dff55d6cb6
Style
2025-04-22 21:48:32 +02:00
5048e9c970
Duh, no before destroy commit, but this is still not right!
2025-04-22 21:40:30 +02:00
7124835e60
No long transactions!
...
If you intend to deactivate someone, and the process fails mid process,
so you only delete some sessions, or some accesses, you are actually
fine. The system is never left in an incomplete state. And that's really
the only time we should be using transactions with sqlite3 -- to prevent
actual data integrity issues.
The rest of the time, we should optimize for each transaction to be as
quick as possible. The sqlite3 writer lock is the one bottleneck that we
cant afford to overload.
2025-04-22 21:29:03 +02:00
90f05b7310
But feels more essentially part of the User, so list first
2025-04-22 21:25:30 +02:00
72d1d0baee
Not related to the other two
2025-04-22 21:24:51 +02:00
ad1e97767d
Style
2025-04-22 21:22:42 +02:00
6cd8d54bf7
We werent using any of the other avatar methods
2025-04-22 21:20:18 +02:00
134333ae44
Dont do a lot of work inside a single transaction
...
Especially with sqlite3!
2025-04-22 21:01:11 +02:00
78d186bebd
Really liking the new it-style yields in many places
2025-04-22 20:59:49 +02:00
3d28203224
Use singular staging resource and beef up testing
2025-04-22 14:44:55 +02:00
5ea0ec8cb4
Test and fix setting workflow to nothing
2025-04-22 13:05:39 +02:00
a7d17b38aa
Be confident
2025-04-22 12:44:49 +02:00
827c00ce49
Extract Workflowing concern
2025-04-22 12:32:34 +02:00
20a2965181
Keep scopes together
2025-04-22 12:12:30 +02:00
7a46fd0948
Stick with open/close as a consistent pair instead of active/close
2025-04-22 12:08:56 +02:00
22abf0ba46
Remove anemic concern
...
Colors are a card concern.
2025-04-22 11:56:41 +02:00
268e367c6f
Unused
2025-04-22 11:53:16 +02:00
b0aae3ad9e
Reapply "Add a description field for cards"
...
This reverts commit a4cc143b09
2025-04-21 16:45:24 +02:00
a4cc143b09
Revert "Add a description field for cards"
2025-04-21 16:41:33 +02:00
fb83b5e70e
Merge branch 'main' into add-card-description
...
* main:
Fix trailing empty line
--skip-server in ci setup
Enumerate all the options for logging in
Have an empty first-run tenant too
Convert to conventional Rails style
Seed multiple seed accounts with basic DSL
Stlye
No need to run Solid Cache in development
Use morphing to replace the card and exclude turbo frames from being replaced
Name is already schema and UI required
Cards have a not-null schema and collections destroy all cards on deletion
No longer used
Inline touch check thats only used once
# Conflicts:
# app/views/cards/_container.html.erb
2025-04-21 16:04:06 +02:00
99dbc04e2c
Format
2025-04-21 15:20:03 +02:00
ffdec1cc3b
Index description too
2025-04-21 15:18:11 +02:00
491e743c27
Place below associations
2025-04-21 14:48:07 +02:00
89d1b316f0
Name is already schema and UI required
...
And we are not using these validations for display anywhere.
2025-04-21 09:21:55 +02:00
dc2205ee79
Cards have a not-null schema and collections destroy all cards on deletion
...
This shouldnt be necessary. Maybe remnant of some previous design?
2025-04-21 09:18:42 +02:00
ccd98f6d98
Update card.rb
2025-04-19 20:01:41 +02:00
9e921b85c0
Merge branch 'main' into add-card-description
2025-04-19 20:00:43 +02:00
78369725c4
Move card concern logic into those concerns
2025-04-18 17:18:28 +02:00
cacee0febb
Remove anemic scope
2025-04-18 17:18:13 +02:00
f368b9f9c9
Inline anemic method
2025-04-18 17:13:11 +02:00
aae6c7b1a2
Indention
2025-04-18 17:09:55 +02:00
7c76bdd96d
Drop Scorable concern
2025-04-18 17:07:36 +02:00
7b0d3d033f
Fix extra space
2025-04-18 16:08:53 +02:00
f6cd21f7cb
Extract default stages into something that will be created together with a new Workflow in the model
2025-04-18 16:07:01 +02:00
47d0ae98a1
Remove DraftCommenting
2025-04-16 19:01:21 -05:00
7b3b5c471b
Add a description filed for cards
2025-04-16 18:53:26 -05:00
2ced8e643d
Clarify a bit
2025-04-16 17:01:32 +02:00
2757cd8e62
Dont render inline
2025-04-16 16:49:16 +02:00
4bb9085737
Hide implementation detail of reading
2025-04-16 16:41:22 +02:00
397fc1d2bd
Only broadcast creations
2025-04-16 16:21:54 +02:00
b9f5293231
Style
2025-04-15 16:15:13 +02:00
f30a9308d2
Line up scopes in order of the flow
2025-04-15 16:13:54 +02:00
8e479dddba
Clearer still
2025-04-15 16:04:11 +02:00
5d22809e29
No public use of this concept, so inline it
2025-04-15 16:03:14 +02:00
680611503d
Distinguish between administering and just changing
2025-04-15 16:00:29 +02:00
a6a96fd5c8
Dont repeat the same checks from doing, make it clearer where the difference is
2025-04-15 15:55:29 +02:00
af0a42080b
Allow users to edit themselves
2025-04-15 15:35:39 +02:00
5b524254b9
Merge pull request #403 from basecamp/commit-to-single-account
...
The tenanted db is the account scope
2025-04-13 07:58:12 +02:00
cf93da6886
Get rid of card_title
...
We can just set untitled on assignment of empty
2025-04-12 21:29:56 +02:00
c463f342bf
Ensure user is returned
2025-04-12 20:30:28 +02:00
David Heinemeier Hansson