cfa2f2d1f9
Trailing spaces
2025-04-16 17:02:48 +02:00
2ced8e643d
Clarify a bit
2025-04-16 17:01:32 +02:00
d8ec2c3364
More natural to fetch that which will be shown first
2025-04-16 16:58:03 +02:00
5ce289642f
Rely on caching of notifications
2025-04-16 16:57:54 +02:00
6135909b7e
Card readings just need to remove the notification
...
No need to broadcast everything again
2025-04-16 16:51:18 +02:00
2757cd8e62
Dont render inline
2025-04-16 16:49:16 +02:00
98401b9536
Explain this
2025-04-16 16:44:04 +02:00
4bb9085737
Hide implementation detail of reading
2025-04-16 16:41:22 +02:00
91194d1b66
Fixed up controller test
2025-04-16 16:37:06 +02:00
ac3307ee23
Allow for the footer frames to be hidden on the notifications page
...
Otherwise you will have multiple notification dom elements with the same
id.
2025-04-16 16:23:05 +02:00
158b694d31
Simplify the containers
...
Need to use CSS to hide headings in empty containers
2025-04-16 16:22:36 +02:00
397fc1d2bd
Only broadcast creations
2025-04-16 16:21:54 +02:00
8ff71b2650
Dont turbo stream when coming from a read_all redirect
2025-04-16 16:21:31 +02:00
5932bf9316
This is rare enough that a redirect is fine
2025-04-16 16:21:16 +02:00
f9952e0fd6
Style
2025-04-16 15:57:02 +02:00
d00a0433e9
Inline anemic method
2025-04-16 15:34:28 +02:00
13c44ba650
Actually need it for the lazy load of course
2025-04-16 12:00:54 +02:00
980345d176
Drop the frame, we will do it with streams
2025-04-16 12:00:11 +02:00
3fc34257c4
No longer used
2025-04-16 11:59:58 +02:00
50e4587dd9
Fix trailing spaces
2025-04-16 11:56:21 +02:00
375afeac7b
Fix test
2025-04-16 11:55:35 +02:00
73f272f132
Use one controller for all notification readings
2025-04-15 19:14:50 +02:00
2ea898324f
We can just set the namespace directly in the class name
2025-04-15 16:36:40 +02:00
ac65f39c0d
Inline anemic partial
2025-04-15 16:32:56 +02:00
b9f5293231
Style
2025-04-15 16:15:13 +02:00
f30a9308d2
Line up scopes in order of the flow
2025-04-15 16:13:54 +02:00
8e479dddba
Clearer still
2025-04-15 16:04:11 +02:00
5d22809e29
No public use of this concept, so inline it
2025-04-15 16:03:14 +02:00
680611503d
Distinguish between administering and just changing
2025-04-15 16:00:29 +02:00
a6a96fd5c8
Dont repeat the same checks from doing, make it clearer where the difference is
2025-04-15 15:55:29 +02:00
93178636cd
Flesh out all the tests
2025-04-15 15:41:01 +02:00
2e8df45680
Flesh out tests for users controller
2025-04-15 15:36:11 +02:00
af0a42080b
Allow users to edit themselves
2025-04-15 15:35:39 +02:00
abd2af3d8a
Dont need an index for a single record
2025-04-15 15:35:28 +02:00
2ace519d91
There is only one account, so just check join code directly
2025-04-15 15:35:10 +02:00
7e5f71fedd
We will only have one account record per account
...
Not sure why this was added in the first place.
2025-04-15 15:17:30 +02:00
61b24483a7
Deploy to new node
...
Our production node has been replaced; `fizzy-app-101` is the new one.
2025-04-15 09:38:02 +01:00
028a43e652
Title is on the related card
2025-04-14 15:50:24 +01:00
bc8060a2dd
Merge pull request #399 from basecamp/consolidate-cards
...
Consolidate cards
2025-04-14 09:40:58 -05:00
a88264ed0a
Merge branch 'main' into consolidate-cards
...
* main: (94 commits)
Source order seems to be significant
Use `card.title`
Nicer flow
Fix string interpolation
Fix constant
Use record lookup
Always use sole
Explained less and extracted nothing of value
Weird double negative
Remove anemic and indirect method that explained nothing
Can use record lookup for workflows
Access control has already been done through the card
Style
Use _path in all cases where we are not potentially changing the domain
Clearer
Spacing
Get rid of card_title
Join the two users controllers but split out role setting
Ensure user is returned
We are not using the parameter
...
2025-04-14 09:40:22 -05:00
289487a383
Source order seems to be significant
...
Regressed in d3c5c86b21
2025-04-14 09:23:57 -05:00
3cfdaf1129
Use card.title
2025-04-14 08:54:54 -05:00
cfb345bc32
Nicer flow
2025-04-13 20:39:09 +02:00
80c518b7e1
Fix string interpolation
2025-04-13 20:36:16 +02:00
e8a730c239
Fix constant
2025-04-13 20:36:07 +02:00
34232c0e31
Use record lookup
2025-04-13 20:30:03 +02:00
d9a9690137
Always use sole
2025-04-13 20:29:10 +02:00
9e0b9c08c2
Explained less and extracted nothing of value
2025-04-13 20:28:35 +02:00
33278469ef
Weird double negative
2025-04-13 20:26:58 +02:00
a5df54015e
Remove anemic and indirect method that explained nothing
2025-04-13 20:25:59 +02:00
David Heinemeier Hansson